Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Missing **kwargs in apply_ fallback #664

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 6, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2024
@vmoens vmoens added the bug Something isn't working label Feb 6, 2024
@vmoens vmoens merged commit ef9e101 into main Feb 6, 2024
42 of 43 checks passed
@vmoens vmoens deleted the fix-missing-kwarg-apply_ branch February 6, 2024 16:35
Copy link

github-actions bot commented Feb 6, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 124. Improved: $\large\color{#35bf28}18$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 33.3120μs 16.0243μs 62.4051 KOps/s 60.3081 KOps/s $\color{#35bf28}+3.48\%$
test_plain_set_stack_nested 0.2000ms 0.1470ms 6.8024 KOps/s 6.9756 KOps/s $\color{#d91a1a}-2.48\%$
test_plain_set_nested_inplace 71.2990μs 18.2891μs 54.6775 KOps/s 52.4352 KOps/s $\color{#35bf28}+4.28\%$
test_plain_set_stack_nested_inplace 0.2427ms 0.1780ms 5.6173 KOps/s 5.5694 KOps/s $\color{#35bf28}+0.86\%$
test_items 25.3170μs 2.4488μs 408.3558 KOps/s 396.0954 KOps/s $\color{#35bf28}+3.10\%$
test_items_nested 3.8376ms 0.2666ms 3.7514 KOps/s 3.6625 KOps/s $\color{#35bf28}+2.43\%$
test_items_nested_locked 0.4908ms 0.2698ms 3.7062 KOps/s 3.6782 KOps/s $\color{#35bf28}+0.76\%$
test_items_nested_leaf 3.1491ms 0.1685ms 5.9357 KOps/s 5.9422 KOps/s $\color{#d91a1a}-0.11\%$
test_items_stack_nested 1.6476ms 1.3568ms 737.0343 Ops/s 746.5447 Ops/s $\color{#d91a1a}-1.27\%$
test_items_stack_nested_leaf 1.6820ms 1.2281ms 814.2350 Ops/s 829.9399 Ops/s $\color{#d91a1a}-1.89\%$
test_items_stack_nested_locked 1.2443ms 0.8802ms 1.1361 KOps/s 1.1365 KOps/s $\color{#d91a1a}-0.03\%$
test_keys 16.2600μs 4.0049μs 249.6948 KOps/s 253.8536 KOps/s $\color{#d91a1a}-1.64\%$
test_keys_nested 1.8065ms 0.1494ms 6.6937 KOps/s 6.7745 KOps/s $\color{#d91a1a}-1.19\%$
test_keys_nested_locked 0.2547ms 0.1519ms 6.5838 KOps/s 6.5775 KOps/s $\color{#35bf28}+0.10\%$
test_keys_nested_leaf 0.2493ms 0.1312ms 7.6237 KOps/s 7.6457 KOps/s $\color{#d91a1a}-0.29\%$
test_keys_stack_nested 1.5805ms 1.2894ms 775.5417 Ops/s 783.1476 Ops/s $\color{#d91a1a}-0.97\%$
test_keys_stack_nested_leaf 1.5576ms 1.2866ms 777.2402 Ops/s 758.4125 Ops/s $\color{#35bf28}+2.48\%$
test_keys_stack_nested_locked 1.0475ms 0.8079ms 1.2377 KOps/s 1.2326 KOps/s $\color{#35bf28}+0.42\%$
test_values 9.7783μs 1.1450μs 873.3334 KOps/s 872.6634 KOps/s $\color{#35bf28}+0.08\%$
test_values_nested 91.4090μs 51.8274μs 19.2948 KOps/s 19.2341 KOps/s $\color{#35bf28}+0.32\%$
test_values_nested_locked 0.1102ms 51.9347μs 19.2549 KOps/s 19.2031 KOps/s $\color{#35bf28}+0.27\%$
test_values_nested_leaf 0.1322ms 46.2655μs 21.6144 KOps/s 21.2513 KOps/s $\color{#35bf28}+1.71\%$
test_values_stack_nested 1.2390ms 1.0539ms 948.8496 Ops/s 925.3143 Ops/s $\color{#35bf28}+2.54\%$
test_values_stack_nested_leaf 1.7228ms 1.0534ms 949.2941 Ops/s 968.0179 Ops/s $\color{#d91a1a}-1.93\%$
test_values_stack_nested_locked 1.3459ms 0.6019ms 1.6614 KOps/s 1.6527 KOps/s $\color{#35bf28}+0.53\%$
test_membership 17.6030μs 1.3481μs 741.7989 KOps/s 737.4970 KOps/s $\color{#35bf28}+0.58\%$
test_membership_nested 30.0260μs 3.4098μs 293.2743 KOps/s 287.5092 KOps/s $\color{#35bf28}+2.01\%$
test_membership_nested_leaf 31.6090μs 3.4347μs 291.1436 KOps/s 277.6762 KOps/s $\color{#35bf28}+4.85\%$
test_membership_stacked_nested 43.8610μs 12.0657μs 82.8797 KOps/s 84.4147 KOps/s $\color{#d91a1a}-1.82\%$
test_membership_stacked_nested_leaf 39.7340μs 12.0458μs 83.0163 KOps/s 84.2124 KOps/s $\color{#d91a1a}-1.42\%$
test_membership_nested_last 36.5880μs 6.6205μs 151.0453 KOps/s 151.3661 KOps/s $\color{#d91a1a}-0.21\%$
test_membership_nested_leaf_last 34.4840μs 6.5763μs 152.0607 KOps/s 149.3654 KOps/s $\color{#35bf28}+1.80\%$
test_membership_stacked_nested_last 0.2923ms 0.1794ms 5.5752 KOps/s 5.7012 KOps/s $\color{#d91a1a}-2.21\%$
test_membership_stacked_nested_leaf_last 42.3890μs 14.0789μs 71.0282 KOps/s 71.6485 KOps/s $\color{#d91a1a}-0.87\%$
test_nested_getleaf 36.3280μs 10.7930μs 92.6530 KOps/s 94.3930 KOps/s $\color{#d91a1a}-1.84\%$
test_nested_get 41.8880μs 10.2316μs 97.7361 KOps/s 99.0279 KOps/s $\color{#d91a1a}-1.30\%$
test_stacked_getleaf 0.6728ms 0.4012ms 2.4928 KOps/s 2.5117 KOps/s $\color{#d91a1a}-0.75\%$
test_stacked_get 0.5929ms 0.3715ms 2.6916 KOps/s 2.7533 KOps/s $\color{#d91a1a}-2.24\%$
test_nested_getitemleaf 40.1450μs 12.0543μs 82.9577 KOps/s 82.4926 KOps/s $\color{#35bf28}+0.56\%$
test_nested_getitem 61.0030μs 11.5577μs 86.5222 KOps/s 86.7143 KOps/s $\color{#d91a1a}-0.22\%$
test_stacked_getitemleaf 0.6341ms 0.4078ms 2.4521 KOps/s 2.4484 KOps/s $\color{#35bf28}+0.15\%$
test_stacked_getitem 0.5632ms 0.3743ms 2.6713 KOps/s 2.6879 KOps/s $\color{#d91a1a}-0.62\%$
test_lock_nested 3.0149ms 0.3404ms 2.9377 KOps/s 2.7930 KOps/s $\textbf{\color{#35bf28}+5.18\%}$
test_lock_stack_nested 90.2232ms 6.2939ms 158.8831 Ops/s 152.9795 Ops/s $\color{#35bf28}+3.86\%$
test_unlock_nested 83.4787ms 0.4309ms 2.3210 KOps/s 2.7729 KOps/s $\textbf{\color{#d91a1a}-16.30\%}$
test_unlock_stack_nested 94.0137ms 6.5956ms 151.6168 Ops/s 150.4745 Ops/s $\color{#35bf28}+0.76\%$
test_flatten_speed 0.9022ms 0.3667ms 2.7272 KOps/s 2.6972 KOps/s $\color{#35bf28}+1.11\%$
test_unflatten_speed 0.7803ms 0.4770ms 2.0963 KOps/s 2.1151 KOps/s $\color{#d91a1a}-0.89\%$
test_common_ops 1.1994ms 0.6510ms 1.5360 KOps/s 1.4191 KOps/s $\textbf{\color{#35bf28}+8.24\%}$
test_creation 20.3380μs 1.8312μs 546.0825 KOps/s 544.3170 KOps/s $\color{#35bf28}+0.32\%$
test_creation_empty 26.2690μs 8.2677μs 120.9525 KOps/s 106.9764 KOps/s $\textbf{\color{#35bf28}+13.06\%}$
test_creation_nested_1 50.9540μs 10.8425μs 92.2300 KOps/s 83.8274 KOps/s $\textbf{\color{#35bf28}+10.02\%}$
test_creation_nested_2 32.9520μs 14.1491μs 70.6757 KOps/s 64.7149 KOps/s $\textbf{\color{#35bf28}+9.21\%}$
test_clone 85.6290μs 13.2122μs 75.6879 KOps/s 74.0958 KOps/s $\color{#35bf28}+2.15\%$
test_getitem[int] 32.1000μs 11.0171μs 90.7678 KOps/s 86.9725 KOps/s $\color{#35bf28}+4.36\%$
test_getitem[slice_int] 94.8960μs 22.4947μs 44.4550 KOps/s 43.8972 KOps/s $\color{#35bf28}+1.27\%$
test_getitem[range] 0.1909ms 41.2600μs 24.2365 KOps/s 22.5610 KOps/s $\textbf{\color{#35bf28}+7.43\%}$
test_getitem[tuple] 64.2000μs 18.2054μs 54.9287 KOps/s 53.3489 KOps/s $\color{#35bf28}+2.96\%$
test_getitem[list] 0.1836ms 36.2367μs 27.5964 KOps/s 25.5551 KOps/s $\textbf{\color{#35bf28}+7.99\%}$
test_setitem_dim[int] 49.8020μs 27.5101μs 36.3503 KOps/s 33.7747 KOps/s $\textbf{\color{#35bf28}+7.63\%}$
test_setitem_dim[slice_int] 97.0900μs 51.2613μs 19.5079 KOps/s 18.3490 KOps/s $\textbf{\color{#35bf28}+6.32\%}$
test_setitem_dim[range] 0.1249ms 71.7750μs 13.9324 KOps/s 13.1375 KOps/s $\textbf{\color{#35bf28}+6.05\%}$
test_setitem_dim[tuple] 79.2070μs 41.5789μs 24.0507 KOps/s 22.8854 KOps/s $\textbf{\color{#35bf28}+5.09\%}$
test_setitem 75.4600μs 18.9429μs 52.7901 KOps/s 51.3907 KOps/s $\color{#35bf28}+2.72\%$
test_set 85.3080μs 17.6765μs 56.5724 KOps/s 53.1135 KOps/s $\textbf{\color{#35bf28}+6.51\%}$
test_set_shared 3.1690ms 0.1397ms 7.1596 KOps/s 6.8027 KOps/s $\textbf{\color{#35bf28}+5.25\%}$
test_update 0.1442ms 19.9977μs 50.0057 KOps/s 47.6224 KOps/s $\textbf{\color{#35bf28}+5.00\%}$
test_update_nested 95.6980μs 28.3177μs 35.3136 KOps/s 34.6299 KOps/s $\color{#35bf28}+1.97\%$
test_set_nested 0.1017ms 20.9542μs 47.7231 KOps/s 47.8175 KOps/s $\color{#d91a1a}-0.20\%$
test_set_nested_new 87.4420μs 24.0974μs 41.4983 KOps/s 40.7507 KOps/s $\color{#35bf28}+1.83\%$
test_select 0.1345ms 37.3140μs 26.7996 KOps/s 26.3865 KOps/s $\color{#35bf28}+1.57\%$
test_select_nested 0.1120ms 59.2935μs 16.8653 KOps/s 17.0862 KOps/s $\color{#d91a1a}-1.29\%$
test_exclude_nested 0.2152ms 0.1196ms 8.3647 KOps/s 8.4580 KOps/s $\color{#d91a1a}-1.10\%$
test_empty[True] 1.2336ms 0.4221ms 2.3690 KOps/s 2.3942 KOps/s $\color{#d91a1a}-1.05\%$
test_empty[False] 8.4016μs 1.0708μs 933.8752 KOps/s 953.3325 KOps/s $\color{#d91a1a}-2.04\%$
test_unbind_speed 0.4927ms 0.2544ms 3.9311 KOps/s 3.8482 KOps/s $\color{#35bf28}+2.16\%$
test_unbind_speed_stack0 88.9711ms 3.8288ms 261.1754 Ops/s 276.6176 Ops/s $\textbf{\color{#d91a1a}-5.58\%}$
test_unbind_speed_stack1 25.3870μs 1.9501μs 512.8026 KOps/s 499.2464 KOps/s $\color{#35bf28}+2.72\%$
test_split 2.3303ms 1.4606ms 684.6573 Ops/s 670.0244 Ops/s $\color{#35bf28}+2.18\%$
test_chunk 81.6077ms 1.5754ms 634.7516 Ops/s 612.6346 Ops/s $\color{#35bf28}+3.61\%$
test_creation[device0] 0.2207ms 0.1033ms 9.6826 KOps/s 9.4035 KOps/s $\color{#35bf28}+2.97\%$
test_creation_from_tensor 3.2547ms 81.1918μs 12.3165 KOps/s 12.1254 KOps/s $\color{#35bf28}+1.58\%$
test_add_one[memmap_tensor0] 0.3567ms 5.3177μs 188.0496 KOps/s 183.8364 KOps/s $\color{#35bf28}+2.29\%$
test_contiguous[memmap_tensor0] 8.5360μs 0.6339μs 1.5776 MOps/s 1.5888 MOps/s $\color{#d91a1a}-0.70\%$
test_stack[memmap_tensor0] 51.2060μs 3.5396μs 282.5178 KOps/s 277.9481 KOps/s $\color{#35bf28}+1.64\%$
test_memmaptd_index 1.0393ms 0.2349ms 4.2574 KOps/s 4.2162 KOps/s $\color{#35bf28}+0.98\%$
test_memmaptd_index_astensor 0.7038ms 0.3021ms 3.3106 KOps/s 3.3074 KOps/s $\color{#35bf28}+0.10\%$
test_memmaptd_index_op 1.2908ms 0.5535ms 1.8067 KOps/s 1.6931 KOps/s $\textbf{\color{#35bf28}+6.71\%}$
test_serialize_model 0.1996s 0.1147s 8.7206 Ops/s 8.7529 Ops/s $\color{#d91a1a}-0.37\%$
test_serialize_model_pickle 0.4470s 0.3757s 2.6619 Ops/s 2.6281 Ops/s $\color{#35bf28}+1.29\%$
test_serialize_weights 0.1846s 0.1084s 9.2222 Ops/s 9.7158 Ops/s $\textbf{\color{#d91a1a}-5.08\%}$
test_serialize_weights_returnearly 0.2542s 0.1369s 7.3039 Ops/s 7.0254 Ops/s $\color{#35bf28}+3.96\%$
test_serialize_weights_pickle 0.9938s 0.6240s 1.6026 Ops/s 2.3924 Ops/s $\textbf{\color{#d91a1a}-33.01\%}$
test_serialize_weights_filesystem 98.9546ms 95.1177ms 10.5133 Ops/s 10.8898 Ops/s $\color{#d91a1a}-3.46\%$
test_serialize_model_filesystem 0.1806s 0.1021s 9.7896 Ops/s 9.5861 Ops/s $\color{#35bf28}+2.12\%$
test_reshape_pytree 75.3000μs 20.5637μs 48.6295 KOps/s 47.0852 KOps/s $\color{#35bf28}+3.28\%$
test_reshape_td 74.8290μs 31.2620μs 31.9877 KOps/s 31.4665 KOps/s $\color{#35bf28}+1.66\%$
test_view_pytree 56.4550μs 20.8279μs 48.0125 KOps/s 47.5568 KOps/s $\color{#35bf28}+0.96\%$
test_view_td 0.7288ms 8.0872μs 123.6519 KOps/s 79.8821 KOps/s $\textbf{\color{#35bf28}+54.79\%}$
test_unbind_pytree 56.9660μs 24.2792μs 41.1875 KOps/s 40.4743 KOps/s $\color{#35bf28}+1.76\%$
test_unbind_td 0.1426ms 36.2708μs 27.5704 KOps/s 27.1957 KOps/s $\color{#35bf28}+1.38\%$
test_split_pytree 79.4780μs 24.1964μs 41.3284 KOps/s 42.0689 KOps/s $\color{#d91a1a}-1.76\%$
test_split_td 0.5896ms 39.4295μs 25.3617 KOps/s 24.8300 KOps/s $\color{#35bf28}+2.14\%$
test_add_pytree 69.6900μs 29.1003μs 34.3639 KOps/s 33.4773 KOps/s $\color{#35bf28}+2.65\%$
test_add_td 0.1004ms 50.4700μs 19.8137 KOps/s 18.7792 KOps/s $\textbf{\color{#35bf28}+5.51\%}$
test_distributed 0.2255ms 99.8744μs 10.0126 KOps/s 9.5475 KOps/s $\color{#35bf28}+4.87\%$
test_tdmodule 0.3178ms 21.6666μs 46.1539 KOps/s 44.9667 KOps/s $\color{#35bf28}+2.64\%$
test_tdmodule_dispatch 0.2132ms 41.9619μs 23.8312 KOps/s 22.9426 KOps/s $\color{#35bf28}+3.87\%$
test_tdseq 59.1800μs 24.9638μs 40.0580 KOps/s 38.5574 KOps/s $\color{#35bf28}+3.89\%$
test_tdseq_dispatch 0.1451ms 46.3103μs 21.5935 KOps/s 20.8290 KOps/s $\color{#35bf28}+3.67\%$
test_instantiation_functorch 1.7337ms 1.3214ms 756.7748 Ops/s 762.5661 Ops/s $\color{#d91a1a}-0.76\%$
test_instantiation_td 1.7920ms 1.0366ms 964.6556 Ops/s 998.4117 Ops/s $\color{#d91a1a}-3.38\%$
test_exec_functorch 0.2845ms 0.1574ms 6.3549 KOps/s 6.2297 KOps/s $\color{#35bf28}+2.01\%$
test_exec_functional_call 0.2783ms 0.1467ms 6.8157 KOps/s 6.7489 KOps/s $\color{#35bf28}+0.99\%$
test_exec_td 0.2770ms 0.1431ms 6.9889 KOps/s 6.7971 KOps/s $\color{#35bf28}+2.82\%$
test_exec_td_decorator 0.5444ms 0.1990ms 5.0260 KOps/s 4.9247 KOps/s $\color{#35bf28}+2.06\%$
test_vmap_mlp_speed[True-True] 1.3692ms 0.8872ms 1.1271 KOps/s 1.1155 KOps/s $\color{#35bf28}+1.04\%$
test_vmap_mlp_speed[True-False] 0.6703ms 0.4579ms 2.1841 KOps/s 2.0641 KOps/s $\textbf{\color{#35bf28}+5.81\%}$
test_vmap_mlp_speed[False-True] 1.2173ms 0.7789ms 1.2838 KOps/s 1.2702 KOps/s $\color{#35bf28}+1.08\%$
test_vmap_mlp_speed[False-False] 0.7560ms 0.3760ms 2.6597 KOps/s 2.5475 KOps/s $\color{#35bf28}+4.40\%$
test_vmap_mlp_speed_decorator[True-True] 3.1440ms 2.3017ms 434.4679 Ops/s 424.7946 Ops/s $\color{#35bf28}+2.28\%$
test_vmap_mlp_speed_decorator[True-False] 0.9652ms 0.5289ms 1.8906 KOps/s 1.8240 KOps/s $\color{#35bf28}+3.65\%$
test_vmap_mlp_speed_decorator[False-True] 2.6027ms 1.8642ms 536.4352 Ops/s 527.3364 Ops/s $\color{#35bf28}+1.73\%$
test_vmap_mlp_speed_decorator[False-False] 0.8458ms 0.4085ms 2.4479 KOps/s 2.3742 KOps/s $\color{#35bf28}+3.10\%$

Copy link

github-actions bot commented Feb 6, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 132. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}15$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 87.2420μs 12.9930μs 76.9647 KOps/s 78.8398 KOps/s $\color{#d91a1a}-2.38\%$
test_plain_set_stack_nested 0.2116ms 0.1200ms 8.3339 KOps/s 8.3914 KOps/s $\color{#d91a1a}-0.68\%$
test_plain_set_nested_inplace 39.3710μs 14.2976μs 69.9416 KOps/s 71.1061 KOps/s $\color{#d91a1a}-1.64\%$
test_plain_set_stack_nested_inplace 0.1738ms 0.1483ms 6.7439 KOps/s 6.7830 KOps/s $\color{#d91a1a}-0.58\%$
test_items 24.2600μs 4.7831μs 209.0702 KOps/s 209.0699 KOps/s $+0.00\%$
test_items_nested 0.4250ms 0.3411ms 2.9314 KOps/s 2.9558 KOps/s $\color{#d91a1a}-0.83\%$
test_items_nested_locked 0.3855ms 0.3445ms 2.9026 KOps/s 2.9210 KOps/s $\color{#d91a1a}-0.63\%$
test_items_nested_leaf 0.2222ms 0.2000ms 5.0009 KOps/s 4.9575 KOps/s $\color{#35bf28}+0.87\%$
test_items_stack_nested 1.3820ms 1.3145ms 760.7743 Ops/s 758.0150 Ops/s $\color{#35bf28}+0.36\%$
test_items_stack_nested_leaf 1.2010ms 1.1438ms 874.2663 Ops/s 857.1290 Ops/s $\color{#35bf28}+2.00\%$
test_items_stack_nested_locked 0.9844ms 0.9009ms 1.1100 KOps/s 1.1048 KOps/s $\color{#35bf28}+0.47\%$
test_keys 24.4800μs 4.5948μs 217.6362 KOps/s 205.0209 KOps/s $\textbf{\color{#35bf28}+6.15\%}$
test_keys_nested 0.5229ms 94.6202μs 10.5686 KOps/s 10.5020 KOps/s $\color{#35bf28}+0.63\%$
test_keys_nested_locked 0.1169ms 97.5098μs 10.2554 KOps/s 10.0889 KOps/s $\color{#35bf28}+1.65\%$
test_keys_nested_leaf 0.1920ms 78.0999μs 12.8041 KOps/s 12.7177 KOps/s $\color{#35bf28}+0.68\%$
test_keys_stack_nested 1.2471ms 1.1555ms 865.4434 Ops/s 859.3192 Ops/s $\color{#35bf28}+0.71\%$
test_keys_stack_nested_leaf 1.2828ms 1.1358ms 880.4056 Ops/s 866.2746 Ops/s $\color{#35bf28}+1.63\%$
test_keys_stack_nested_locked 0.8305ms 0.7667ms 1.3042 KOps/s 1.3783 KOps/s $\textbf{\color{#d91a1a}-5.37\%}$
test_values 12.2033μs 1.8833μs 530.9741 KOps/s 527.3132 KOps/s $\color{#35bf28}+0.69\%$
test_values_nested 73.3320μs 45.5374μs 21.9600 KOps/s 22.2050 KOps/s $\color{#d91a1a}-1.10\%$
test_values_nested_locked 75.1110μs 47.7375μs 20.9479 KOps/s 21.1434 KOps/s $\color{#d91a1a}-0.92\%$
test_values_nested_leaf 61.4310μs 40.0609μs 24.9620 KOps/s 25.5023 KOps/s $\color{#d91a1a}-2.12\%$
test_values_stack_nested 1.0821ms 1.0271ms 973.5937 Ops/s 1.0333 KOps/s $\textbf{\color{#d91a1a}-5.78\%}$
test_values_stack_nested_leaf 1.0765ms 1.0199ms 980.5131 Ops/s 1.0433 KOps/s $\textbf{\color{#d91a1a}-6.02\%}$
test_values_stack_nested_locked 0.6605ms 0.6013ms 1.6629 KOps/s 1.7740 KOps/s $\textbf{\color{#d91a1a}-6.26\%}$
test_membership 4.8540μs 0.9305μs 1.0747 MOps/s 913.3159 KOps/s $\textbf{\color{#35bf28}+17.67\%}$
test_membership_nested 30.7710μs 2.8996μs 344.8730 KOps/s 345.1233 KOps/s $\color{#d91a1a}-0.07\%$
test_membership_nested_leaf 45.2910μs 2.8941μs 345.5361 KOps/s 344.4399 KOps/s $\color{#35bf28}+0.32\%$
test_membership_stacked_nested 27.4600μs 11.2598μs 88.8119 KOps/s 87.5544 KOps/s $\color{#35bf28}+1.44\%$
test_membership_stacked_nested_leaf 35.1300μs 11.3106μs 88.4123 KOps/s 87.7227 KOps/s $\color{#35bf28}+0.79\%$
test_membership_nested_last 24.8400μs 5.3137μs 188.1919 KOps/s 186.0848 KOps/s $\color{#35bf28}+1.13\%$
test_membership_nested_leaf_last 39.0200μs 5.2773μs 189.4922 KOps/s 185.2110 KOps/s $\color{#35bf28}+2.31\%$
test_membership_stacked_nested_last 0.1916ms 0.1564ms 6.3950 KOps/s 6.3305 KOps/s $\color{#35bf28}+1.02\%$
test_membership_stacked_nested_leaf_last 28.5200μs 13.2553μs 75.4415 KOps/s 74.9496 KOps/s $\color{#35bf28}+0.66\%$
test_nested_getleaf 34.2900μs 8.3877μs 119.2219 KOps/s 118.7487 KOps/s $\color{#35bf28}+0.40\%$
test_nested_get 30.9210μs 7.9362μs 126.0051 KOps/s 125.6003 KOps/s $\color{#35bf28}+0.32\%$
test_stacked_getleaf 0.3815ms 0.3289ms 3.0408 KOps/s 3.0266 KOps/s $\color{#35bf28}+0.47\%$
test_stacked_get 0.3397ms 0.2983ms 3.3527 KOps/s 3.3341 KOps/s $\color{#35bf28}+0.56\%$
test_nested_getitemleaf 26.4400μs 9.7647μs 102.4102 KOps/s 101.9422 KOps/s $\color{#35bf28}+0.46\%$
test_nested_getitem 32.7700μs 9.3187μs 107.3110 KOps/s 106.9000 KOps/s $\color{#35bf28}+0.38\%$
test_stacked_getitemleaf 0.3961ms 0.3333ms 3.0004 KOps/s 3.0004 KOps/s $-0.00\%$
test_stacked_getitem 0.3528ms 0.2989ms 3.3458 KOps/s 3.3152 KOps/s $\color{#35bf28}+0.92\%$
test_lock_nested 0.8358ms 0.3556ms 2.8118 KOps/s 2.8181 KOps/s $\color{#d91a1a}-0.22\%$
test_lock_stack_nested 86.7491ms 6.3722ms 156.9314 Ops/s 158.2491 Ops/s $\color{#d91a1a}-0.83\%$
test_unlock_nested 80.0981ms 0.4357ms 2.2950 KOps/s 2.8593 KOps/s $\textbf{\color{#d91a1a}-19.73\%}$
test_unlock_stack_nested 89.2264ms 6.5478ms 152.7225 Ops/s 153.6379 Ops/s $\color{#d91a1a}-0.60\%$
test_flatten_speed 0.2998ms 0.2606ms 3.8373 KOps/s 3.8450 KOps/s $\color{#d91a1a}-0.20\%$
test_unflatten_speed 0.4466ms 0.3567ms 2.8038 KOps/s 2.7629 KOps/s $\color{#35bf28}+1.48\%$
test_common_ops 1.2937ms 0.5898ms 1.6956 KOps/s 1.7518 KOps/s $\color{#d91a1a}-3.21\%$
test_creation 15.6200μs 1.5509μs 644.8046 KOps/s 629.4193 KOps/s $\color{#35bf28}+2.44\%$
test_creation_empty 97.5910μs 7.1251μs 140.3491 KOps/s 153.8894 KOps/s $\textbf{\color{#d91a1a}-8.80\%}$
test_creation_nested_1 30.6400μs 8.9170μs 112.1458 KOps/s 120.9828 KOps/s $\textbf{\color{#d91a1a}-7.30\%}$
test_creation_nested_2 92.7920μs 11.2270μs 89.0709 KOps/s 93.2285 KOps/s $\color{#d91a1a}-4.46\%$
test_clone 73.9010μs 14.3653μs 69.6122 KOps/s 72.8904 KOps/s $\color{#d91a1a}-4.50\%$
test_getitem[int] 27.1700μs 10.7545μs 92.9845 KOps/s 94.0099 KOps/s $\color{#d91a1a}-1.09\%$
test_getitem[slice_int] 42.4210μs 21.1436μs 47.2956 KOps/s 46.9846 KOps/s $\color{#35bf28}+0.66\%$
test_getitem[range] 0.2424ms 37.7056μs 26.5212 KOps/s 26.4842 KOps/s $\color{#35bf28}+0.14\%$
test_getitem[tuple] 38.5810μs 18.6638μs 53.5796 KOps/s 53.8140 KOps/s $\color{#d91a1a}-0.44\%$
test_getitem[list] 0.2291ms 33.8683μs 29.5262 KOps/s 28.7823 KOps/s $\color{#35bf28}+2.58\%$
test_setitem_dim[int] 45.9810μs 27.7590μs 36.0243 KOps/s 40.8506 KOps/s $\textbf{\color{#d91a1a}-11.81\%}$
test_setitem_dim[slice_int] 73.3020μs 47.7444μs 20.9448 KOps/s 21.9583 KOps/s $\color{#d91a1a}-4.62\%$
test_setitem_dim[range] 0.1062ms 64.8738μs 15.4145 KOps/s 16.3100 KOps/s $\textbf{\color{#d91a1a}-5.49\%}$
test_setitem_dim[tuple] 72.7620μs 42.0300μs 23.7925 KOps/s 25.2612 KOps/s $\textbf{\color{#d91a1a}-5.81\%}$
test_setitem 0.2082ms 18.1262μs 55.1688 KOps/s 57.1045 KOps/s $\color{#d91a1a}-3.39\%$
test_set 0.1044ms 17.6415μs 56.6845 KOps/s 59.0516 KOps/s $\color{#d91a1a}-4.01\%$
test_set_shared 86.9026ms 0.1212ms 8.2490 KOps/s 9.7228 KOps/s $\textbf{\color{#d91a1a}-15.16\%}$
test_update 0.1291ms 19.3353μs 51.7188 KOps/s 54.7225 KOps/s $\textbf{\color{#d91a1a}-5.49\%}$
test_update_nested 0.2250ms 25.7805μs 38.7889 KOps/s 39.8300 KOps/s $\color{#d91a1a}-2.61\%$
test_set_nested 0.1321ms 19.0132μs 52.5951 KOps/s 54.9535 KOps/s $\color{#d91a1a}-4.29\%$
test_set_nested_new 0.2161ms 21.6086μs 46.2780 KOps/s 47.7372 KOps/s $\color{#d91a1a}-3.06\%$
test_select 65.4810μs 33.8210μs 29.5674 KOps/s 29.8075 KOps/s $\color{#d91a1a}-0.81\%$
test_select_nested 0.2625ms 52.7846μs 18.9449 KOps/s 18.8722 KOps/s $\color{#35bf28}+0.39\%$
test_exclude_nested 0.3625ms 0.1115ms 8.9687 KOps/s 8.7631 KOps/s $\color{#35bf28}+2.35\%$
test_empty[True] 1.0915ms 0.3863ms 2.5885 KOps/s 2.5585 KOps/s $\color{#35bf28}+1.18\%$
test_empty[False] 19.7704μs 0.8462μs 1.1818 MOps/s 1.1765 MOps/s $\color{#35bf28}+0.45\%$
test_to 74.2110μs 55.0088μs 18.1789 KOps/s 17.9543 KOps/s $\color{#35bf28}+1.25\%$
test_to_nonblocking 0.3201ms 35.6060μs 28.0851 KOps/s 27.9622 KOps/s $\color{#35bf28}+0.44\%$
test_unbind_speed 0.3572ms 0.2678ms 3.7347 KOps/s 3.7006 KOps/s $\color{#35bf28}+0.92\%$
test_unbind_speed_stack0 85.9076ms 3.6022ms 277.6112 Ops/s 267.7537 Ops/s $\color{#35bf28}+3.68\%$
test_unbind_speed_stack1 21.0800μs 1.7986μs 555.9811 KOps/s 553.1215 KOps/s $\color{#35bf28}+0.52\%$
test_split 1.7417ms 1.5252ms 655.6496 Ops/s 648.6211 Ops/s $\color{#35bf28}+1.08\%$
test_chunk 83.5633ms 1.6566ms 603.6595 Ops/s 599.0365 Ops/s $\color{#35bf28}+0.77\%$
test_creation[device0] 0.1487ms 75.8291μs 13.1876 KOps/s 13.5244 KOps/s $\color{#d91a1a}-2.49\%$
test_creation_from_tensor 0.3261ms 54.5107μs 18.3450 KOps/s 18.1836 KOps/s $\color{#35bf28}+0.89\%$
test_add_one[memmap_tensor0] 0.1162ms 7.4097μs 134.9581 KOps/s 139.3945 KOps/s $\color{#d91a1a}-3.18\%$
test_contiguous[memmap_tensor0] 26.4400μs 0.6764μs 1.4785 MOps/s 1.5200 MOps/s $\color{#d91a1a}-2.73\%$
test_stack[memmap_tensor0] 18.4610μs 4.5686μs 218.8873 KOps/s 214.0894 KOps/s $\color{#35bf28}+2.24\%$
test_memmaptd_index 1.1824ms 0.2721ms 3.6746 KOps/s 3.8137 KOps/s $\color{#d91a1a}-3.65\%$
test_memmaptd_index_astensor 0.7265ms 0.3279ms 3.0495 KOps/s 3.1186 KOps/s $\color{#d91a1a}-2.22\%$
test_memmaptd_index_op 0.9198ms 0.6335ms 1.5785 KOps/s 1.6843 KOps/s $\textbf{\color{#d91a1a}-6.28\%}$
test_serialize_model 0.1759s 98.2077ms 10.1825 Ops/s 9.5909 Ops/s $\textbf{\color{#35bf28}+6.17\%}$
test_serialize_model_pickle 1.3511s 1.2374s 0.8081 Ops/s 0.8073 Ops/s $\color{#35bf28}+0.10\%$
test_serialize_weights 0.1747s 96.9188ms 10.3179 Ops/s 9.8891 Ops/s $\color{#35bf28}+4.34\%$
test_serialize_weights_returnearly 0.2613s 73.5211ms 13.6015 Ops/s 11.7983 Ops/s $\textbf{\color{#35bf28}+15.28\%}$
test_serialize_weights_pickle 1.3559s 1.2372s 0.8083 Ops/s 0.8036 Ops/s $\color{#35bf28}+0.58\%$
test_reshape_pytree 56.7410μs 25.6026μs 39.0585 KOps/s 39.1162 KOps/s $\color{#d91a1a}-0.15\%$
test_reshape_td 64.3610μs 32.9521μs 30.3471 KOps/s 30.0027 KOps/s $\color{#35bf28}+1.15\%$
test_view_pytree 50.6410μs 25.2880μs 39.5444 KOps/s 39.7468 KOps/s $\color{#d91a1a}-0.51\%$
test_view_td 85.2834ms 9.8637μs 101.3822 KOps/s 145.9439 KOps/s $\textbf{\color{#d91a1a}-30.53\%}$
test_unbind_pytree 60.8110μs 30.8602μs 32.4042 KOps/s 33.1479 KOps/s $\color{#d91a1a}-2.24\%$
test_unbind_td 0.1153ms 41.0764μs 24.3449 KOps/s 24.7820 KOps/s $\color{#d91a1a}-1.76\%$
test_split_pytree 51.2110μs 29.2640μs 34.1717 KOps/s 35.2258 KOps/s $\color{#d91a1a}-2.99\%$
test_split_td 0.4290ms 38.3035μs 26.1072 KOps/s 25.8427 KOps/s $\color{#35bf28}+1.02\%$
test_add_pytree 63.8210μs 37.6016μs 26.5946 KOps/s 24.8033 KOps/s $\textbf{\color{#35bf28}+7.22\%}$
test_add_td 82.9510μs 53.1831μs 18.8030 KOps/s 18.9709 KOps/s $\color{#d91a1a}-0.89\%$
test_distributed 3.3639ms 74.8008μs 13.3688 KOps/s 13.4088 KOps/s $\color{#d91a1a}-0.30\%$
test_tdmodule 33.6000μs 17.3927μs 57.4955 KOps/s 59.0323 KOps/s $\color{#d91a1a}-2.60\%$
test_tdmodule_dispatch 0.2058ms 36.2433μs 27.5913 KOps/s 29.0418 KOps/s $\color{#d91a1a}-4.99\%$
test_tdseq 43.3300μs 20.0917μs 49.7719 KOps/s 50.8656 KOps/s $\color{#d91a1a}-2.15\%$
test_tdseq_dispatch 56.6310μs 37.8838μs 26.3965 KOps/s 26.9923 KOps/s $\color{#d91a1a}-2.21\%$
test_instantiation_functorch 1.8622ms 1.7043ms 586.7548 Ops/s 603.7692 Ops/s $\color{#d91a1a}-2.82\%$
test_instantiation_td 0.1162s 1.3229ms 755.8943 Ops/s 770.2440 Ops/s $\color{#d91a1a}-1.86\%$
test_exec_functorch 0.2269ms 0.1667ms 6.0006 KOps/s 6.1575 KOps/s $\color{#d91a1a}-2.55\%$
test_exec_functional_call 0.2659ms 0.1626ms 6.1506 KOps/s 6.1393 KOps/s $\color{#35bf28}+0.18\%$
test_exec_td 0.2454ms 0.1559ms 6.4151 KOps/s 6.4891 KOps/s $\color{#d91a1a}-1.14\%$
test_exec_td_decorator 0.8789ms 0.2115ms 4.7271 KOps/s 4.7503 KOps/s $\color{#d91a1a}-0.49\%$
test_vmap_mlp_speed[True-True] 1.3957ms 1.0815ms 924.6315 Ops/s 945.7455 Ops/s $\color{#d91a1a}-2.23\%$
test_vmap_mlp_speed[True-False] 0.7659ms 0.6263ms 1.5968 KOps/s 1.6367 KOps/s $\color{#d91a1a}-2.44\%$
test_vmap_mlp_speed[False-True] 1.0985ms 1.0197ms 980.7209 Ops/s 1.0312 KOps/s $\color{#d91a1a}-4.89\%$
test_vmap_mlp_speed[False-False] 0.6270ms 0.5657ms 1.7679 KOps/s 1.8325 KOps/s $\color{#d91a1a}-3.53\%$
test_vmap_mlp_speed_decorator[True-True] 2.9420ms 2.3688ms 422.1521 Ops/s 427.3726 Ops/s $\color{#d91a1a}-1.22\%$
test_vmap_mlp_speed_decorator[True-False] 1.0749ms 0.6760ms 1.4792 KOps/s 1.4636 KOps/s $\color{#35bf28}+1.06\%$
test_vmap_mlp_speed_decorator[False-True] 2.3586ms 1.9715ms 507.2292 Ops/s 513.4238 Ops/s $\color{#d91a1a}-1.21\%$
test_vmap_mlp_speed_decorator[False-False] 0.9758ms 0.5857ms 1.7074 KOps/s 1.7261 KOps/s $\color{#d91a1a}-1.09\%$
test_vmap_transformer_speed[True-True] 13.1721ms 12.5842ms 79.4646 Ops/s 80.0199 Ops/s $\color{#d91a1a}-0.69\%$
test_vmap_transformer_speed[True-False] 8.6534ms 8.2956ms 120.5456 Ops/s 121.0888 Ops/s $\color{#d91a1a}-0.45\%$
test_vmap_transformer_speed[False-True] 12.5280ms 12.4428ms 80.3678 Ops/s 80.5238 Ops/s $\color{#d91a1a}-0.19\%$
test_vmap_transformer_speed[False-False] 8.5095ms 8.2164ms 121.7083 Ops/s 122.5261 Ops/s $\color{#d91a1a}-0.67\%$
test_vmap_transformer_speed_decorator[True-True] 74.7406ms 73.9162ms 13.5288 Ops/s 13.5652 Ops/s $\color{#d91a1a}-0.27\%$
test_vmap_transformer_speed_decorator[True-False] 21.6883ms 20.1395ms 49.6535 Ops/s 49.2687 Ops/s $\color{#35bf28}+0.78\%$
test_vmap_transformer_speed_decorator[False-True] 67.5390ms 66.5657ms 15.0227 Ops/s 13.3996 Ops/s $\textbf{\color{#35bf28}+12.11\%}$
test_vmap_transformer_speed_decorator[False-False] 0.1559s 22.5441ms 44.3575 Ops/s 50.2508 Ops/s $\textbf{\color{#d91a1a}-11.73\%}$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants