Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix empty(recurse) call in _apply_nest #658

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 5, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 124. Improved: $\large\color{#35bf28}8$. Worsened: $\large\color{#d91a1a}9$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 30.2270μs 16.6636μs 60.0112 KOps/s 60.4179 KOps/s $\color{#d91a1a}-0.67\%$
test_plain_set_stack_nested 0.2568ms 0.1518ms 6.5885 KOps/s 6.8377 KOps/s $\color{#d91a1a}-3.64\%$
test_plain_set_nested_inplace 47.7590μs 19.2982μs 51.8184 KOps/s 52.2280 KOps/s $\color{#d91a1a}-0.78\%$
test_plain_set_stack_nested_inplace 0.3154ms 0.1835ms 5.4490 KOps/s 5.6032 KOps/s $\color{#d91a1a}-2.75\%$
test_items 32.0700μs 2.4608μs 406.3703 KOps/s 404.0877 KOps/s $\color{#35bf28}+0.56\%$
test_items_nested 0.3415ms 0.2730ms 3.6635 KOps/s 3.7592 KOps/s $\color{#d91a1a}-2.55\%$
test_items_nested_locked 0.7730ms 0.2757ms 3.6266 KOps/s 3.6906 KOps/s $\color{#d91a1a}-1.74\%$
test_items_nested_leaf 0.5740ms 0.1744ms 5.7352 KOps/s 5.9892 KOps/s $\color{#d91a1a}-4.24\%$
test_items_stack_nested 1.5118ms 1.3269ms 753.6159 Ops/s 757.4914 Ops/s $\color{#d91a1a}-0.51\%$
test_items_stack_nested_leaf 2.2317ms 1.2038ms 830.7141 Ops/s 841.6927 Ops/s $\color{#d91a1a}-1.30\%$
test_items_stack_nested_locked 1.1326ms 0.8950ms 1.1174 KOps/s 1.1538 KOps/s $\color{#d91a1a}-3.16\%$
test_keys 93.3740μs 4.0151μs 249.0604 KOps/s 256.6651 KOps/s $\color{#d91a1a}-2.96\%$
test_keys_nested 1.8899ms 0.1525ms 6.5576 KOps/s 6.7591 KOps/s $\color{#d91a1a}-2.98\%$
test_keys_nested_locked 0.2716ms 0.1545ms 6.4744 KOps/s 6.3999 KOps/s $\color{#35bf28}+1.16\%$
test_keys_nested_leaf 0.2523ms 0.1325ms 7.5465 KOps/s 7.5860 KOps/s $\color{#d91a1a}-0.52\%$
test_keys_stack_nested 4.8582ms 1.3169ms 759.3763 Ops/s 779.7765 Ops/s $\color{#d91a1a}-2.62\%$
test_keys_stack_nested_leaf 1.5123ms 1.2755ms 784.0209 Ops/s 776.3359 Ops/s $\color{#35bf28}+0.99\%$
test_keys_stack_nested_locked 1.1055ms 0.8168ms 1.2243 KOps/s 1.2288 KOps/s $\color{#d91a1a}-0.37\%$
test_values 22.9880μs 1.1754μs 850.7533 KOps/s 825.8283 KOps/s $\color{#35bf28}+3.02\%$
test_values_nested 0.1857ms 52.7776μs 18.9474 KOps/s 19.0849 KOps/s $\color{#d91a1a}-0.72\%$
test_values_nested_locked 0.1407ms 52.0095μs 19.2273 KOps/s 18.9081 KOps/s $\color{#35bf28}+1.69\%$
test_values_nested_leaf 76.9530μs 46.3255μs 21.5864 KOps/s 20.9802 KOps/s $\color{#35bf28}+2.89\%$
test_values_stack_nested 1.2776ms 1.0346ms 966.5249 Ops/s 969.0223 Ops/s $\color{#d91a1a}-0.26\%$
test_values_stack_nested_leaf 1.1233ms 1.0199ms 980.4759 Ops/s 983.9585 Ops/s $\color{#d91a1a}-0.35\%$
test_values_stack_nested_locked 0.8432ms 0.6089ms 1.6423 KOps/s 1.6834 KOps/s $\color{#d91a1a}-2.44\%$
test_membership 21.5700μs 1.3519μs 739.7144 KOps/s 733.7431 KOps/s $\color{#35bf28}+0.81\%$
test_membership_nested 23.7340μs 3.4986μs 285.8290 KOps/s 280.9756 KOps/s $\color{#35bf28}+1.73\%$
test_membership_nested_leaf 34.4140μs 3.5251μs 283.6824 KOps/s 263.9161 KOps/s $\textbf{\color{#35bf28}+7.49\%}$
test_membership_stacked_nested 31.2280μs 11.9124μs 83.9461 KOps/s 82.6989 KOps/s $\color{#35bf28}+1.51\%$
test_membership_stacked_nested_leaf 44.1630μs 12.0915μs 82.7030 KOps/s 83.0311 KOps/s $\color{#d91a1a}-0.40\%$
test_membership_nested_last 41.2370μs 6.8354μs 146.2973 KOps/s 148.1851 KOps/s $\color{#d91a1a}-1.27\%$
test_membership_nested_leaf_last 31.1780μs 6.8643μs 145.6803 KOps/s 147.7181 KOps/s $\color{#d91a1a}-1.38\%$
test_membership_stacked_nested_last 0.6105ms 0.1833ms 5.4561 KOps/s 5.6568 KOps/s $\color{#d91a1a}-3.55\%$
test_membership_stacked_nested_leaf_last 55.2030μs 14.1732μs 70.5559 KOps/s 70.4917 KOps/s $\color{#35bf28}+0.09\%$
test_nested_getleaf 41.4980μs 10.7992μs 92.5995 KOps/s 91.7462 KOps/s $\color{#35bf28}+0.93\%$
test_nested_get 28.5640μs 10.2758μs 97.3163 KOps/s 97.5166 KOps/s $\color{#d91a1a}-0.21\%$
test_stacked_getleaf 0.6314ms 0.4037ms 2.4769 KOps/s 2.5102 KOps/s $\color{#d91a1a}-1.33\%$
test_stacked_get 0.6526ms 0.3669ms 2.7252 KOps/s 2.7199 KOps/s $\color{#35bf28}+0.20\%$
test_nested_getitemleaf 46.7770μs 12.2267μs 81.7880 KOps/s 82.3596 KOps/s $\color{#d91a1a}-0.69\%$
test_nested_getitem 41.0360μs 11.7447μs 85.1447 KOps/s 85.6956 KOps/s $\color{#d91a1a}-0.64\%$
test_stacked_getitemleaf 0.6937ms 0.4033ms 2.4796 KOps/s 2.4652 KOps/s $\color{#35bf28}+0.58\%$
test_stacked_getitem 0.7183ms 0.3817ms 2.6197 KOps/s 2.7159 KOps/s $\color{#d91a1a}-3.54\%$
test_lock_nested 0.9563ms 0.3355ms 2.9808 KOps/s 2.9401 KOps/s $\color{#35bf28}+1.38\%$
test_lock_stack_nested 78.8641ms 5.7748ms 173.1654 Ops/s 175.2665 Ops/s $\color{#d91a1a}-1.20\%$
test_unlock_nested 66.8664ms 0.4014ms 2.4913 KOps/s 2.9355 KOps/s $\textbf{\color{#d91a1a}-15.13\%}$
test_unlock_stack_nested 82.1506ms 5.7676ms 173.3819 Ops/s 170.1320 Ops/s $\color{#35bf28}+1.91\%$
test_flatten_speed 0.5480ms 0.3751ms 2.6658 KOps/s 2.6414 KOps/s $\color{#35bf28}+0.92\%$
test_unflatten_speed 0.8510ms 0.4820ms 2.0748 KOps/s 2.1437 KOps/s $\color{#d91a1a}-3.22\%$
test_common_ops 1.6212ms 0.6657ms 1.5021 KOps/s 1.5042 KOps/s $\color{#d91a1a}-0.14\%$
test_creation 53.7500μs 1.8653μs 536.0951 KOps/s 524.3110 KOps/s $\color{#35bf28}+2.25\%$
test_creation_empty 37.7800μs 8.8162μs 113.4275 KOps/s 103.3468 KOps/s $\textbf{\color{#35bf28}+9.75\%}$
test_creation_nested_1 46.0660μs 11.3448μs 88.1464 KOps/s 81.5025 KOps/s $\textbf{\color{#35bf28}+8.15\%}$
test_creation_nested_2 52.6990μs 14.4923μs 69.0019 KOps/s 65.0444 KOps/s $\textbf{\color{#35bf28}+6.08\%}$
test_clone 49.8930μs 13.0986μs 76.3442 KOps/s 76.3550 KOps/s $\color{#d91a1a}-0.01\%$
test_getitem[int] 28.5530μs 11.2328μs 89.0251 KOps/s 88.0204 KOps/s $\color{#35bf28}+1.14\%$
test_getitem[slice_int] 89.9980μs 22.8285μs 43.8049 KOps/s 45.4483 KOps/s $\color{#d91a1a}-3.62\%$
test_getitem[range] 0.1400ms 41.2212μs 24.2594 KOps/s 24.2900 KOps/s $\color{#d91a1a}-0.13\%$
test_getitem[tuple] 51.0250μs 18.2673μs 54.7426 KOps/s 55.3433 KOps/s $\color{#d91a1a}-1.09\%$
test_getitem[list] 75.1700μs 37.4220μs 26.7222 KOps/s 27.5460 KOps/s $\color{#d91a1a}-2.99\%$
test_setitem_dim[int] 48.8410μs 29.2044μs 34.2414 KOps/s 35.0872 KOps/s $\color{#d91a1a}-2.41\%$
test_setitem_dim[slice_int] 0.1031ms 54.3103μs 18.4127 KOps/s 18.4960 KOps/s $\color{#d91a1a}-0.45\%$
test_setitem_dim[range] 0.1553ms 74.7577μs 13.3765 KOps/s 13.4496 KOps/s $\color{#d91a1a}-0.54\%$
test_setitem_dim[tuple] 82.0230μs 44.1575μs 22.6462 KOps/s 23.0659 KOps/s $\color{#d91a1a}-1.82\%$
test_setitem 48.2700μs 18.7126μs 53.4400 KOps/s 53.5757 KOps/s $\color{#d91a1a}-0.25\%$
test_set 57.2160μs 18.2425μs 54.8169 KOps/s 54.4616 KOps/s $\color{#35bf28}+0.65\%$
test_set_shared 4.3866ms 0.1384ms 7.2250 KOps/s 7.3070 KOps/s $\color{#d91a1a}-1.12\%$
test_update 89.8480μs 20.3854μs 49.0546 KOps/s 47.9034 KOps/s $\color{#35bf28}+2.40\%$
test_update_nested 0.1185ms 28.0597μs 35.6383 KOps/s 34.7495 KOps/s $\color{#35bf28}+2.56\%$
test_set_nested 63.9700μs 20.4756μs 48.8386 KOps/s 49.8701 KOps/s $\color{#d91a1a}-2.07\%$
test_set_nested_new 87.1420μs 24.9445μs 40.0890 KOps/s 40.8815 KOps/s $\color{#d91a1a}-1.94\%$
test_select 0.2970ms 42.6378μs 23.4534 KOps/s 25.8952 KOps/s $\textbf{\color{#d91a1a}-9.43\%}$
test_select_nested 0.1962ms 58.7238μs 17.0289 KOps/s 16.8416 KOps/s $\color{#35bf28}+1.11\%$
test_exclude_nested 0.6166ms 0.1335ms 7.4931 KOps/s 8.4039 KOps/s $\textbf{\color{#d91a1a}-10.84\%}$
test_empty[True] 1.0526ms 0.4217ms 2.3716 KOps/s 2.4193 KOps/s $\color{#d91a1a}-1.97\%$
test_empty[False] 6.2958μs 1.0535μs 949.2332 KOps/s 956.5367 KOps/s $\color{#d91a1a}-0.76\%$
test_unbind_speed 0.3407ms 0.2501ms 3.9986 KOps/s 4.0125 KOps/s $\color{#d91a1a}-0.34\%$
test_unbind_speed_stack0 78.6413ms 3.3542ms 298.1359 Ops/s 334.9088 Ops/s $\textbf{\color{#d91a1a}-10.98\%}$
test_unbind_speed_stack1 17.4830μs 1.9392μs 515.6721 KOps/s 504.6421 KOps/s $\color{#35bf28}+2.19\%$
test_split 2.2236ms 1.4615ms 684.2337 Ops/s 623.0643 Ops/s $\textbf{\color{#35bf28}+9.82\%}$
test_chunk 74.3572ms 1.5633ms 639.6712 Ops/s 643.6270 Ops/s $\color{#d91a1a}-0.61\%$
test_creation[device0] 0.1650ms 0.1013ms 9.8724 KOps/s 9.9296 KOps/s $\color{#d91a1a}-0.58\%$
test_creation_from_tensor 4.3369ms 80.7243μs 12.3878 KOps/s 12.4036 KOps/s $\color{#d91a1a}-0.13\%$
test_add_one[memmap_tensor0] 0.1939ms 5.5206μs 181.1403 KOps/s 186.0190 KOps/s $\color{#d91a1a}-2.62\%$
test_contiguous[memmap_tensor0] 11.1510μs 0.6439μs 1.5531 MOps/s 1.5747 MOps/s $\color{#d91a1a}-1.37\%$
test_stack[memmap_tensor0] 41.9790μs 3.7257μs 268.4070 KOps/s 286.1859 KOps/s $\textbf{\color{#d91a1a}-6.21\%}$
test_memmaptd_index 0.9822ms 0.2402ms 4.1631 KOps/s 4.2662 KOps/s $\color{#d91a1a}-2.42\%$
test_memmaptd_index_astensor 0.6673ms 0.3049ms 3.2802 KOps/s 3.3894 KOps/s $\color{#d91a1a}-3.22\%$
test_memmaptd_index_op 0.8965ms 0.5790ms 1.7270 KOps/s 1.7530 KOps/s $\color{#d91a1a}-1.48\%$
test_serialize_model 0.1723s 0.1095s 9.1320 Ops/s 9.9583 Ops/s $\textbf{\color{#d91a1a}-8.30\%}$
test_serialize_model_pickle 0.4492s 0.3769s 2.6534 Ops/s 2.6235 Ops/s $\color{#35bf28}+1.14\%$
test_serialize_weights 0.1036s 99.3215ms 10.0683 Ops/s 9.2640 Ops/s $\textbf{\color{#35bf28}+8.68\%}$
test_serialize_weights_returnearly 0.1922s 0.1290s 7.7514 Ops/s 8.0783 Ops/s $\color{#d91a1a}-4.05\%$
test_serialize_weights_pickle 0.9456s 0.5786s 1.7283 Ops/s 2.4079 Ops/s $\textbf{\color{#d91a1a}-28.22\%}$
test_serialize_weights_filesystem 93.9304ms 90.4479ms 11.0561 Ops/s 9.7019 Ops/s $\textbf{\color{#35bf28}+13.96\%}$
test_serialize_model_filesystem 0.1643s 0.1000s 9.9966 Ops/s 10.9652 Ops/s $\textbf{\color{#d91a1a}-8.83\%}$
test_reshape_pytree 85.4300μs 21.2811μs 46.9900 KOps/s 48.0104 KOps/s $\color{#d91a1a}-2.13\%$
test_reshape_td 75.2510μs 30.7731μs 32.4960 KOps/s 33.2823 KOps/s $\color{#d91a1a}-2.36\%$
test_view_pytree 56.5160μs 21.0365μs 47.5364 KOps/s 48.0250 KOps/s $\color{#d91a1a}-1.02\%$
test_view_td 78.0929ms 11.1107μs 90.0031 KOps/s 92.8973 KOps/s $\color{#d91a1a}-3.12\%$
test_unbind_pytree 53.5300μs 24.5384μs 40.7525 KOps/s 41.6206 KOps/s $\color{#d91a1a}-2.09\%$
test_unbind_td 0.1877ms 37.9147μs 26.3750 KOps/s 27.8443 KOps/s $\textbf{\color{#d91a1a}-5.28\%}$
test_split_pytree 53.9010μs 23.7441μs 42.1157 KOps/s 42.8666 KOps/s $\color{#d91a1a}-1.75\%$
test_split_td 0.4175ms 39.3181μs 25.4336 KOps/s 25.5809 KOps/s $\color{#d91a1a}-0.58\%$
test_add_pytree 64.7700μs 30.2477μs 33.0604 KOps/s 33.6248 KOps/s $\color{#d91a1a}-1.68\%$
test_add_td 0.1198ms 49.7085μs 20.1173 KOps/s 20.6349 KOps/s $\color{#d91a1a}-2.51\%$
test_distributed 0.2522ms 98.9410μs 10.1070 KOps/s 9.8884 KOps/s $\color{#35bf28}+2.21\%$
test_tdmodule 0.1143ms 21.9372μs 45.5846 KOps/s 44.6060 KOps/s $\color{#35bf28}+2.19\%$
test_tdmodule_dispatch 0.2130ms 42.0043μs 23.8071 KOps/s 22.9469 KOps/s $\color{#35bf28}+3.75\%$
test_tdseq 56.6960μs 24.5641μs 40.7099 KOps/s 38.7471 KOps/s $\textbf{\color{#35bf28}+5.07\%}$
test_tdseq_dispatch 0.1357ms 45.3510μs 22.0502 KOps/s 21.1644 KOps/s $\color{#35bf28}+4.19\%$
test_instantiation_functorch 1.9515ms 1.3302ms 751.7703 Ops/s 739.8549 Ops/s $\color{#35bf28}+1.61\%$
test_instantiation_td 1.5143ms 0.9983ms 1.0017 KOps/s 986.7954 Ops/s $\color{#35bf28}+1.51\%$
test_exec_functorch 0.3013ms 0.1590ms 6.2881 KOps/s 6.1852 KOps/s $\color{#35bf28}+1.66\%$
test_exec_functional_call 0.3007ms 0.1454ms 6.8754 KOps/s 6.6291 KOps/s $\color{#35bf28}+3.72\%$
test_exec_td 0.2582ms 0.1436ms 6.9656 KOps/s 6.7615 KOps/s $\color{#35bf28}+3.02\%$
test_exec_td_decorator 0.9419ms 0.1965ms 5.0891 KOps/s 4.9112 KOps/s $\color{#35bf28}+3.62\%$
test_vmap_mlp_speed[True-True] 1.2953ms 0.8777ms 1.1393 KOps/s 1.1164 KOps/s $\color{#35bf28}+2.05\%$
test_vmap_mlp_speed[True-False] 0.7119ms 0.4634ms 2.1582 KOps/s 2.1278 KOps/s $\color{#35bf28}+1.43\%$
test_vmap_mlp_speed[False-True] 1.0863ms 0.7643ms 1.3085 KOps/s 1.2805 KOps/s $\color{#35bf28}+2.19\%$
test_vmap_mlp_speed[False-False] 0.6033ms 0.3841ms 2.6035 KOps/s 2.5945 KOps/s $\color{#35bf28}+0.35\%$
test_vmap_mlp_speed_decorator[True-True] 3.1925ms 2.2676ms 440.9895 Ops/s 433.5964 Ops/s $\color{#35bf28}+1.71\%$
test_vmap_mlp_speed_decorator[True-False] 0.9787ms 0.5286ms 1.8918 KOps/s 1.8268 KOps/s $\color{#35bf28}+3.56\%$
test_vmap_mlp_speed_decorator[False-True] 3.0297ms 1.8461ms 541.6680 Ops/s 533.3021 Ops/s $\color{#35bf28}+1.57\%$
test_vmap_mlp_speed_decorator[False-False] 1.0024ms 0.4150ms 2.4094 KOps/s 2.4119 KOps/s $\color{#d91a1a}-0.10\%$

Copy link

github-actions bot commented Feb 5, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 132. Improved: $\large\color{#35bf28}8$. Worsened: $\large\color{#d91a1a}8$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_plain_set_nested 0.1299ms 13.9895μs 71.4822 KOps/s 72.1669 KOps/s $\color{#d91a1a}-0.95\%$
test_plain_set_stack_nested 0.2461ms 0.1215ms 8.2285 KOps/s 8.0952 KOps/s $\color{#35bf28}+1.65\%$
test_plain_set_nested_inplace 0.1394ms 15.3357μs 65.2071 KOps/s 66.1665 KOps/s $\color{#d91a1a}-1.45\%$
test_plain_set_stack_nested_inplace 0.2850ms 0.1533ms 6.5247 KOps/s 6.6824 KOps/s $\color{#d91a1a}-2.36\%$
test_items 0.1182ms 4.7954μs 208.5340 KOps/s 212.9223 KOps/s $\color{#d91a1a}-2.06\%$
test_items_nested 0.5375ms 0.3479ms 2.8741 KOps/s 2.9367 KOps/s $\color{#d91a1a}-2.13\%$
test_items_nested_locked 0.3699ms 0.3452ms 2.8971 KOps/s 2.9153 KOps/s $\color{#d91a1a}-0.62\%$
test_items_nested_leaf 0.2276ms 0.2012ms 4.9713 KOps/s 5.0043 KOps/s $\color{#d91a1a}-0.66\%$
test_items_stack_nested 1.4735ms 1.3098ms 763.4494 Ops/s 763.1375 Ops/s $\color{#35bf28}+0.04\%$
test_items_stack_nested_leaf 1.1942ms 1.1488ms 870.4694 Ops/s 872.0767 Ops/s $\color{#d91a1a}-0.18\%$
test_items_stack_nested_locked 0.9642ms 0.9042ms 1.1060 KOps/s 1.1121 KOps/s $\color{#d91a1a}-0.55\%$
test_keys 28.8110μs 4.5436μs 220.0901 KOps/s 208.6260 KOps/s $\textbf{\color{#35bf28}+5.50\%}$
test_keys_nested 0.9591ms 94.4879μs 10.5834 KOps/s 10.4387 KOps/s $\color{#35bf28}+1.39\%$
test_keys_nested_locked 0.1323ms 98.0766μs 10.1961 KOps/s 9.9955 KOps/s $\color{#35bf28}+2.01\%$
test_keys_nested_leaf 0.2057ms 78.0255μs 12.8163 KOps/s 12.6054 KOps/s $\color{#35bf28}+1.67\%$
test_keys_stack_nested 1.2336ms 1.1516ms 868.3418 Ops/s 872.4315 Ops/s $\color{#d91a1a}-0.47\%$
test_keys_stack_nested_leaf 1.2162ms 1.1354ms 880.7123 Ops/s 891.7906 Ops/s $\color{#d91a1a}-1.24\%$
test_keys_stack_nested_locked 0.8398ms 0.7223ms 1.3845 KOps/s 1.4042 KOps/s $\color{#d91a1a}-1.40\%$
test_values 7.7700μs 1.8842μs 530.7337 KOps/s 529.8653 KOps/s $\color{#35bf28}+0.16\%$
test_values_nested 74.3010μs 45.2827μs 22.0835 KOps/s 22.1980 KOps/s $\color{#d91a1a}-0.52\%$
test_values_nested_locked 75.1910μs 47.3063μs 21.1388 KOps/s 21.0992 KOps/s $\color{#35bf28}+0.19\%$
test_values_nested_leaf 59.6510μs 39.4636μs 25.3398 KOps/s 25.4685 KOps/s $\color{#d91a1a}-0.51\%$
test_values_stack_nested 1.0564ms 0.9574ms 1.0445 KOps/s 1.0639 KOps/s $\color{#d91a1a}-1.82\%$
test_values_stack_nested_leaf 1.0278ms 0.9580ms 1.0439 KOps/s 1.0552 KOps/s $\color{#d91a1a}-1.08\%$
test_values_stack_nested_locked 0.6367ms 0.5805ms 1.7227 KOps/s 1.7754 KOps/s $\color{#d91a1a}-2.97\%$
test_membership 58.9990μs 0.9341μs 1.0705 MOps/s 945.8632 KOps/s $\textbf{\color{#35bf28}+13.18\%}$
test_membership_nested 24.1600μs 2.8404μs 352.0641 KOps/s 349.7913 KOps/s $\color{#35bf28}+0.65\%$
test_membership_nested_leaf 24.6410μs 2.8700μs 348.4381 KOps/s 359.6908 KOps/s $\color{#d91a1a}-3.13\%$
test_membership_stacked_nested 38.1300μs 11.3735μs 87.9236 KOps/s 87.7977 KOps/s $\color{#35bf28}+0.14\%$
test_membership_stacked_nested_leaf 26.4900μs 11.3902μs 87.7949 KOps/s 87.5572 KOps/s $\color{#35bf28}+0.27\%$
test_membership_nested_last 1.2514ms 5.3713μs 186.1748 KOps/s 189.3661 KOps/s $\color{#d91a1a}-1.69\%$
test_membership_nested_leaf_last 27.1800μs 5.2905μs 189.0166 KOps/s 190.0242 KOps/s $\color{#d91a1a}-0.53\%$
test_membership_stacked_nested_last 0.1889ms 0.1567ms 6.3818 KOps/s 6.3734 KOps/s $\color{#35bf28}+0.13\%$
test_membership_stacked_nested_leaf_last 34.1610μs 13.0588μs 76.5768 KOps/s 76.3996 KOps/s $\color{#35bf28}+0.23\%$
test_nested_getleaf 27.8810μs 8.4553μs 118.2687 KOps/s 119.6134 KOps/s $\color{#d91a1a}-1.12\%$
test_nested_get 22.3800μs 7.9783μs 125.3399 KOps/s 126.5471 KOps/s $\color{#d91a1a}-0.95\%$
test_stacked_getleaf 0.3929ms 0.3296ms 3.0338 KOps/s 3.0074 KOps/s $\color{#35bf28}+0.88\%$
test_stacked_get 0.3403ms 0.2997ms 3.3362 KOps/s 3.3521 KOps/s $\color{#d91a1a}-0.47\%$
test_nested_getitemleaf 32.0500μs 9.8273μs 101.7578 KOps/s 102.6005 KOps/s $\color{#d91a1a}-0.82\%$
test_nested_getitem 49.7910μs 9.3361μs 107.1106 KOps/s 106.5794 KOps/s $\color{#35bf28}+0.50\%$
test_stacked_getitemleaf 0.3769ms 0.3318ms 3.0141 KOps/s 2.9920 KOps/s $\color{#35bf28}+0.74\%$
test_stacked_getitem 0.3495ms 0.3026ms 3.3052 KOps/s 3.2963 KOps/s $\color{#35bf28}+0.27\%$
test_lock_nested 1.2703ms 0.3547ms 2.8196 KOps/s 2.8210 KOps/s $\color{#d91a1a}-0.05\%$
test_lock_stack_nested 85.3587ms 6.3985ms 156.2866 Ops/s 159.3669 Ops/s $\color{#d91a1a}-1.93\%$
test_unlock_nested 78.9719ms 0.4341ms 2.3037 KOps/s 2.8791 KOps/s $\textbf{\color{#d91a1a}-19.99\%}$
test_unlock_stack_nested 85.6435ms 6.4787ms 154.3512 Ops/s 155.1620 Ops/s $\color{#d91a1a}-0.52\%$
test_flatten_speed 0.3458ms 0.2615ms 3.8238 KOps/s 3.8406 KOps/s $\color{#d91a1a}-0.44\%$
test_unflatten_speed 0.3966ms 0.3620ms 2.7621 KOps/s 2.7889 KOps/s $\color{#d91a1a}-0.96\%$
test_common_ops 1.0731ms 0.6147ms 1.6269 KOps/s 1.6612 KOps/s $\color{#d91a1a}-2.07\%$
test_creation 34.2910μs 1.5717μs 636.2392 KOps/s 634.6754 KOps/s $\color{#35bf28}+0.25\%$
test_creation_empty 26.3900μs 8.5730μs 116.6450 KOps/s 117.1924 KOps/s $\color{#d91a1a}-0.47\%$
test_creation_nested_1 34.6610μs 10.2643μs 97.4255 KOps/s 97.8172 KOps/s $\color{#d91a1a}-0.40\%$
test_creation_nested_2 35.4210μs 12.6706μs 78.9226 KOps/s 79.1787 KOps/s $\color{#d91a1a}-0.32\%$
test_clone 58.3610μs 13.9051μs 71.9162 KOps/s 74.3366 KOps/s $\color{#d91a1a}-3.26\%$
test_getitem[int] 25.5100μs 11.0738μs 90.3030 KOps/s 91.3013 KOps/s $\color{#d91a1a}-1.09\%$
test_getitem[slice_int] 38.2910μs 21.3675μs 46.8001 KOps/s 46.9825 KOps/s $\color{#d91a1a}-0.39\%$
test_getitem[range] 0.1620ms 36.6684μs 27.2715 KOps/s 28.4525 KOps/s $\color{#d91a1a}-4.15\%$
test_getitem[tuple] 41.2510μs 19.3182μs 51.7647 KOps/s 53.2635 KOps/s $\color{#d91a1a}-2.81\%$
test_getitem[list] 0.1896ms 33.4030μs 29.9374 KOps/s 31.0906 KOps/s $\color{#d91a1a}-3.71\%$
test_setitem_dim[int] 48.8210μs 28.0590μs 35.6392 KOps/s 36.8167 KOps/s $\color{#d91a1a}-3.20\%$
test_setitem_dim[slice_int] 74.8810μs 48.3117μs 20.6989 KOps/s 20.9701 KOps/s $\color{#d91a1a}-1.29\%$
test_setitem_dim[range] 82.4110μs 60.6039μs 16.5006 KOps/s 16.4306 KOps/s $\color{#35bf28}+0.43\%$
test_setitem_dim[tuple] 62.3610μs 42.0305μs 23.7922 KOps/s 23.8072 KOps/s $\color{#d91a1a}-0.06\%$
test_setitem 77.1610μs 19.2750μs 51.8807 KOps/s 54.9863 KOps/s $\textbf{\color{#d91a1a}-5.65\%}$
test_set 89.8610μs 18.7450μs 53.3476 KOps/s 54.7154 KOps/s $\color{#d91a1a}-2.50\%$
test_set_shared 2.6358ms 0.1053ms 9.4944 KOps/s 9.9069 KOps/s $\color{#d91a1a}-4.16\%$
test_update 0.1067ms 21.2618μs 47.0327 KOps/s 48.8095 KOps/s $\color{#d91a1a}-3.64\%$
test_update_nested 86.7510μs 27.9460μs 35.7833 KOps/s 37.7558 KOps/s $\textbf{\color{#d91a1a}-5.22\%}$
test_set_nested 79.4010μs 20.0841μs 49.7906 KOps/s 52.6076 KOps/s $\textbf{\color{#d91a1a}-5.35\%}$
test_set_nested_new 70.7110μs 22.6160μs 44.2164 KOps/s 46.7325 KOps/s $\textbf{\color{#d91a1a}-5.38\%}$
test_select 86.8610μs 36.2386μs 27.5949 KOps/s 28.6786 KOps/s $\color{#d91a1a}-3.78\%$
test_select_nested 76.2410μs 53.6289μs 18.6467 KOps/s 18.9772 KOps/s $\color{#d91a1a}-1.74\%$
test_exclude_nested 0.1511ms 0.1144ms 8.7429 KOps/s 8.8868 KOps/s $\color{#d91a1a}-1.62\%$
test_empty[True] 1.3404ms 0.3895ms 2.5675 KOps/s 2.5943 KOps/s $\color{#d91a1a}-1.04\%$
test_empty[False] 2.8390μs 0.8724μs 1.1463 MOps/s 1.1924 MOps/s $\color{#d91a1a}-3.86\%$
test_to 75.7310μs 55.2888μs 18.0868 KOps/s 18.4513 KOps/s $\color{#d91a1a}-1.98\%$
test_to_nonblocking 64.0310μs 34.9912μs 28.5786 KOps/s 28.2120 KOps/s $\color{#35bf28}+1.30\%$
test_unbind_speed 0.3121ms 0.2763ms 3.6188 KOps/s 3.7342 KOps/s $\color{#d91a1a}-3.09\%$
test_unbind_speed_stack0 87.2800ms 3.7729ms 265.0486 Ops/s 267.9770 Ops/s $\color{#d91a1a}-1.09\%$
test_unbind_speed_stack1 20.7610μs 1.8359μs 544.6971 KOps/s 553.4968 KOps/s $\color{#d91a1a}-1.59\%$
test_split 81.1402ms 1.7804ms 561.6605 Ops/s 639.6609 Ops/s $\textbf{\color{#d91a1a}-12.19\%}$
test_chunk 1.6606ms 1.5948ms 627.0305 Ops/s 588.6183 Ops/s $\textbf{\color{#35bf28}+6.53\%}$
test_creation[device0] 0.1378ms 71.6143μs 13.9637 KOps/s 13.6728 KOps/s $\color{#35bf28}+2.13\%$
test_creation_from_tensor 0.1394ms 55.2992μs 18.0834 KOps/s 16.9441 KOps/s $\textbf{\color{#35bf28}+6.72\%}$
test_add_one[memmap_tensor0] 0.2329ms 6.7750μs 147.6018 KOps/s 152.1747 KOps/s $\color{#d91a1a}-3.01\%$
test_contiguous[memmap_tensor0] 25.6510μs 0.6388μs 1.5655 MOps/s 1.5567 MOps/s $\color{#35bf28}+0.56\%$
test_stack[memmap_tensor0] 29.6410μs 4.6209μs 216.4065 KOps/s 227.0081 KOps/s $\color{#d91a1a}-4.67\%$
test_memmaptd_index 0.9791ms 0.2708ms 3.6924 KOps/s 3.7477 KOps/s $\color{#d91a1a}-1.47\%$
test_memmaptd_index_astensor 0.6789ms 0.3256ms 3.0711 KOps/s 3.0788 KOps/s $\color{#d91a1a}-0.25\%$
test_memmaptd_index_op 0.9357ms 0.6218ms 1.6081 KOps/s 1.6243 KOps/s $\color{#d91a1a}-1.00\%$
test_serialize_model 91.9851ms 88.7891ms 11.2626 Ops/s 9.6957 Ops/s $\textbf{\color{#35bf28}+16.16\%}$
test_serialize_model_pickle 1.3519s 1.2364s 0.8088 Ops/s 0.8066 Ops/s $\color{#35bf28}+0.28\%$
test_serialize_weights 0.1731s 96.0919ms 10.4067 Ops/s 10.0538 Ops/s $\color{#35bf28}+3.51\%$
test_serialize_weights_returnearly 0.2181s 72.8821ms 13.7208 Ops/s 12.0330 Ops/s $\textbf{\color{#35bf28}+14.03\%}$
test_serialize_weights_pickle 1.3532s 1.2364s 0.8088 Ops/s 0.8078 Ops/s $\color{#35bf28}+0.13\%$
test_reshape_pytree 53.9210μs 25.3226μs 39.4904 KOps/s 39.5779 KOps/s $\color{#d91a1a}-0.22\%$
test_reshape_td 0.5252ms 30.1905μs 33.1231 KOps/s 33.4925 KOps/s $\color{#d91a1a}-1.10\%$
test_view_pytree 0.2192ms 25.0121μs 39.9807 KOps/s 40.5271 KOps/s $\color{#d91a1a}-1.35\%$
test_view_td 0.4679ms 6.8553μs 145.8718 KOps/s 147.3111 KOps/s $\color{#d91a1a}-0.98\%$
test_unbind_pytree 0.2497ms 30.7991μs 32.4685 KOps/s 33.2089 KOps/s $\color{#d91a1a}-2.23\%$
test_unbind_td 0.1981ms 41.9993μs 23.8099 KOps/s 24.3689 KOps/s $\color{#d91a1a}-2.29\%$
test_split_pytree 0.2434ms 29.0267μs 34.4510 KOps/s 33.7114 KOps/s $\color{#35bf28}+2.19\%$
test_split_td 0.5350ms 39.1806μs 25.5228 KOps/s 25.3016 KOps/s $\color{#35bf28}+0.87\%$
test_add_pytree 0.2558ms 36.0924μs 27.7067 KOps/s 27.3105 KOps/s $\color{#35bf28}+1.45\%$
test_add_td 80.8520μs 51.2083μs 19.5281 KOps/s 20.3614 KOps/s $\color{#d91a1a}-4.09\%$
test_distributed 1.9802ms 75.3485μs 13.2717 KOps/s 13.6010 KOps/s $\color{#d91a1a}-2.42\%$
test_tdmodule 66.4210μs 17.9164μs 55.8149 KOps/s 56.0227 KOps/s $\color{#d91a1a}-0.37\%$
test_tdmodule_dispatch 0.1418ms 36.6102μs 27.3148 KOps/s 26.9579 KOps/s $\color{#35bf28}+1.32\%$
test_tdseq 36.1800μs 20.8267μs 48.0153 KOps/s 48.1288 KOps/s $\color{#d91a1a}-0.24\%$
test_tdseq_dispatch 59.9610μs 39.1691μs 25.5303 KOps/s 25.6031 KOps/s $\color{#d91a1a}-0.28\%$
test_instantiation_functorch 1.8616ms 1.6871ms 592.7411 Ops/s 605.3877 Ops/s $\color{#d91a1a}-2.09\%$
test_instantiation_td 0.1110s 1.3005ms 768.9319 Ops/s 866.2159 Ops/s $\textbf{\color{#d91a1a}-11.23\%}$
test_exec_functorch 0.2333ms 0.1602ms 6.2436 KOps/s 6.3808 KOps/s $\color{#d91a1a}-2.15\%$
test_exec_functional_call 0.2339ms 0.1571ms 6.3656 KOps/s 6.5248 KOps/s $\color{#d91a1a}-2.44\%$
test_exec_td 0.1734ms 0.1443ms 6.9324 KOps/s 7.0002 KOps/s $\color{#d91a1a}-0.97\%$
test_exec_td_decorator 0.8449ms 0.2038ms 4.9067 KOps/s 4.9972 KOps/s $\color{#d91a1a}-1.81\%$
test_vmap_mlp_speed[True-True] 1.3725ms 1.0271ms 973.6150 Ops/s 970.2094 Ops/s $\color{#35bf28}+0.35\%$
test_vmap_mlp_speed[True-False] 0.6417ms 0.5900ms 1.6950 KOps/s 1.6765 KOps/s $\color{#35bf28}+1.10\%$
test_vmap_mlp_speed[False-True] 0.9919ms 0.9335ms 1.0712 KOps/s 1.0700 KOps/s $\color{#35bf28}+0.11\%$
test_vmap_mlp_speed[False-False] 0.6188ms 0.5393ms 1.8541 KOps/s 1.8500 KOps/s $\color{#35bf28}+0.23\%$
test_vmap_mlp_speed_decorator[True-True] 2.9297ms 2.3299ms 429.2112 Ops/s 421.0206 Ops/s $\color{#35bf28}+1.95\%$
test_vmap_mlp_speed_decorator[True-False] 1.0678ms 0.6559ms 1.5247 KOps/s 1.4995 KOps/s $\color{#35bf28}+1.68\%$
test_vmap_mlp_speed_decorator[False-True] 2.3545ms 1.9485ms 513.2259 Ops/s 457.7962 Ops/s $\textbf{\color{#35bf28}+12.11\%}$
test_vmap_mlp_speed_decorator[False-False] 0.9812ms 0.5568ms 1.7958 KOps/s 1.8202 KOps/s $\color{#d91a1a}-1.34\%$
test_vmap_transformer_speed[True-True] 12.7708ms 12.1430ms 82.3520 Ops/s 83.6158 Ops/s $\color{#d91a1a}-1.51\%$
test_vmap_transformer_speed[True-False] 8.3053ms 7.8988ms 126.6011 Ops/s 120.6385 Ops/s $\color{#35bf28}+4.94\%$
test_vmap_transformer_speed[False-True] 12.1147ms 11.9428ms 83.7327 Ops/s 82.9327 Ops/s $\color{#35bf28}+0.96\%$
test_vmap_transformer_speed[False-False] 8.1888ms 7.8280ms 127.7459 Ops/s 125.4529 Ops/s $\color{#35bf28}+1.83\%$
test_vmap_transformer_speed_decorator[True-True] 73.3157ms 72.7048ms 13.7543 Ops/s 13.6585 Ops/s $\color{#35bf28}+0.70\%$
test_vmap_transformer_speed_decorator[True-False] 21.6663ms 19.3832ms 51.5911 Ops/s 52.5328 Ops/s $\color{#d91a1a}-1.79\%$
test_vmap_transformer_speed_decorator[False-True] 0.1975s 73.7809ms 13.5536 Ops/s 15.3393 Ops/s $\textbf{\color{#d91a1a}-11.64\%}$
test_vmap_transformer_speed_decorator[False-False] 20.6300ms 18.9145ms 52.8695 Ops/s 46.8746 Ops/s $\textbf{\color{#35bf28}+12.79\%}$

@vmoens vmoens added the bug Something isn't working label Feb 5, 2024
@vmoens vmoens merged commit b98d075 into main Feb 5, 2024
47 of 48 checks passed
@vmoens vmoens deleted the bugfix-apply branch February 5, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants