Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple system metrics support #3377

Conversation

jakki-amd
Copy link
Contributor

@jakki-amd jakki-amd commented Dec 20, 2024

Description

Backend system metrics lacks support for torch.mps accelerator devices. This PR will add those changes and modify frontend code to handle Apple M1 GPU as single accelerator device to fix issues with frontend tests and make Accelerator class definition to be more consistent across hardware vendors.

Fixes #3376

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

  • Frontend test
> ./frontend/gradlew -p frontend clean build

...

BUILD SUCCESSFUL

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

jakki-amd and others added 3 commits December 20, 2024 13:13
Co-authored-by: Bipradip Chowdhury <bichowdh@amd.com>
Co-authored-by: Rony Leppänen <rleppane@amd.com>
Co-authored-by: Anders Smedegaard Pedersen <asmedega@amd.com>
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal added this pull request to the merge queue Dec 20, 2024
Merged via the queue into pytorch:master with commit 1a3b18b Dec 20, 2024
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix missing system metrics for Apple M1
2 participants