Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed empty py files #81

Merged
merged 2 commits into from
Apr 21, 2022
Merged

removed empty py files #81

merged 2 commits into from
Apr 21, 2022

Conversation

Ephibbs
Copy link
Contributor

@Ephibbs Ephibbs commented Apr 20, 2022

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 20, 2022
@Ephibbs
Copy link
Contributor Author

Ephibbs commented Apr 20, 2022

solves #67

@vmoens vmoens self-requested a review April 20, 2022 06:06
vmoens
vmoens requested changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the __init__.py is edited and the checks pass we're good to go.

torchrl/record/rendering.py Show resolved Hide resolved
@vmoens vmoens added the quality code quality label Apr 20, 2022
@vmoens vmoens linked an issue Apr 20, 2022 that may be closed by this pull request
Remove empty files #67
Closed
@Ephibbs Ephibbs requested a review from vmoens April 21, 2022 01:37
@vmoens
Copy link
Contributor

vmoens commented Apr 21, 2022

LGTM thanks!

@vmoens vmoens merged commit 308ed49 into pytorch:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove empty files
3 participants
@Ephibbs @vmoens @facebook-github-bot