-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Sorting nested keys #787
Conversation
Codecov Report
@@ Coverage Diff @@
## main #787 +/- ##
=======================================
Coverage 88.78% 88.78%
=======================================
Files 123 123
Lines 21253 21253
=======================================
Hits 18869 18869
Misses 2384 2384
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's just make sure that we don't have keys that collide
@matteobettini since the problem was occuring with Brax I updated the brax wrapper and tests to make sure that things were passing. |
@vmoens This is because yes they perform batched simulation but parallelenv can furtherly distribute this to the various cpu cores. This is also why rllib has the 2 parameters: num_workers and num_envs_per_worker |
Description
This PR solves issue #775