-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Batched environments with non empty batch size #774
Conversation
Codecov Report
@@ Coverage Diff @@
## main #774 +/- ##
=======================================
Coverage 88.73% 88.73%
=======================================
Files 123 123
Lines 20986 20987 +1
=======================================
+ Hits 18622 18623 +1
Misses 2364 2364
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
@matteobettini can I ask you to add a simple test in test_envs.py to test non regression of this feature? |
I have added the test. This test should be sufficient for this simple modification. |
The lint is failing, let's fix this and merge! |
Should be fixed |
This PR fixes BUG #773