Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quality] Capture errors in specs transforms #2092

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[Quality] Capture errors in specs transforms #2092

merged 1 commit into from
Apr 18, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 18, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2092

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 12 Unrelated Failures

As of commit 126102e with merge base 6b87184 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2024
@vmoens vmoens added the quality code quality label Apr 18, 2024
@vmoens vmoens merged commit 9d3530f into main Apr 18, 2024
39 of 53 checks passed
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 55.1521ms 53.3907ms 18.7298 Ops/s 17.8946 Ops/s $\color{#35bf28}+4.67\%$
test_sync 28.8737ms 28.4354ms 35.1674 Ops/s 34.3567 Ops/s $\color{#35bf28}+2.36\%$
test_async 55.9912ms 26.6060ms 37.5855 Ops/s 36.2974 Ops/s $\color{#35bf28}+3.55\%$
test_simple 0.4030s 0.3490s 2.8657 Ops/s 3.0130 Ops/s $\color{#d91a1a}-4.89\%$
test_transformed 0.4812s 0.4780s 2.0919 Ops/s 2.0370 Ops/s $\color{#35bf28}+2.69\%$
test_serial 1.2659s 1.2045s 0.8302 Ops/s 0.8462 Ops/s $\color{#d91a1a}-1.89\%$
test_parallel 1.0518s 1.0085s 0.9915 Ops/s 0.9963 Ops/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[True-True-True-True-True] 0.1550ms 21.2082μs 47.1517 KOps/s 47.4447 KOps/s $\color{#d91a1a}-0.62\%$
test_step_mdp_speed[True-True-True-True-False] 57.7890μs 12.8124μs 78.0491 KOps/s 76.3519 KOps/s $\color{#35bf28}+2.22\%$
test_step_mdp_speed[True-True-True-False-True] 56.5060μs 12.4242μs 80.4879 KOps/s 80.0100 KOps/s $\color{#35bf28}+0.60\%$
test_step_mdp_speed[True-True-True-False-False] 31.8190μs 7.5354μs 132.7073 KOps/s 131.1413 KOps/s $\color{#35bf28}+1.19\%$
test_step_mdp_speed[True-True-False-True-True] 79.1620μs 22.7761μs 43.9058 KOps/s 44.5267 KOps/s $\color{#d91a1a}-1.39\%$
test_step_mdp_speed[True-True-False-True-False] 44.6830μs 14.2602μs 70.1252 KOps/s 69.6158 KOps/s $\color{#35bf28}+0.73\%$
test_step_mdp_speed[True-True-False-False-True] 35.5570μs 13.6469μs 73.2768 KOps/s 73.3170 KOps/s $\color{#d91a1a}-0.05\%$
test_step_mdp_speed[True-True-False-False-False] 33.8330μs 8.7261μs 114.5986 KOps/s 112.7586 KOps/s $\color{#35bf28}+1.63\%$
test_step_mdp_speed[True-False-True-True-True] 71.4140μs 23.7860μs 42.0416 KOps/s 41.6049 KOps/s $\color{#35bf28}+1.05\%$
test_step_mdp_speed[True-False-True-True-False] 42.6600μs 15.4273μs 64.8200 KOps/s 64.1978 KOps/s $\color{#35bf28}+0.97\%$
test_step_mdp_speed[True-False-True-False-True] 40.4760μs 13.5803μs 73.6358 KOps/s 73.5941 KOps/s $\color{#35bf28}+0.06\%$
test_step_mdp_speed[True-False-True-False-False] 29.0640μs 8.7683μs 114.0466 KOps/s 114.3179 KOps/s $\color{#d91a1a}-0.24\%$
test_step_mdp_speed[True-False-False-True-True] 70.1810μs 25.3989μs 39.3718 KOps/s 40.1678 KOps/s $\color{#d91a1a}-1.98\%$
test_step_mdp_speed[True-False-False-True-False] 48.3910μs 16.8179μs 59.4603 KOps/s 59.4633 KOps/s $-0.01\%$
test_step_mdp_speed[True-False-False-False-True] 40.9270μs 14.7816μs 67.6515 KOps/s 67.5444 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[True-False-False-False-False] 63.3450μs 9.9320μs 100.6851 KOps/s 100.9797 KOps/s $\color{#d91a1a}-0.29\%$
test_step_mdp_speed[False-True-True-True-True] 61.1240μs 23.8048μs 42.0083 KOps/s 42.3041 KOps/s $\color{#d91a1a}-0.70\%$
test_step_mdp_speed[False-True-True-True-False] 49.1920μs 15.5364μs 64.3648 KOps/s 64.4813 KOps/s $\color{#d91a1a}-0.18\%$
test_step_mdp_speed[False-True-True-False-True] 51.6760μs 15.8453μs 63.1102 KOps/s 63.9687 KOps/s $\color{#d91a1a}-1.34\%$
test_step_mdp_speed[False-True-True-False-False] 35.7960μs 9.9711μs 100.2898 KOps/s 100.8504 KOps/s $\color{#d91a1a}-0.56\%$
test_step_mdp_speed[False-True-False-True-True] 70.2420μs 25.6037μs 39.0568 KOps/s 39.0754 KOps/s $\color{#d91a1a}-0.05\%$
test_step_mdp_speed[False-True-False-True-False] 62.2070μs 16.7852μs 59.5762 KOps/s 60.2428 KOps/s $\color{#d91a1a}-1.11\%$
test_step_mdp_speed[False-True-False-False-True] 50.8250μs 16.8207μs 59.4507 KOps/s 59.6577 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[False-True-False-False-False] 36.1280μs 11.2063μs 89.2352 KOps/s 90.5224 KOps/s $\color{#d91a1a}-1.42\%$
test_step_mdp_speed[False-False-True-True-True] 61.3250μs 26.4194μs 37.8510 KOps/s 38.0664 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[False-False-True-True-False] 44.6030μs 18.0689μs 55.3438 KOps/s 55.5696 KOps/s $\color{#d91a1a}-0.41\%$
test_step_mdp_speed[False-False-True-False-True] 62.5370μs 16.9948μs 58.8416 KOps/s 59.4676 KOps/s $\color{#d91a1a}-1.05\%$
test_step_mdp_speed[False-False-True-False-False] 38.6520μs 11.0838μs 90.2220 KOps/s 90.6804 KOps/s $\color{#d91a1a}-0.51\%$
test_step_mdp_speed[False-False-False-True-True] 64.9120μs 27.4161μs 36.4749 KOps/s 36.7712 KOps/s $\color{#d91a1a}-0.81\%$
test_step_mdp_speed[False-False-False-True-False] 56.5860μs 19.0611μs 52.4629 KOps/s 52.4655 KOps/s $-0.00\%$
test_step_mdp_speed[False-False-False-False-True] 42.5700μs 17.9719μs 55.6425 KOps/s 56.4250 KOps/s $\color{#d91a1a}-1.39\%$
test_step_mdp_speed[False-False-False-False-False] 53.6010μs 12.2655μs 81.5295 KOps/s 83.2643 KOps/s $\color{#d91a1a}-2.08\%$
test_values[generalized_advantage_estimate-True-True] 11.9782ms 9.3024ms 107.4990 Ops/s 106.7523 Ops/s $\color{#35bf28}+0.70\%$
test_values[vec_generalized_advantage_estimate-True-True] 36.6903ms 35.3986ms 28.2497 Ops/s 28.0974 Ops/s $\color{#35bf28}+0.54\%$
test_values[td0_return_estimate-False-False] 0.2137ms 0.1684ms 5.9385 KOps/s 5.7056 KOps/s $\color{#35bf28}+4.08\%$
test_values[td1_return_estimate-False-False] 25.5040ms 23.0258ms 43.4295 Ops/s 42.4902 Ops/s $\color{#35bf28}+2.21\%$
test_values[vec_td1_return_estimate-False-False] 36.2394ms 35.3322ms 28.3028 Ops/s 28.2326 Ops/s $\color{#35bf28}+0.25\%$
test_values[td_lambda_return_estimate-True-False] 34.0992ms 32.9287ms 30.3687 Ops/s 29.5855 Ops/s $\color{#35bf28}+2.65\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.3526ms 35.3358ms 28.2999 Ops/s 28.3376 Ops/s $\color{#d91a1a}-0.13\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.1849ms 8.0742ms 123.8506 Ops/s 124.3416 Ops/s $\color{#d91a1a}-0.39\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.5725ms 1.8759ms 533.0635 Ops/s 552.4196 Ops/s $\color{#d91a1a}-3.50\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5389ms 0.3516ms 2.8439 KOps/s 2.8683 KOps/s $\color{#d91a1a}-0.85\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 48.2584ms 46.2269ms 21.6324 Ops/s 22.5246 Ops/s $\color{#d91a1a}-3.96\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7420ms 3.0282ms 330.2307 Ops/s 330.3022 Ops/s $\color{#d91a1a}-0.02\%$
test_dqn_speed 1.6966ms 1.3214ms 756.7865 Ops/s 748.1858 Ops/s $\color{#35bf28}+1.15\%$
test_ddpg_speed 4.1345ms 2.6494ms 377.4484 Ops/s 377.6786 Ops/s $\color{#d91a1a}-0.06\%$
test_sac_speed 9.4569ms 8.1252ms 123.0741 Ops/s 112.6341 Ops/s $\textbf{\color{#35bf28}+9.27\%}$
test_redq_speed 14.3517ms 13.1306ms 76.1583 Ops/s 74.3875 Ops/s $\color{#35bf28}+2.38\%$
test_redq_deprec_speed 14.7871ms 13.1813ms 75.8649 Ops/s 76.1807 Ops/s $\color{#d91a1a}-0.41\%$
test_td3_speed 16.4555ms 8.2650ms 120.9921 Ops/s 124.0851 Ops/s $\color{#d91a1a}-2.49\%$
test_cql_speed 38.1930ms 36.8673ms 27.1243 Ops/s 27.5569 Ops/s $\color{#d91a1a}-1.57\%$
test_a2c_speed 7.9179ms 7.3926ms 135.2705 Ops/s 135.8641 Ops/s $\color{#d91a1a}-0.44\%$
test_ppo_speed 8.9325ms 7.6370ms 130.9418 Ops/s 131.2443 Ops/s $\color{#d91a1a}-0.23\%$
test_reinforce_speed 7.2645ms 6.5062ms 153.6987 Ops/s 152.7177 Ops/s $\color{#35bf28}+0.64\%$
test_iql_speed 33.2096ms 32.7031ms 30.5781 Ops/s 30.8477 Ops/s $\color{#d91a1a}-0.87\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.5662ms 2.3061ms 433.6309 Ops/s 437.1719 Ops/s $\color{#d91a1a}-0.81\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 91.8229ms 0.5597ms 1.7868 KOps/s 2.0343 KOps/s $\textbf{\color{#d91a1a}-12.17\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7965ms 0.4724ms 2.1169 KOps/s 2.1443 KOps/s $\color{#d91a1a}-1.28\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9985ms 2.3118ms 432.5644 Ops/s 430.9209 Ops/s $\color{#35bf28}+0.38\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7885ms 0.4871ms 2.0529 KOps/s 2.0582 KOps/s $\color{#d91a1a}-0.26\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6575ms 0.4600ms 2.1739 KOps/s 2.1899 KOps/s $\color{#d91a1a}-0.73\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.7621ms 1.2236ms 817.2735 Ops/s 824.6701 Ops/s $\color{#d91a1a}-0.90\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 4.2098ms 1.1631ms 859.7920 Ops/s 873.5773 Ops/s $\color{#d91a1a}-1.58\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.5221ms 2.3716ms 421.6500 Ops/s 416.7560 Ops/s $\color{#35bf28}+1.17\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1841ms 0.6087ms 1.6430 KOps/s 1.6441 KOps/s $\color{#d91a1a}-0.07\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8983ms 0.5768ms 1.7336 KOps/s 1.7154 KOps/s $\color{#35bf28}+1.06\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.4710ms 2.2737ms 439.8166 Ops/s 446.3025 Ops/s $\color{#d91a1a}-1.45\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.1996ms 0.4989ms 2.0046 KOps/s 2.0185 KOps/s $\color{#d91a1a}-0.69\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5678ms 0.4633ms 2.1582 KOps/s 2.1118 KOps/s $\color{#35bf28}+2.20\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.5434ms 2.3173ms 431.5391 Ops/s 433.4167 Ops/s $\color{#d91a1a}-0.43\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7456ms 0.4886ms 2.0467 KOps/s 2.0319 KOps/s $\color{#35bf28}+0.73\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.6167ms 0.4690ms 2.1324 KOps/s 2.1644 KOps/s $\color{#d91a1a}-1.48\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.6134ms 2.4083ms 415.2280 Ops/s 423.4626 Ops/s $\color{#d91a1a}-1.94\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7035ms 0.6036ms 1.6568 KOps/s 1.6461 KOps/s $\color{#35bf28}+0.65\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8983ms 0.5804ms 1.7229 KOps/s 1.6878 KOps/s $\color{#35bf28}+2.08\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1190s 7.9194ms 126.2727 Ops/s 124.7009 Ops/s $\color{#35bf28}+1.26\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 14.5333ms 11.9880ms 83.4168 Ops/s 84.9544 Ops/s $\color{#d91a1a}-1.81\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.8090ms 1.0932ms 914.7437 Ops/s 968.4127 Ops/s $\textbf{\color{#d91a1a}-5.54\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1108s 6.1818ms 161.7647 Ops/s 177.8403 Ops/s $\textbf{\color{#d91a1a}-9.04\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 14.4137ms 11.9487ms 83.6911 Ops/s 84.8441 Ops/s $\color{#d91a1a}-1.36\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.6613ms 1.0601ms 943.3098 Ops/s 959.1656 Ops/s $\color{#d91a1a}-1.65\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1096s 8.1153ms 123.2246 Ops/s 127.1828 Ops/s $\color{#d91a1a}-3.11\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.1183ms 12.8010ms 78.1187 Ops/s 83.1785 Ops/s $\textbf{\color{#d91a1a}-6.08\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.7351ms 1.4807ms 675.3425 Ops/s 746.4883 Ops/s $\textbf{\color{#d91a1a}-9.53\%}$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}1$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 99.6704ms 98.7258ms 10.1291 Ops/s 9.6699 Ops/s $\color{#35bf28}+4.75\%$
test_sync 87.1925ms 86.1850ms 11.6029 Ops/s 11.6122 Ops/s $\color{#d91a1a}-0.08\%$
test_async 0.1615s 70.3613ms 14.2124 Ops/s 14.3638 Ops/s $\color{#d91a1a}-1.05\%$
test_single_pixels 0.1112s 0.1103s 9.0647 Ops/s 9.2504 Ops/s $\color{#d91a1a}-2.01\%$
test_sync_pixels 68.1710ms 65.8158ms 15.1939 Ops/s 15.0546 Ops/s $\color{#35bf28}+0.93\%$
test_async_pixels 0.1215s 54.7270ms 18.2725 Ops/s 18.1273 Ops/s $\color{#35bf28}+0.80\%$
test_simple 0.7399s 0.6798s 1.4710 Ops/s 1.5201 Ops/s $\color{#d91a1a}-3.23\%$
test_transformed 0.9424s 0.8912s 1.1221 Ops/s 1.1503 Ops/s $\color{#d91a1a}-2.45\%$
test_serial 2.1136s 2.0567s 0.4862 Ops/s 0.4970 Ops/s $\color{#d91a1a}-2.16\%$
test_parallel 1.7994s 1.7286s 0.5785 Ops/s 0.5685 Ops/s $\color{#35bf28}+1.76\%$
test_step_mdp_speed[True-True-True-True-True] 79.3810μs 33.1181μs 30.1949 KOps/s 31.1290 KOps/s $\color{#d91a1a}-3.00\%$
test_step_mdp_speed[True-True-True-True-False] 95.8710μs 19.9878μs 50.0306 KOps/s 52.2582 KOps/s $\color{#d91a1a}-4.26\%$
test_step_mdp_speed[True-True-True-False-True] 0.1308ms 18.9524μs 52.7638 KOps/s 54.9513 KOps/s $\color{#d91a1a}-3.98\%$
test_step_mdp_speed[True-True-True-False-False] 29.4210μs 11.1522μs 89.6680 KOps/s 92.2054 KOps/s $\color{#d91a1a}-2.75\%$
test_step_mdp_speed[True-True-False-True-True] 60.9000μs 35.4359μs 28.2200 KOps/s 29.3796 KOps/s $\color{#d91a1a}-3.95\%$
test_step_mdp_speed[True-True-False-True-False] 38.3410μs 22.0079μs 45.4383 KOps/s 47.8037 KOps/s $\color{#d91a1a}-4.95\%$
test_step_mdp_speed[True-True-False-False-True] 0.1432ms 20.6064μs 48.5285 KOps/s 49.6068 KOps/s $\color{#d91a1a}-2.17\%$
test_step_mdp_speed[True-True-False-False-False] 78.0710μs 13.1798μs 75.8737 KOps/s 78.5844 KOps/s $\color{#d91a1a}-3.45\%$
test_step_mdp_speed[True-False-True-True-True] 68.8610μs 37.6703μs 26.5461 KOps/s 27.3917 KOps/s $\color{#d91a1a}-3.09\%$
test_step_mdp_speed[True-False-True-True-False] 47.5400μs 23.5973μs 42.3778 KOps/s 43.2036 KOps/s $\color{#d91a1a}-1.91\%$
test_step_mdp_speed[True-False-True-False-True] 44.0500μs 20.5767μs 48.5987 KOps/s 49.2390 KOps/s $\color{#d91a1a}-1.30\%$
test_step_mdp_speed[True-False-True-False-False] 31.8300μs 13.3265μs 75.0387 KOps/s 76.8554 KOps/s $\color{#d91a1a}-2.36\%$
test_step_mdp_speed[True-False-False-True-True] 63.9710μs 39.0219μs 25.6266 KOps/s 26.0835 KOps/s $\color{#d91a1a}-1.75\%$
test_step_mdp_speed[True-False-False-True-False] 49.0510μs 25.2175μs 39.6549 KOps/s 39.7327 KOps/s $\color{#d91a1a}-0.20\%$
test_step_mdp_speed[True-False-False-False-True] 77.1910μs 22.4541μs 44.5354 KOps/s 44.7554 KOps/s $\color{#d91a1a}-0.49\%$
test_step_mdp_speed[True-False-False-False-False] 34.8400μs 15.1941μs 65.8151 KOps/s 67.9301 KOps/s $\color{#d91a1a}-3.11\%$
test_step_mdp_speed[False-True-True-True-True] 71.1220μs 37.7323μs 26.5025 KOps/s 27.1816 KOps/s $\color{#d91a1a}-2.50\%$
test_step_mdp_speed[False-True-True-True-False] 46.3100μs 23.4980μs 42.5569 KOps/s 42.5360 KOps/s $\color{#35bf28}+0.05\%$
test_step_mdp_speed[False-True-True-False-True] 91.9420μs 24.4832μs 40.8443 KOps/s 41.1568 KOps/s $\color{#d91a1a}-0.76\%$
test_step_mdp_speed[False-True-True-False-False] 45.4600μs 15.2290μs 65.6643 KOps/s 66.6342 KOps/s $\color{#d91a1a}-1.46\%$
test_step_mdp_speed[False-True-False-True-True] 73.6310μs 38.7997μs 25.7734 KOps/s 26.1159 KOps/s $\color{#d91a1a}-1.31\%$
test_step_mdp_speed[False-True-False-True-False] 47.8510μs 25.6343μs 39.0102 KOps/s 39.5215 KOps/s $\color{#d91a1a}-1.29\%$
test_step_mdp_speed[False-True-False-False-True] 41.6010μs 26.8162μs 37.2909 KOps/s 38.1893 KOps/s $\color{#d91a1a}-2.35\%$
test_step_mdp_speed[False-True-False-False-False] 35.8210μs 16.9813μs 58.8884 KOps/s 59.7490 KOps/s $\color{#d91a1a}-1.44\%$
test_step_mdp_speed[False-False-True-True-True] 0.1169ms 40.5751μs 24.6457 KOps/s 25.0318 KOps/s $\color{#d91a1a}-1.54\%$
test_step_mdp_speed[False-False-True-True-False] 69.5610μs 27.6610μs 36.1520 KOps/s 36.4062 KOps/s $\color{#d91a1a}-0.70\%$
test_step_mdp_speed[False-False-True-False-True] 44.8510μs 26.6868μs 37.4717 KOps/s 38.4852 KOps/s $\color{#d91a1a}-2.63\%$
test_step_mdp_speed[False-False-True-False-False] 38.6810μs 16.9835μs 58.8807 KOps/s 59.4862 KOps/s $\color{#d91a1a}-1.02\%$
test_step_mdp_speed[False-False-False-True-True] 99.8110μs 42.7831μs 23.3737 KOps/s 23.9945 KOps/s $\color{#d91a1a}-2.59\%$
test_step_mdp_speed[False-False-False-True-False] 0.1023ms 29.2812μs 34.1516 KOps/s 34.3947 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[False-False-False-False-True] 59.7210μs 28.3992μs 35.2123 KOps/s 35.7371 KOps/s $\color{#d91a1a}-1.47\%$
test_step_mdp_speed[False-False-False-False-False] 0.2126ms 18.4343μs 54.2467 KOps/s 54.0224 KOps/s $\color{#35bf28}+0.42\%$
test_values[generalized_advantage_estimate-True-True] 24.3495ms 23.6111ms 42.3530 Ops/s 44.3828 Ops/s $\color{#d91a1a}-4.57\%$
test_values[vec_generalized_advantage_estimate-True-True] 81.6256ms 3.1808ms 314.3840 Ops/s 316.2253 Ops/s $\color{#d91a1a}-0.58\%$
test_values[td0_return_estimate-False-False] 88.7720μs 60.9726μs 16.4008 KOps/s 16.5092 KOps/s $\color{#d91a1a}-0.66\%$
test_values[td1_return_estimate-False-False] 50.6883ms 50.3141ms 19.8751 Ops/s 20.5224 Ops/s $\color{#d91a1a}-3.15\%$
test_values[vec_td1_return_estimate-False-False] 2.0482ms 1.7326ms 577.1625 Ops/s 584.8842 Ops/s $\color{#d91a1a}-1.32\%$
test_values[td_lambda_return_estimate-True-False] 81.2938ms 79.7892ms 12.5330 Ops/s 12.5820 Ops/s $\color{#d91a1a}-0.39\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.0411ms 1.7320ms 577.3710 Ops/s 581.6872 Ops/s $\color{#d91a1a}-0.74\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 22.7656ms 22.3213ms 44.8002 Ops/s 45.1260 Ops/s $\color{#d91a1a}-0.72\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9145ms 0.6693ms 1.4940 KOps/s 1.4924 KOps/s $\color{#35bf28}+0.11\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6972ms 0.6214ms 1.6092 KOps/s 1.6018 KOps/s $\color{#35bf28}+0.46\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4901ms 1.4281ms 700.2239 Ops/s 708.6329 Ops/s $\color{#d91a1a}-1.19\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9052ms 0.6413ms 1.5592 KOps/s 1.5921 KOps/s $\color{#d91a1a}-2.06\%$
test_dqn_speed 8.0073ms 1.4446ms 692.2165 Ops/s 716.1971 Ops/s $\color{#d91a1a}-3.35\%$
test_ddpg_speed 3.0484ms 2.7221ms 367.3664 Ops/s 373.5454 Ops/s $\color{#d91a1a}-1.65\%$
test_sac_speed 8.7719ms 7.9935ms 125.1011 Ops/s 127.1917 Ops/s $\color{#d91a1a}-1.64\%$
test_redq_speed 11.7225ms 10.1804ms 98.2282 Ops/s 98.9402 Ops/s $\color{#d91a1a}-0.72\%$
test_redq_deprec_speed 11.5662ms 10.9369ms 91.4335 Ops/s 91.9646 Ops/s $\color{#d91a1a}-0.58\%$
test_td3_speed 8.0422ms 7.8843ms 126.8340 Ops/s 128.1179 Ops/s $\color{#d91a1a}-1.00\%$
test_cql_speed 25.6427ms 24.7041ms 40.4791 Ops/s 40.3523 Ops/s $\color{#35bf28}+0.31\%$
test_a2c_speed 6.0967ms 5.4882ms 182.2078 Ops/s 182.4276 Ops/s $\color{#d91a1a}-0.12\%$
test_ppo_speed 6.0091ms 5.7626ms 173.5340 Ops/s 172.8875 Ops/s $\color{#35bf28}+0.37\%$
test_reinforce_speed 5.4656ms 4.4696ms 223.7350 Ops/s 220.6355 Ops/s $\color{#35bf28}+1.40\%$
test_iql_speed 19.9963ms 19.2117ms 52.0517 Ops/s 51.9419 Ops/s $\color{#35bf28}+0.21\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0826ms 2.8857ms 346.5348 Ops/s 350.7724 Ops/s $\color{#d91a1a}-1.21\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.3618ms 0.5458ms 1.8323 KOps/s 1.8600 KOps/s $\color{#d91a1a}-1.49\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7243ms 0.5212ms 1.9185 KOps/s 1.9453 KOps/s $\color{#d91a1a}-1.38\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0721ms 2.9121ms 343.3998 Ops/s 351.9774 Ops/s $\color{#d91a1a}-2.44\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6723ms 0.5381ms 1.8584 KOps/s 1.8820 KOps/s $\color{#d91a1a}-1.26\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7738ms 0.5154ms 1.9401 KOps/s 1.9729 KOps/s $\color{#d91a1a}-1.66\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.5865ms 1.4062ms 711.1540 Ops/s 722.5056 Ops/s $\color{#d91a1a}-1.57\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5123ms 1.3420ms 745.1367 Ops/s 747.8001 Ops/s $\color{#d91a1a}-0.36\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1410ms 3.0176ms 331.3884 Ops/s 336.6833 Ops/s $\color{#d91a1a}-1.57\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1442ms 0.6702ms 1.4921 KOps/s 1.5264 KOps/s $\color{#d91a1a}-2.25\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8116ms 0.6454ms 1.5494 KOps/s 1.5705 KOps/s $\color{#d91a1a}-1.34\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9866ms 2.8910ms 345.8955 Ops/s 351.3012 Ops/s $\color{#d91a1a}-1.54\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7964ms 0.5391ms 1.8551 KOps/s 1.8580 KOps/s $\color{#d91a1a}-0.16\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.4413ms 0.5279ms 1.8945 KOps/s 1.9296 KOps/s $\color{#d91a1a}-1.82\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.0528ms 2.9029ms 344.4781 Ops/s 349.2378 Ops/s $\color{#d91a1a}-1.36\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7985ms 0.5350ms 1.8691 KOps/s 1.8843 KOps/s $\color{#d91a1a}-0.81\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6596ms 0.5140ms 1.9456 KOps/s 1.9709 KOps/s $\color{#d91a1a}-1.28\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.1233ms 3.0108ms 332.1369 Ops/s 337.3332 Ops/s $\color{#d91a1a}-1.54\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9007ms 0.6705ms 1.4914 KOps/s 1.5249 KOps/s $\color{#d91a1a}-2.19\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.6684ms 0.6529ms 1.5317 KOps/s 1.5668 KOps/s $\color{#d91a1a}-2.24\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1215s 9.3410ms 107.0544 Ops/s 106.2013 Ops/s $\color{#35bf28}+0.80\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.0228ms 14.6732ms 68.1516 Ops/s 70.1349 Ops/s $\color{#d91a1a}-2.83\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.4929ms 1.1206ms 892.3832 Ops/s 931.0914 Ops/s $\color{#d91a1a}-4.16\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1165s 7.0058ms 142.7397 Ops/s 143.9927 Ops/s $\color{#d91a1a}-0.87\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.0205ms 14.6521ms 68.2496 Ops/s 70.1216 Ops/s $\color{#d91a1a}-2.67\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.2979ms 1.1122ms 899.0799 Ops/s 920.9108 Ops/s $\color{#d91a1a}-2.37\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1171s 7.3584ms 135.8987 Ops/s 103.9993 Ops/s $\textbf{\color{#35bf28}+30.67\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1267s 17.2434ms 57.9931 Ops/s 68.6945 Ops/s $\textbf{\color{#d91a1a}-15.58\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.6715ms 1.4408ms 694.0671 Ops/s 716.5282 Ops/s $\color{#d91a1a}-3.13\%$

@vmoens vmoens deleted the fix-attributeerror branch April 25, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot