Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Remove remnant legacy functional calls #1973

Merged
merged 1 commit into from
Feb 27, 2024
Merged

[Refactor] Remove remnant legacy functional calls #1973

merged 1 commit into from
Feb 27, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 27, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1973

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit fffb134 with merge base cadf4d9 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2024
@vmoens vmoens added Refactoring Refactoring of an existing feature Suitable for minor Suitable to be integrated in minor release (no new feature) and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Feb 27, 2024
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}8$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 62.2603ms 61.3448ms 16.3013 Ops/s 16.4868 Ops/s $\color{#d91a1a}-1.12\%$
test_sync 40.2413ms 33.9417ms 29.4623 Ops/s 29.4517 Ops/s $\color{#35bf28}+0.04\%$
test_async 57.5852ms 31.4755ms 31.7707 Ops/s 33.1677 Ops/s $\color{#d91a1a}-4.21\%$
test_simple 0.5012s 0.4348s 2.3001 Ops/s 2.2977 Ops/s $\color{#35bf28}+0.10\%$
test_transformed 0.6204s 0.5726s 1.7464 Ops/s 1.7057 Ops/s $\color{#35bf28}+2.38\%$
test_serial 1.4472s 1.4064s 0.7110 Ops/s 0.7046 Ops/s $\color{#35bf28}+0.91\%$
test_parallel 1.4620s 1.4083s 0.7101 Ops/s 0.7330 Ops/s $\color{#d91a1a}-3.13\%$
test_step_mdp_speed[True-True-True-True-True] 0.1644ms 21.2715μs 47.0114 KOps/s 46.3148 KOps/s $\color{#35bf28}+1.50\%$
test_step_mdp_speed[True-True-True-True-False] 0.2675ms 13.8390μs 72.2594 KOps/s 75.0665 KOps/s $\color{#d91a1a}-3.74\%$
test_step_mdp_speed[True-True-True-False-True] 41.9080μs 12.3297μs 81.1050 KOps/s 78.4602 KOps/s $\color{#35bf28}+3.37\%$
test_step_mdp_speed[True-True-True-False-False] 26.0090μs 7.5345μs 132.7220 KOps/s 129.4917 KOps/s $\color{#35bf28}+2.49\%$
test_step_mdp_speed[True-True-False-True-True] 52.0270μs 22.3376μs 44.7676 KOps/s 43.6398 KOps/s $\color{#35bf28}+2.58\%$
test_step_mdp_speed[True-True-False-True-False] 54.1720μs 14.0907μs 70.9689 KOps/s 68.8570 KOps/s $\color{#35bf28}+3.07\%$
test_step_mdp_speed[True-True-False-False-True] 43.0210μs 13.4903μs 74.1271 KOps/s 72.3219 KOps/s $\color{#35bf28}+2.50\%$
test_step_mdp_speed[True-True-False-False-False] 29.3660μs 8.7011μs 114.9276 KOps/s 111.7510 KOps/s $\color{#35bf28}+2.84\%$
test_step_mdp_speed[True-False-True-True-True] 74.1190μs 23.7872μs 42.0394 KOps/s 41.0437 KOps/s $\color{#35bf28}+2.43\%$
test_step_mdp_speed[True-False-True-True-False] 49.1720μs 15.4151μs 64.8717 KOps/s 62.5329 KOps/s $\color{#35bf28}+3.74\%$
test_step_mdp_speed[True-False-True-False-True] 46.2460μs 13.6612μs 73.1999 KOps/s 71.9320 KOps/s $\color{#35bf28}+1.76\%$
test_step_mdp_speed[True-False-True-False-False] 0.1621ms 8.8251μs 113.3131 KOps/s 110.0659 KOps/s $\color{#35bf28}+2.95\%$
test_step_mdp_speed[True-False-False-True-True] 61.5070μs 24.6162μs 40.6236 KOps/s 39.0394 KOps/s $\color{#35bf28}+4.06\%$
test_step_mdp_speed[True-False-False-True-False] 43.3310μs 16.6316μs 60.1266 KOps/s 58.6517 KOps/s $\color{#35bf28}+2.51\%$
test_step_mdp_speed[True-False-False-False-True] 55.2620μs 14.6140μs 68.4276 KOps/s 66.9000 KOps/s $\color{#35bf28}+2.28\%$
test_step_mdp_speed[True-False-False-False-False] 47.5590μs 10.0773μs 99.2333 KOps/s 97.7876 KOps/s $\color{#35bf28}+1.48\%$
test_step_mdp_speed[False-True-True-True-True] 84.1980μs 23.4127μs 42.7118 KOps/s 40.9345 KOps/s $\color{#35bf28}+4.34\%$
test_step_mdp_speed[False-True-True-True-False] 53.6710μs 15.4040μs 64.9180 KOps/s 62.9307 KOps/s $\color{#35bf28}+3.16\%$
test_step_mdp_speed[False-True-True-False-True] 48.2800μs 15.7082μs 63.6611 KOps/s 62.1959 KOps/s $\color{#35bf28}+2.36\%$
test_step_mdp_speed[False-True-True-False-False] 45.4450μs 9.8942μs 101.0691 KOps/s 98.6585 KOps/s $\color{#35bf28}+2.44\%$
test_step_mdp_speed[False-True-False-True-True] 50.5050μs 24.8323μs 40.2701 KOps/s 39.1146 KOps/s $\color{#35bf28}+2.95\%$
test_step_mdp_speed[False-True-False-True-False] 48.7120μs 16.5047μs 60.5889 KOps/s 58.6703 KOps/s $\color{#35bf28}+3.27\%$
test_step_mdp_speed[False-True-False-False-True] 42.8900μs 16.8180μs 59.4600 KOps/s 58.3230 KOps/s $\color{#35bf28}+1.95\%$
test_step_mdp_speed[False-True-False-False-False] 41.1580μs 11.0987μs 90.1006 KOps/s 88.2226 KOps/s $\color{#35bf28}+2.13\%$
test_step_mdp_speed[False-False-True-True-True] 0.3387ms 27.9337μs 35.7991 KOps/s 34.8710 KOps/s $\color{#35bf28}+2.66\%$
test_step_mdp_speed[False-False-True-True-False] 48.2700μs 17.8584μs 55.9961 KOps/s 53.9465 KOps/s $\color{#35bf28}+3.80\%$
test_step_mdp_speed[False-False-True-False-True] 49.0820μs 16.5469μs 60.4343 KOps/s 57.9952 KOps/s $\color{#35bf28}+4.21\%$
test_step_mdp_speed[False-False-True-False-False] 36.4880μs 11.1095μs 90.0131 KOps/s 87.3481 KOps/s $\color{#35bf28}+3.05\%$
test_step_mdp_speed[False-False-False-True-True] 0.1057ms 26.6122μs 37.5768 KOps/s 35.9643 KOps/s $\color{#35bf28}+4.48\%$
test_step_mdp_speed[False-False-False-True-False] 47.5690μs 18.8489μs 53.0534 KOps/s 51.3679 KOps/s $\color{#35bf28}+3.28\%$
test_step_mdp_speed[False-False-False-False-True] 53.0090μs 17.6897μs 56.5302 KOps/s 54.3630 KOps/s $\color{#35bf28}+3.99\%$
test_step_mdp_speed[False-False-False-False-False] 33.7130μs 12.0959μs 82.6724 KOps/s 79.4331 KOps/s $\color{#35bf28}+4.08\%$
test_values[generalized_advantage_estimate-True-True] 9.3100ms 9.0797ms 110.1360 Ops/s 105.9518 Ops/s $\color{#35bf28}+3.95\%$
test_values[vec_generalized_advantage_estimate-True-True] 39.5555ms 35.2583ms 28.3621 Ops/s 30.0788 Ops/s $\textbf{\color{#d91a1a}-5.71\%}$
test_values[td0_return_estimate-False-False] 0.2167ms 0.1630ms 6.1362 KOps/s 6.0204 KOps/s $\color{#35bf28}+1.92\%$
test_values[td1_return_estimate-False-False] 25.0171ms 22.7114ms 44.0308 Ops/s 41.6019 Ops/s $\textbf{\color{#35bf28}+5.84\%}$
test_values[vec_td1_return_estimate-False-False] 37.0828ms 34.9988ms 28.5724 Ops/s 30.1179 Ops/s $\textbf{\color{#d91a1a}-5.13\%}$
test_values[td_lambda_return_estimate-True-False] 33.3558ms 32.9559ms 30.3436 Ops/s 28.8276 Ops/s $\textbf{\color{#35bf28}+5.26\%}$
test_values[vec_td_lambda_return_estimate-True-False] 39.4214ms 35.0279ms 28.5486 Ops/s 30.1036 Ops/s $\textbf{\color{#d91a1a}-5.17\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.6604ms 8.1094ms 123.3138 Ops/s 121.8190 Ops/s $\color{#35bf28}+1.23\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.4913ms 1.9219ms 520.3216 Ops/s 508.0406 Ops/s $\color{#35bf28}+2.42\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5570ms 0.3387ms 2.9526 KOps/s 2.8098 KOps/s $\textbf{\color{#35bf28}+5.08\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 45.4824ms 43.6366ms 22.9166 Ops/s 25.4176 Ops/s $\textbf{\color{#d91a1a}-9.84\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.5790ms 3.0067ms 332.5877 Ops/s 329.8036 Ops/s $\color{#35bf28}+0.84\%$
test_dqn_speed 7.2579ms 1.3345ms 749.3350 Ops/s 744.5684 Ops/s $\color{#35bf28}+0.64\%$
test_ddpg_speed 3.3368ms 2.7089ms 369.1489 Ops/s 347.8909 Ops/s $\textbf{\color{#35bf28}+6.11\%}$
test_sac_speed 9.7664ms 8.0580ms 124.1008 Ops/s 122.9037 Ops/s $\color{#35bf28}+0.97\%$
test_redq_speed 12.9153ms 12.6887ms 78.8105 Ops/s 77.6320 Ops/s $\color{#35bf28}+1.52\%$
test_redq_deprec_speed 13.5367ms 12.7385ms 78.5023 Ops/s 77.9084 Ops/s $\color{#35bf28}+0.76\%$
test_td3_speed 10.6165ms 8.0559ms 124.1334 Ops/s 123.7238 Ops/s $\color{#35bf28}+0.33\%$
test_cql_speed 62.7975ms 36.6335ms 27.2974 Ops/s 27.9899 Ops/s $\color{#d91a1a}-2.47\%$
test_a2c_speed 8.1768ms 7.2513ms 137.9059 Ops/s 136.9385 Ops/s $\color{#35bf28}+0.71\%$
test_ppo_speed 9.0151ms 7.5052ms 133.2409 Ops/s 132.4689 Ops/s $\color{#35bf28}+0.58\%$
test_reinforce_speed 6.9667ms 6.4625ms 154.7382 Ops/s 154.7351 Ops/s $+0.00\%$
test_iql_speed 33.3594ms 31.7618ms 31.4844 Ops/s 31.2414 Ops/s $\color{#35bf28}+0.78\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.2802ms 2.0932ms 477.7359 Ops/s 478.6664 Ops/s $\color{#d91a1a}-0.19\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.2882ms 0.4904ms 2.0392 KOps/s 2.0545 KOps/s $\color{#d91a1a}-0.75\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.6314ms 0.4653ms 2.1493 KOps/s 2.1561 KOps/s $\color{#d91a1a}-0.31\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.6319ms 2.0316ms 492.2307 Ops/s 490.3522 Ops/s $\color{#35bf28}+0.38\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9051ms 0.4755ms 2.1031 KOps/s 2.0911 KOps/s $\color{#35bf28}+0.57\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7727ms 0.4546ms 2.1999 KOps/s 2.1869 KOps/s $\color{#35bf28}+0.59\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.6649ms 2.1743ms 459.9216 Ops/s 453.7515 Ops/s $\color{#35bf28}+1.36\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1048ms 0.5963ms 1.6770 KOps/s 1.6601 KOps/s $\color{#35bf28}+1.02\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9635ms 0.5709ms 1.7515 KOps/s 1.7265 KOps/s $\color{#35bf28}+1.45\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.6788ms 2.1590ms 463.1704 Ops/s 480.3681 Ops/s $\color{#d91a1a}-3.58\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0296ms 0.4849ms 2.0623 KOps/s 2.0564 KOps/s $\color{#35bf28}+0.28\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7523ms 0.4629ms 2.1601 KOps/s 1.8243 KOps/s $\textbf{\color{#35bf28}+18.41\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.3418ms 2.0482ms 488.2446 Ops/s 476.6305 Ops/s $\color{#35bf28}+2.44\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9276ms 0.4791ms 2.0871 KOps/s 2.0799 KOps/s $\color{#35bf28}+0.34\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7037ms 0.4567ms 2.1896 KOps/s 2.1640 KOps/s $\color{#35bf28}+1.19\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.2714ms 2.1502ms 465.0728 Ops/s 457.8485 Ops/s $\color{#35bf28}+1.58\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9444ms 0.6028ms 1.6590 KOps/s 1.4013 KOps/s $\textbf{\color{#35bf28}+18.39\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.8602ms 0.5796ms 1.7254 KOps/s 1.4448 KOps/s $\textbf{\color{#35bf28}+19.42\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 92.7540ms 6.9021ms 144.8843 Ops/s 191.4100 Ops/s $\textbf{\color{#d91a1a}-24.31\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 14.1710ms 12.0264ms 83.1501 Ops/s 84.2941 Ops/s $\color{#d91a1a}-1.36\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.5666ms 1.0277ms 973.0064 Ops/s 929.8181 Ops/s $\color{#35bf28}+4.64\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 83.9239ms 6.7106ms 149.0184 Ops/s 148.5921 Ops/s $\color{#35bf28}+0.29\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 14.8810ms 12.0659ms 82.8783 Ops/s 84.4574 Ops/s $\color{#d91a1a}-1.87\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.5320ms 1.0312ms 969.7203 Ops/s 908.8003 Ops/s $\textbf{\color{#35bf28}+6.70\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 84.3303ms 6.9630ms 143.6168 Ops/s 141.9627 Ops/s $\color{#35bf28}+1.17\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 14.8343ms 12.4192ms 80.5202 Ops/s 82.3653 Ops/s $\color{#d91a1a}-2.24\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.9700ms 1.3404ms 746.0358 Ops/s 734.7187 Ops/s $\color{#35bf28}+1.54\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}1$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1620s 0.1131s 8.8452 Ops/s 9.2928 Ops/s $\color{#d91a1a}-4.82\%$
test_sync 94.5202ms 94.0717ms 10.6302 Ops/s 10.6249 Ops/s $\color{#35bf28}+0.05\%$
test_async 0.1781s 90.1149ms 11.0969 Ops/s 11.1493 Ops/s $\color{#d91a1a}-0.47\%$
test_single_pixels 0.1229s 0.1211s 8.2603 Ops/s 8.1941 Ops/s $\color{#35bf28}+0.81\%$
test_sync_pixels 75.2827ms 72.6716ms 13.7605 Ops/s 13.3609 Ops/s $\color{#35bf28}+2.99\%$
test_async_pixels 0.1232s 68.2253ms 14.6573 Ops/s 14.4881 Ops/s $\color{#35bf28}+1.17\%$
test_simple 0.8522s 0.7921s 1.2625 Ops/s 1.2883 Ops/s $\color{#d91a1a}-2.00\%$
test_transformed 1.0445s 0.9907s 1.0094 Ops/s 0.9934 Ops/s $\color{#35bf28}+1.61\%$
test_serial 2.3181s 2.2655s 0.4414 Ops/s 0.4339 Ops/s $\color{#35bf28}+1.73\%$
test_parallel 2.0225s 1.9673s 0.5083 Ops/s 0.5052 Ops/s $\color{#35bf28}+0.63\%$
test_step_mdp_speed[True-True-True-True-True] 0.1143ms 26.8577μs 37.2332 KOps/s 36.7285 KOps/s $\color{#35bf28}+1.37\%$
test_step_mdp_speed[True-True-True-True-False] 0.1233ms 16.2377μs 61.5851 KOps/s 60.4991 KOps/s $\color{#35bf28}+1.80\%$
test_step_mdp_speed[True-True-True-False-True] 36.2410μs 15.4259μs 64.8261 KOps/s 64.7352 KOps/s $\color{#35bf28}+0.14\%$
test_step_mdp_speed[True-True-True-False-False] 0.1207ms 9.3707μs 106.7158 KOps/s 105.8481 KOps/s $\color{#35bf28}+0.82\%$
test_step_mdp_speed[True-True-False-True-True] 66.8400μs 28.4989μs 35.0890 KOps/s 35.0018 KOps/s $\color{#35bf28}+0.25\%$
test_step_mdp_speed[True-True-False-True-False] 43.9210μs 18.2375μs 54.8321 KOps/s 55.2334 KOps/s $\color{#d91a1a}-0.73\%$
test_step_mdp_speed[True-True-False-False-True] 43.1800μs 17.0284μs 58.7254 KOps/s 58.5882 KOps/s $\color{#35bf28}+0.23\%$
test_step_mdp_speed[True-True-False-False-False] 31.2200μs 10.9916μs 90.9788 KOps/s 88.9305 KOps/s $\color{#35bf28}+2.30\%$
test_step_mdp_speed[True-False-True-True-True] 56.0310μs 30.0792μs 33.2455 KOps/s 32.8097 KOps/s $\color{#35bf28}+1.33\%$
test_step_mdp_speed[True-False-True-True-False] 39.2610μs 19.6316μs 50.9382 KOps/s 50.0994 KOps/s $\color{#35bf28}+1.67\%$
test_step_mdp_speed[True-False-True-False-True] 91.3110μs 17.0019μs 58.8170 KOps/s 59.2639 KOps/s $\color{#d91a1a}-0.75\%$
test_step_mdp_speed[True-False-True-False-False] 30.5000μs 11.1250μs 89.8875 KOps/s 88.8199 KOps/s $\color{#35bf28}+1.20\%$
test_step_mdp_speed[True-False-False-True-True] 0.1531ms 31.0473μs 32.2089 KOps/s 31.4345 KOps/s $\color{#35bf28}+2.46\%$
test_step_mdp_speed[True-False-False-True-False] 59.9510μs 21.4632μs 46.5915 KOps/s 46.7136 KOps/s $\color{#d91a1a}-0.26\%$
test_step_mdp_speed[True-False-False-False-True] 38.7600μs 18.8280μs 53.1124 KOps/s 53.4119 KOps/s $\color{#d91a1a}-0.56\%$
test_step_mdp_speed[True-False-False-False-False] 64.1210μs 12.7819μs 78.2356 KOps/s 78.0494 KOps/s $\color{#35bf28}+0.24\%$
test_step_mdp_speed[False-True-True-True-True] 54.6810μs 30.2898μs 33.0144 KOps/s 33.2702 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[False-True-True-True-False] 36.3300μs 19.3596μs 51.6541 KOps/s 49.9303 KOps/s $\color{#35bf28}+3.45\%$
test_step_mdp_speed[False-True-True-False-True] 45.4400μs 19.9060μs 50.2362 KOps/s 49.3040 KOps/s $\color{#35bf28}+1.89\%$
test_step_mdp_speed[False-True-True-False-False] 53.2110μs 12.3691μs 80.8467 KOps/s 78.2405 KOps/s $\color{#35bf28}+3.33\%$
test_step_mdp_speed[False-True-False-True-True] 49.6300μs 30.7877μs 32.4805 KOps/s 31.2330 KOps/s $\color{#35bf28}+3.99\%$
test_step_mdp_speed[False-True-False-True-False] 35.9100μs 20.6757μs 48.3659 KOps/s 45.7982 KOps/s $\textbf{\color{#35bf28}+5.61\%}$
test_step_mdp_speed[False-True-False-False-True] 0.1086ms 20.8912μs 47.8670 KOps/s 46.1692 KOps/s $\color{#35bf28}+3.68\%$
test_step_mdp_speed[False-True-False-False-False] 29.5210μs 14.1189μs 70.8273 KOps/s 69.2752 KOps/s $\color{#35bf28}+2.24\%$
test_step_mdp_speed[False-False-True-True-True] 47.3410μs 32.4277μs 30.8378 KOps/s 29.4420 KOps/s $\color{#35bf28}+4.74\%$
test_step_mdp_speed[False-False-True-True-False] 47.8210μs 22.8272μs 43.8075 KOps/s 42.3232 KOps/s $\color{#35bf28}+3.51\%$
test_step_mdp_speed[False-False-True-False-True] 38.0200μs 21.3617μs 46.8128 KOps/s 45.4482 KOps/s $\color{#35bf28}+3.00\%$
test_step_mdp_speed[False-False-True-False-False] 74.9300μs 14.0895μs 70.9750 KOps/s 69.2548 KOps/s $\color{#35bf28}+2.48\%$
test_step_mdp_speed[False-False-False-True-True] 58.6810μs 33.9588μs 29.4474 KOps/s 28.3655 KOps/s $\color{#35bf28}+3.81\%$
test_step_mdp_speed[False-False-False-True-False] 43.3910μs 24.5499μs 40.7333 KOps/s 39.8482 KOps/s $\color{#35bf28}+2.22\%$
test_step_mdp_speed[False-False-False-False-True] 50.2410μs 22.7822μs 43.8938 KOps/s 43.2767 KOps/s $\color{#35bf28}+1.43\%$
test_step_mdp_speed[False-False-False-False-False] 31.4710μs 15.2733μs 65.4736 KOps/s 62.5985 KOps/s $\color{#35bf28}+4.59\%$
test_values[generalized_advantage_estimate-True-True] 24.7912ms 24.3573ms 41.0554 Ops/s 38.7444 Ops/s $\textbf{\color{#35bf28}+5.96\%}$
test_values[vec_generalized_advantage_estimate-True-True] 88.4124ms 3.3306ms 300.2452 Ops/s 297.9045 Ops/s $\color{#35bf28}+0.79\%$
test_values[td0_return_estimate-False-False] 98.5010μs 61.2048μs 16.3386 KOps/s 16.0442 KOps/s $\color{#35bf28}+1.83\%$
test_values[td1_return_estimate-False-False] 53.1473ms 51.9153ms 19.2621 Ops/s 18.0110 Ops/s $\textbf{\color{#35bf28}+6.95\%}$
test_values[vec_td1_return_estimate-False-False] 4.4603ms 1.7937ms 557.5126 Ops/s 554.2817 Ops/s $\color{#35bf28}+0.58\%$
test_values[td_lambda_return_estimate-True-False] 86.7202ms 82.7433ms 12.0856 Ops/s 11.3294 Ops/s $\textbf{\color{#35bf28}+6.67\%}$
test_values[vec_td_lambda_return_estimate-True-False] 2.0395ms 1.7555ms 569.6499 Ops/s 560.4988 Ops/s $\color{#35bf28}+1.63\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.5205ms 23.0511ms 43.3819 Ops/s 42.9914 Ops/s $\color{#35bf28}+0.91\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8489ms 0.6756ms 1.4803 KOps/s 1.4505 KOps/s $\color{#35bf28}+2.05\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.8148ms 0.6354ms 1.5738 KOps/s 1.5559 KOps/s $\color{#35bf28}+1.14\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.6454ms 1.4399ms 694.4977 Ops/s 691.1430 Ops/s $\color{#35bf28}+0.49\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9135ms 0.6559ms 1.5245 KOps/s 1.5015 KOps/s $\color{#35bf28}+1.53\%$
test_dqn_speed 7.9769ms 1.2821ms 779.9547 Ops/s 755.7678 Ops/s $\color{#35bf28}+3.20\%$
test_ddpg_speed 3.4398ms 2.5333ms 394.7477 Ops/s 390.3104 Ops/s $\color{#35bf28}+1.14\%$
test_sac_speed 7.8736ms 7.3517ms 136.0233 Ops/s 133.2177 Ops/s $\color{#35bf28}+2.11\%$
test_redq_speed 10.4023ms 9.5637ms 104.5624 Ops/s 105.4841 Ops/s $\color{#d91a1a}-0.87\%$
test_redq_deprec_speed 10.9652ms 10.4462ms 95.7290 Ops/s 98.0015 Ops/s $\color{#d91a1a}-2.32\%$
test_td3_speed 15.3137ms 7.4835ms 133.6281 Ops/s 131.7005 Ops/s $\color{#35bf28}+1.46\%$
test_cql_speed 25.2481ms 24.0902ms 41.5107 Ops/s 41.6208 Ops/s $\color{#d91a1a}-0.26\%$
test_a2c_speed 5.5498ms 5.1917ms 192.6142 Ops/s 192.6889 Ops/s $\color{#d91a1a}-0.04\%$
test_ppo_speed 5.7822ms 5.5207ms 181.1363 Ops/s 182.3963 Ops/s $\color{#d91a1a}-0.69\%$
test_reinforce_speed 4.5382ms 4.2794ms 233.6782 Ops/s 234.8989 Ops/s $\color{#d91a1a}-0.52\%$
test_iql_speed 22.0171ms 18.5196ms 53.9968 Ops/s 53.4925 Ops/s $\color{#35bf28}+0.94\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.7319ms 2.5241ms 396.1861 Ops/s 395.6046 Ops/s $\color{#35bf28}+0.15\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6828ms 0.5260ms 1.9012 KOps/s 1.8976 KOps/s $\color{#35bf28}+0.19\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.5022ms 0.5122ms 1.9525 KOps/s 1.9636 KOps/s $\color{#d91a1a}-0.56\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.8243ms 2.5540ms 391.5391 Ops/s 395.7840 Ops/s $\color{#d91a1a}-1.07\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0461ms 0.5235ms 1.9103 KOps/s 1.9101 KOps/s $\color{#35bf28}+0.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7112ms 0.5046ms 1.9817 KOps/s 1.9875 KOps/s $\color{#d91a1a}-0.29\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.8697ms 2.6564ms 376.4520 Ops/s 380.9891 Ops/s $\color{#d91a1a}-1.19\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8431ms 0.6469ms 1.5460 KOps/s 1.5463 KOps/s $\color{#d91a1a}-0.02\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.8355ms 0.6284ms 1.5915 KOps/s 1.5906 KOps/s $\color{#35bf28}+0.06\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.7160ms 2.4957ms 400.6876 Ops/s 399.2099 Ops/s $\color{#35bf28}+0.37\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9812ms 0.5249ms 1.9050 KOps/s 1.8967 KOps/s $\color{#35bf28}+0.44\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6565ms 0.5099ms 1.9610 KOps/s 1.9523 KOps/s $\color{#35bf28}+0.45\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.7305ms 2.5081ms 398.7142 Ops/s 395.3700 Ops/s $\color{#35bf28}+0.85\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7337ms 0.5227ms 1.9130 KOps/s 1.5892 KOps/s $\textbf{\color{#35bf28}+20.37\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.1054s 0.6104ms 1.6384 KOps/s 1.9827 KOps/s $\textbf{\color{#d91a1a}-17.37\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.8287ms 2.6486ms 377.5560 Ops/s 376.9170 Ops/s $\color{#35bf28}+0.17\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7980ms 0.6471ms 1.5453 KOps/s 1.5370 KOps/s $\color{#35bf28}+0.54\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.6886ms 0.6371ms 1.5697 KOps/s 1.5699 KOps/s $\color{#d91a1a}-0.01\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1030s 8.2303ms 121.5017 Ops/s 120.3403 Ops/s $\color{#35bf28}+0.97\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.2385ms 12.8851ms 77.6092 Ops/s 79.9264 Ops/s $\color{#d91a1a}-2.90\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.9819ms 1.0788ms 926.9966 Ops/s 951.0681 Ops/s $\color{#d91a1a}-2.53\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1003s 6.2422ms 160.2011 Ops/s 158.5129 Ops/s $\color{#35bf28}+1.07\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 15.2618ms 12.7071ms 78.6962 Ops/s 80.7176 Ops/s $\color{#d91a1a}-2.50\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 5.9702ms 1.1721ms 853.1664 Ops/s 847.9226 Ops/s $\color{#35bf28}+0.62\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1018s 8.5043ms 117.5879 Ops/s 116.1059 Ops/s $\color{#35bf28}+1.28\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.3225ms 13.0064ms 76.8850 Ops/s 77.9844 Ops/s $\color{#d91a1a}-1.41\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 6.0578ms 1.5434ms 647.9215 Ops/s 658.1856 Ops/s $\color{#d91a1a}-1.56\%$

@vmoens vmoens merged commit b8ad113 into main Feb 27, 2024
64 of 67 checks passed
@vmoens vmoens deleted the remove-func-tests branch February 27, 2024 14:35
albertbou92 pushed a commit to PyTorchRL/rl that referenced this pull request Feb 27, 2024
@vmoens @albertbou92
[Refactor] Remove remnant legacy functional calls (pytorch#1973)
4c9e0e6
vmoens added a commit that referenced this pull request Feb 28, 2024
@vmoens
[Refactor] Remove remnant legacy functional calls (#1973)
3ba16f6
@vmoens vmoens mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactoring Refactoring of an existing feature Suitable for minor Suitable to be integrated in minor release (no new feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot