Update

[ghstack-poisoned]
pytorch · Feb 3, 2025 · df4bd97 · df4bd97
2 parents 9f6f013 + 1f0835e
commit df4bd97
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 11 deletions.
diff --git a/.github/unittest/linux_olddeps/scripts_gym_0_13/environment.yml b/.github/unittest/linux_olddeps/scripts_gym_0_13/environment.yml
@@ -2,7 +2,7 @@ channels:
   - pytorch
   - defaults
 dependencies:
-  - pip
+  - pip<25.0
   - protobuf
   - pip:
     - hypothesis
@@ -21,7 +21,6 @@ dependencies:
     - pyyaml
     - scipy
     - hydra-core
-    - dm_control -e git+https://github.com/deepmind/dm_control.git@c053360edea6170acfd9c8f65446703307d9d352#egg={dm_control}
     - mujoco
     - patchelf
     - pyopengl==3.1.4

diff --git a/.github/unittest/linux_olddeps/scripts_gym_0_13/run_test.sh b/.github/unittest/linux_olddeps/scripts_gym_0_13/run_test.sh
@@ -22,7 +22,7 @@ export MKL_THREADING_LAYER=GNU
 export BATCHED_PIPE_TIMEOUT=60
 
 python .github/unittest/helpers/coverage_run_parallel.py -m pytest test/smoke_test.py -v --durations 200
-python .github/unittest/helpers/coverage_run_parallel.py -m pytest test/smoke_test_deps.py -v --durations 200 -k 'test_gym or test_dm_control_pixels or test_dm_control'
+python .github/unittest/helpers/coverage_run_parallel.py -m pytest test/smoke_test_deps.py -v --durations 200 -k 'test_gym'
 
 export DISPLAY=':99.0'
 Xvfb :99 -screen 0 1400x900x24 > /dev/null 2>&1 &

diff --git a/.github/unittest/linux_olddeps/scripts_gym_0_13/setup_env.sh b/.github/unittest/linux_olddeps/scripts_gym_0_13/setup_env.sh
@@ -62,7 +62,13 @@ cp mjkey.txt mujoco_py/binaries/
 pip install -e .
 cd ..
 
-#cd $this_dir
+# OLD DM_CONTROL NOT SUPPORTED ANYMORE
+# # Install dm_control
+# git clone https://github.com/deepmind/dm_control
+# cd dm_control
+# git checkout c053360edea6170acfd9c8f65446703307d9d352
+# pip install -e .
+# cd ..
 
 # 4. Install Conda dependencies
 printf "* Installing dependencies (except PyTorch)\n"

diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml
@@ -29,7 +29,7 @@ jobs:
         run: |
           echo "Action triggered by ${{ github.event.pull_request.html_url }}"
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 50 # this is to make sure we obtain the target base commit
       - name: Python Setup
@@ -84,7 +84,7 @@ jobs:
       - name: Check ldd --version
         run: ldd --version
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 50 # this is to make sure we obtain the target base commit
       - name: Python Setup

diff --git a/.github/workflows/benchmarks_pr.yml b/.github/workflows/benchmarks_pr.yml
@@ -20,7 +20,7 @@ jobs:
         run: |
           echo "Action triggered by ${{ github.event.pull_request.html_url }}"
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 50 # this is to make sure we obtain the target base commit
       - name: Python Setup
@@ -93,7 +93,7 @@ jobs:
       - name: Check ldd --version
         run: ldd --version
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 50 # this is to make sure we obtain the target base commit
       - name: Python Setup

diff --git a/.github/workflows/wheels-legacy.yml b/.github/workflows/wheels-legacy.yml
@@ -41,12 +41,12 @@ jobs:
             python3 -mpip install wheel
             TORCHRL_BUILD_VERSION=0.6.1 python3 setup.py bdist_wheel
       - name: Upload wheel for the test-wheel job
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: torchrl-win-${{ matrix.python_version[0] }}.whl
           path: dist/torchrl-*.whl
       - name: Upload wheel for download
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: torchrl-batch.whl
           path: dist/*.whl
@@ -81,7 +81,7 @@ jobs:
         run: |
           python3 -mpip install numpy pytest pytest-cov codecov unittest-xml-reporting pillow>=4.1.1 scipy av networkx expecttest pyyaml
       - name: Download built wheels
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: torchrl-win-${{ matrix.python_version }}.whl
           path: wheels