Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new method SummaryWriter.flush() #20607

Closed

Conversation

nataliakliushkina
Copy link
Contributor

Summary: Add a new method SummaryWriter.flush() that iterates through all of the FileWriters and flushes them

Differential Revision: D15380124

Summary: Add a new method SummaryWriter.flush()  that iterates through all of the FileWriters and flushes them

Differential Revision: D15380124

fbshipit-source-id: ac6fbaee0d6d8534f76f0397e69d859ee87396c0
Copy link
Contributor

@orionr orionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Test failures are unrelated.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c0a2a3b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants