[BE] Change _marked_safe_globals_list to set #139303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Oct 29, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139303
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b008448 with merge base 73fde0d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 30, 2024
ghstack-source-id: ecbe4abb73ac5c79e02152845c030386812f2166 Pull Request resolved: #139303
[ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 30, 2024
ghstack-source-id: 1143495135b606504f2a749fdd8a0f040712f0b8 Pull Request resolved: #139303
[ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 30, 2024
ghstack-source-id: fb6183a0733be1aa68c6a663609580f93235c7f4 Pull Request resolved: #139303
[ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 30, 2024
ghstack-source-id: 18fe8505cda6d6e626f12c88314a9da2fa6016c7 Pull Request resolved: #139303
[ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 30, 2024
ghstack-source-id: da7ef54da4992c85c80251906ab66056520ca501 Pull Request resolved: #139303
[ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 31, 2024
ghstack-source-id: 88825ca646efa5bb626ae7be4acf751fef81bba2 Pull Request resolved: #139303
Prevent same global from being added multiple times [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 31, 2024
ghstack-source-id: f1dd13765bfd55be91f0a86cb7d0df91c760cd78 Pull Request resolved: #139303
Prevent same global from being added multiple times [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 31, 2024
ghstack-source-id: da2b06d3d0ac33d0619096663573f9bbcdb271be Pull Request resolved: #139303
Prevent same global from being added multiple times [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 31, 2024
ghstack-source-id: c7e4876e6e58f1928efae4a207610c7ced3aebdf Pull Request resolved: #139303
Prevent same global from being added multiple times [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 31, 2024
ghstack-source-id: 84c92d8be51ef6af1f1347be574bce56e1e5b45e Pull Request resolved: #139303
Prevent same global from being added multiple times [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 31, 2024
ghstack-source-id: 2214d0f025b270f2b26188d0de7926f9504fbccf Pull Request resolved: #139303
Prevent same global from being added multiple times [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 31, 2024
ghstack-source-id: 5ac797d7b5dfbabc014603f6ddf3eb83bfaf61e4 Pull Request resolved: #139303
Prevent same global from being added multiple times [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Nov 1, 2024
ghstack-source-id: 397e1b1298dd55524affc721a4b69747c1023f92 Pull Request resolved: #139303
Prevent same global from being added multiple times [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Nov 1, 2024
ghstack-source-id: 9ee1a7becfe9a062bd7253895b1591cb0bdbb3c0 Pull Request resolved: #139303
Prevent same global from being added multiple times [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Nov 1, 2024
ghstack-source-id: df14b7352246fc7882d169ff3f91728a1872b8ea Pull Request resolved: #139303
Prevent same global from being added multiple times [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Nov 2, 2024
ghstack-source-id: 6a59b4eac5c02d657a2147f8a765cdf6e08d8e95 Pull Request resolved: #139303
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
Nov 11, 2024
Prevent same global from being added multiple times Pull Request resolved: pytorch#139303 Approved by: https://github.com/janeyx99 ghstack dependencies: pytorch#138936, pytorch#139221, pytorch#139433, pytorch#139541, pytorch#137602
Ryo-not-rio
pushed a commit
to Ryo-not-rio/pytorch
that referenced
this pull request
Dec 2, 2024
Prevent same global from being added multiple times Pull Request resolved: pytorch#139303 Approved by: https://github.com/janeyx99 ghstack dependencies: pytorch#138936, pytorch#139221, pytorch#139433, pytorch#139541, pytorch#137602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent same global from being added multiple times
Stack from ghstack (oldest at bottom):