Pin sympy to 1.13.1 #133235
Closed
Pin sympy to 1.13.1 #133235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133235
Note: Links to docs will display an error until the docs builds have been completed. ❌ 11 New FailuresAs of commit 098848e with merge base 3128640 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
clee2000
force-pushed
the
csl/pin_sympy
branch
from
1d32430 to
098848e
Compare
atalman
added
the
ciflow/binaries
atalman
approved these changes
Aug 12, 2024
ZainRizvi
approved these changes
Aug 12, 2024
|
@clee2000 xpu Docker failures are not related to this PR and probably fixed by: pytorch/builder#1956 |
|
@pytorchbot merge -f "emergency land" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
cc @XuehaiPan since I think you did the last pinning and update for sympy? |
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
Aug 13, 2024
Sympy 1.13.2 release yesterday, and it results in test failures on windows and mac https://hud.pytorch.org/hud/pytorch/pytorch/454713fe9d11c3b70c28f1aaba74f5158f92d1ec/1?per_page=100 Hopefully these are the places it needs to get pinned Pull Request resolved: pytorch#133235 Approved by: https://github.com/atalman, https://github.com/ZainRizvi
Jack-Khuu
added a commit
to pytorch/torchchat
that referenced
this pull request
Aug 14, 2024
byjlw
added a commit
to pytorch/torchchat
that referenced
this pull request
Aug 16, 2024
* Update install_requirements.sh to use PT 20240814 https://hud.pytorch.org/pytorch/pytorch/commit/3a023a67c47bcde45538c9991e332d21ac548e46 To pick up fix in pytorch/pytorch#133235 * Update AO pin * Remove unwrapping tensor_subclass * Conditional subclass unwrap since aoti doesn't support tensor_subclass * Missed intialize entry point with conditional unwrap --------- Co-authored-by: Jesse White <5281939+byjlw@users.noreply.github.com>
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
Aug 26, 2024
Sympy 1.13.2 release yesterday, and it results in test failures on windows and mac https://hud.pytorch.org/hud/pytorch/pytorch/454713fe9d11c3b70c28f1aaba74f5158f92d1ec/1?per_page=100 Hopefully these are the places it needs to get pinned Pull Request resolved: pytorch#133235 Approved by: https://github.com/atalman, https://github.com/ZainRizvi
This was referenced Aug 26, 2024
atalman
added a commit
to atalman/pytorch
that referenced
this pull request
Aug 27, 2024
This reverts commit 864cd32. Revert "Pin sympy to 1.13.1 (pytorch#133235)" This reverts commit cf77a5e. pin sympy win test
atalman
added a commit
that referenced
this pull request
Aug 27, 2024
…n sympy (#134489) * [Release Only] Disable failing tests in release * fix * skip_xla_op_test * ping_optree_win * Pin sympy to 1.13.1 (#133235) Sympy 1.13.2 release yesterday, and it results in test failures on windows and mac https://hud.pytorch.org/hud/pytorch/pytorch/454713fe9d11c3b70c28f1aaba74f5158f92d1ec/1?per_page=100 Hopefully these are the places it needs to get pinned Pull Request resolved: #133235 Approved by: https://github.com/atalman, https://github.com/ZainRizvi * fix sympy * Revert "fix sympy" This reverts commit 864cd32. Revert "Pin sympy to 1.13.1 (#133235)" This reverts commit cf77a5e. pin sympy win test --------- Co-authored-by: Catherine Lee <csl@fb.com>
jataylo
added a commit
to ROCm/pytorch
that referenced
this pull request
Sep 5, 2024
Cherry pick pytorch#133235
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Sep 9, 2024
Cherry pick pytorch#133235 Fixes SWDEV-473498
dnikolaev-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Sep 16, 2024
Cherry pick pytorch#133235 Fixes SWDEV-473498
This was referenced Oct 18, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 20, 2024
`simpy` was pinned to version 1.13.1 due to test failures with version 1.13.2 on Windows and mac, as reported in #133235. Now that a newer version, 1.13.3, has been released, this PR aims to verify if the test failure has been resolved and also allow building with newer versions for packaging purposes (e.g., conda-forge/pytorch-cpu-feedstock#277 (comment)). Pull Request resolved: #138338 Approved by: https://github.com/Skylion007, https://github.com/malfet Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sympy 1.13.2 release yesterday, and it results in test failures on windows and mac
https://hud.pytorch.org/hud/pytorch/pytorch/454713fe9d11c3b70c28f1aaba74f5158f92d1ec/1?per_page=100
Hopefully these are the places it needs to get pinned