Explicit opt_einsum.contract import for linear.py #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60134455 |
Summary: Pull Request resolved: pytorch#658 `opt_einsum` package contains ambiguous imports. It has submodule `opt_einsum/contract.py` and at the same time has the following in `__init__.py`: ``` from .contract import contract ``` So normally `from opt_einsum import contract` should import the method not the module. Howeve, some build systems get confused. This change removes ambiguity and shouldn't affect behaviour in any way Differential Revision: D60134455
|
This pull request was exported from Phabricator. Differential Revision: D60134455 |
HuanyuZhang
force-pushed
the
export-D60134455
branch
from
c369064 to
9b1599a
Compare
|
This pull request has been merged in 9738f0b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
opt_einsumpackage contains ambiguous imports. It has submoduleopt_einsum/contract.pyand at the same time has the following in__init__.py:So normally
from opt_einsum import contractshould import the method not the module. Howeve, some build systems get confused.This change removes ambiguity and shouldn't affect behaviour in any way
Differential Revision: D60134455