Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in _replace_sub_module method in module_validator.py #482

Closed
wants to merge 1 commit into from
Closed

Fixed typo in _replace_sub_module method in module_validator.py #482

wants to merge 1 commit into from

Conversation

zycalice
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

Fixed _replace_sub_module, which used to be _repalce_sub_module

Related to issue #380 but on methods

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2022
@facebook-github-bot
Copy link
Contributor

@zycalice has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@romovpa romovpa changed the title refactor _replace_sub_module method in module_validator.py Fixed typo in _replace_sub_module method in module_validator.py Aug 26, 2022
@zycalice zycalice deleted the fix-replace-method-typo branch August 27, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandresablayrolles alexandresablayrolles alexandresablayrolles approved these changes

@romovpa romovpa romovpa approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zycalice @facebook-github-bot @romovpa @alexandresablayrolles