Include batch_size as an argument, instead of sample_rate #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D38799564 |
Summary: Pull Request resolved: #473 Other examples in Opacus follow this logic for arguments related to batch size: - batch_size and batch_size_test CIFAR-10 still uses the `sample_rate * len(train_data)`. This diff updates that, to aslo make it clearer (someone was confused [here](https://discuss.pytorch.org/t/the-opacus-example-train-batch-size-vs-sampling-rate/158771)) Reviewed By: ffuuugor Differential Revision: D38799564 fbshipit-source-id: 51035caada49c90ee95aec51e75e66837eec4338
|
This pull request was exported from Phabricator. Differential Revision: D38799564 |
| metavar="SR", | ||
| help="sample rate used for batch construction (default: 0.005)", | ||
| metavar="N", | ||
| help="train bacth size", |
There was a problem hiding this comment.
may be change this to approximate batch size in the help string, since the batch size will not necessarily be 2K.
|
This pull request was exported from Phabricator. Differential Revision: D38799564 |
|
This pull request was exported from Phabricator. Differential Revision: D38799564 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D38799564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Other examples in Opacus follow this logic for arguments related to batch size:
CIFAR-10 still uses the
sample_rate * len(train_data).This diff updates that, to aslo make it clearer (someone was confused here)
Differential Revision: D38799564