zero_grad() between forward and backward passes generates error message #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D36105357 |
pierrestock
pushed a commit
to pierrestock/opacus
that referenced
this pull request
May 3, 2022
…ge (pytorch#423) Summary: Pull Request resolved: pytorch#423 Fixing the previous fix in D36067469 (pytorch@56df34e). Context regarding the execution order of backward hooks: - `register_backward_hook` has **constant** behaviors across tested PyTorch versions - `register_full_backward_hook` has various behaviors. Previous fix was working for `torch==1.11` but not for `torch==1.8.1`, hence CircleCI failures. This fix now works for **both** versions. Note that `register_backward_hook` will be deprecated in the future by the Pytorch team. Differential Revision: D36105357 fbshipit-source-id: d8e561836c681a47dacb363ae9d6661ea660f8b7
pierrestock
force-pushed
the
export-D36105357
branch
from
5127c9d to
332d73d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D36105357 |
…ge (pytorch#423) Summary: Pull Request resolved: pytorch#423 Fixing the previous fix in D36067469 (pytorch@56df34e). Context regarding the execution order of backward hooks: - `register_backward_hook` has **constant** behaviors across tested PyTorch versions - `register_full_backward_hook` has various behaviors. Previous fix was working for `torch==1.11` but not for `torch==1.8.1`, hence CircleCI failures. This fix now works for **both** versions. Note that `register_backward_hook` will be deprecated in the future by the Pytorch team. Differential Revision: D36105357 fbshipit-source-id: 100e9910f2ee3b310d4b39275a3399a1d3dfa99b
pierrestock
force-pushed
the
export-D36105357
branch
from
332d73d to
063a9ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D36105357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixing the previous fix in D36067469 (56df34e).
Context regarding the execution order of backward hooks:
register_backward_hookhas constant behaviors across tested PyTorch versionsregister_full_backward_hookhas various behaviors.Previous fix was working for
torch==1.11but not fortorch==1.8.1, hence CircleCI failures. This fix now works for both versions.Note that
register_backward_hookwill be deprecated in the future by the Pytorch team.Differential Revision: D36105357