Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyTorch Lightning Example for API v1.0 #298

Closed
wants to merge 3 commits into from
Closed

PyTorch Lightning Example for API v1.0 #298

wants to merge 3 commits into from

Conversation

romovpa
Copy link
Contributor

@romovpa romovpa commented Dec 1, 2021 •
edited
Loading

Example demonstrating how Opacus v1.0 API can be used with PyTorch Lightning. This is a follow-up for #250.

Changes

Added mnist_lightning.py with the classifier allowing training with DP.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

How Has This Been Tested (if it applies)

All unit tests plus running the example:

python mnist_lightning.py fit --trainer.max_epochs 2
VANILLA_LIGHTNING=true python mnist_lightning.py

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2021
@romovpa romovpa mentioned this pull request Dec 1, 2021
Closed
5 tasks
@facebook-github-bot
Copy link
Contributor

@romovpa has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@romovpa has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@romovpa has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Dec 1, 2021
@karthikprasad @facebook-github-bot
resolve race conflicts
7a43438 
Summary: #298 was racing against #294, and ended up overwriting the following changes. This commit cleans up the bits.

Reviewed By: ashkan-software

Differential Revision: D32750421

fbshipit-source-id: 8343d92f6792f89133696fd46748a03717e2040a
@karthikprasad karthikprasad mentioned this pull request Dec 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikprasad karthikprasad Awaiting requested review from karthikprasad

@ffuuugor ffuuugor Awaiting requested review from ffuuugor

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romovpa @facebook-github-bot