Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PyTest to dev install #144

Closed
wants to merge 1 commit into from
Closed

Conversation

Darktex
Copy link
Contributor

@Darktex Darktex commented Mar 4, 2021

Summary: #142 correctly points out that "normal" users won't need pytest installed. Moved it accordingly.

Differential Revision: D26798927

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Mar 4, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D26798927

@Darktex Darktex self-assigned this Mar 4, 2021
@Darktex Darktex linked an issue Mar 4, 2021 that may be closed by this pull request
Darktex added a commit to Darktex/opacus that referenced this pull request Mar 4, 2021
Summary:
Pull Request resolved: pytorch#144

pytorch#142 correctly points out that "normal" users won't need pytest installed. Moved it accordingly.

Reviewed By: sayanghosh, karthikprasad

Differential Revision: D26798927

fbshipit-source-id: 9428238048b99bee0288207750f1f51305d2f888
@Darktex Darktex force-pushed the export-D26798927 branch from 8b5f24b to 6791458 Compare March 4, 2021 00:46
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D26798927

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D26798927

Darktex added a commit to Darktex/opacus that referenced this pull request Mar 4, 2021
Summary:
Pull Request resolved: pytorch#144

pytorch#142 correctly points out that "normal" users won't need pytest installed. Moved it accordingly.

Reviewed By: sayanghosh, karthikprasad

Differential Revision: D26798927

fbshipit-source-id: 0fa3e7a27664bbb1c798d95db3d58b25fc9f5695
@Darktex Darktex force-pushed the export-D26798927 branch from 6791458 to ccdfcef Compare March 4, 2021 01:06
Summary:
Pull Request resolved: pytorch#144

pytorch#142 correctly points out that "normal" users won't need pytest installed. Moved it accordingly.

Reviewed By: sayanghosh, karthikprasad

Differential Revision: D26798927

fbshipit-source-id: 0a642be4222e6be7c786c9380eb6fc10d9260b9c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D26798927

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4a8bbe8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pytest as a runtime dependency
2 participants