[Arm] Fix tosa-reference model upstream tracking #6156
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6156
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ca6fc23 with merge base 56a3d1e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
digantdesai
added
partner: arm
examples/arm/setup.sh
Outdated
| cd reference_model | ||
| git reset --hard ${tosa_reference_model_rev} |
There was a problem hiding this comment.
git reset will change what the default branch points to; maybe just
| git reset --hard ${tosa_reference_model_rev} | |
| git checkout ${tosa_reference_model_rev} |
But the reset will work.
There was a problem hiding this comment.
Just the detached head warning I don't like with check out, but no strong preference, will update.
There was a problem hiding this comment.
Reset is fine if you'd rather do that. Stack overflow seems to do either of them. And since we're not making changes to the repo it's not a big deal -- origin/main won't change even with a reset
It appears that upstream updates to branch tosa_reference_model/v0.8 which we used to track broke ET CI. Hard coding it to a known good version for now. * Failed CI job - https://github.com/pytorch/executorch/actions/runs/11283289096/job/31382443033#step:12:26700 * Upstream branch updates - https://review.mlplatform.org/q/project:tosa%252Freference_model+branch:v0.80 Potentially culprit gerrit ids - 12676, 12677, 12678 updated today
|
I will let the CI run for an hour or so then push an update and also a cherry-pick request assuming everything works. |
digantdesai
force-pushed
the
tosa_ref_model_fix
branch
from
194051b
to
ca6fc23
Compare
|
Arm jobs passed!! |
|
@pytorchbot cherry-pick --onto release/0.4 -c critical |
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai merged this pull request in 5696b35. |
|
Think you need to do this after it's actually merged into main |
|
@pytorchbot cherry-pick --onto release/0.4 -c critical |
Summary: It appears that upstream updates to branch tosa_reference_model/v0.8 which we used to track broke ET CI. Hard coding it to a known good version for now. * Failed CI job - https://github.com/pytorch/executorch/actions/runs/11283289096/job/31382443033#step:12:26700 * Upstream branch updates - https://review.mlplatform.org/q/project:tosa%252Freference_model+branch:v0.80 Potentially culprit gerrit ids - 12676, 12677, 12678 updated today Pull Request resolved: #6156 Reviewed By: larryliu0820 Differential Revision: D64222142 Pulled By: digantdesai fbshipit-source-id: 8438770851f8309020755992036f8e4c50857301 (cherry picked from commit 5696b35)
Cherry picking #6156The cherry pick PR is at #6162 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
|
Thanks for sorting that out @digantdesai. Will add the needed fix in handling dequanting the output from the reference model which will fix it for main. Moving the model in controlled steps seems a good addition anyways. |
Fix tosa-reference model upstream tracking (#6156) Summary: It appears that upstream updates to branch tosa_reference_model/v0.8 which we used to track broke ET CI. Hard coding it to a known good version for now. * Failed CI job - https://github.com/pytorch/executorch/actions/runs/11283289096/job/31382443033#step:12:26700 * Upstream branch updates - https://review.mlplatform.org/q/project:tosa%252Freference_model+branch:v0.80 Potentially culprit gerrit ids - 12676, 12677, 12678 updated today Pull Request resolved: #6156 Reviewed By: larryliu0820 Differential Revision: D64222142 Pulled By: digantdesai fbshipit-source-id: 8438770851f8309020755992036f8e4c50857301 (cherry picked from commit 5696b35) Co-authored-by: Digant Desai <digantdesai@meta.com>
It appears that upstream updates to branch tosa_reference_model/v0.8 which we used to track broke ET CI. Hard coding it to a known good version for now.
Failed CI job - https://github.com/pytorch/executorch/actions/runs/11283289096/job/31382443033#step:12:26700
Upstream branch updates - https://review.mlplatform.org/q/project:tosa%252Freference_model+branch:v0.80 Potentially culprit gerrit ids - 12676, 12677, 12678 updated today