Fix androd-perf workflow OOM #6109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6109
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3be677b with merge base df5b2ab ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
approved these changes
Oct 10, 2024
|
Let me make sure we have a way to reproduce the workflow issue before merging this fix. The issue is if one of the model fails to expert, it will:
cc: @huydhn |
guangy10
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
|
Okay, verified that we can reproduce the issue by just run with an supported model/backend, like this: https://github.com/pytorch/executorch/actions/runs/11280108348 |
|
Safe to merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ic4 and dl3 run OOM on 2xlarge runner.