[ET-VK] Support serializing scalar tensors as SymInt values #6070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context * Add `SymInt` to serialization schema * Make the serializer serialize scalar tensors as `SymInt` instead of `VkTensor` * Add support for `SymInt` in `VulkanBackend.cpp` Differential Revision: [D64139868](https://our.internmc.facebook.com/intern/diff/D64139868/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6070
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2ad3910 with merge base 866b40c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
SS-JIA
added a commit
that referenced
this pull request
Oct 9, 2024
## Context * Add `SymInt` to serialization schema * Make the serializer serialize scalar tensors as `SymInt` instead of `VkTensor` * Add support for `SymInt` in `VulkanBackend.cpp` Differential Revision: [D64139868](https://our.internmc.facebook.com/intern/diff/D64139868/) ghstack-source-id: 247163958 Pull Request resolved: #6070
|
This pull request was exported from Phabricator. Differential Revision: D64139868 |
jorgep31415
approved these changes
Oct 9, 2024
|
This pull request has been merged in 4b6a033. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
RemoveLocalScalarDenseOpsTransformto tag scalar tensors as well #6069Context
SymIntto serialization schemaSymIntinstead ofVkTensorSymIntinVulkanBackend.cppDifferential Revision: D64139868