s/exec_aten::/executorch::aten::/ for runtime/**/*.h #6030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6030
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 0dfa4bf with merge base 4a4a90f ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64078576 |
lucylq
approved these changes
Oct 9, 2024
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Oct 9, 2024
Summary: Migrate all runtime headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64078576
dbort
force-pushed
the
export-D64078576
branch
from
fad3965
to
1131004
Compare
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Oct 9, 2024
Summary: Migrate all runtime headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64078576
dbort
force-pushed
the
export-D64078576
branch
from
1131004
to
50eb1e5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64078576 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D64078576 |
dbort
force-pushed
the
export-D64078576
branch
from
50eb1e5
to
7bdeddb
Compare
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Oct 9, 2024
Summary: Migrate all runtime headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64078576
|
This pull request was exported from Phabricator. Differential Revision: D64078576 |
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Oct 10, 2024
Summary: Migrate all runtime headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64078576
dbort
force-pushed
the
export-D64078576
branch
from
7bdeddb
to
6d4ac6b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64078576 |
Summary: Migrate all runtime headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64078576
dbort
force-pushed
the
export-D64078576
branch
from
6d4ac6b
to
0dfa4bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64078576 |
|
This pull request has been merged in 84f51d1. |
|
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 11, 2024
Summary: Pull Request resolved: #6030 Migrate all runtime headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64078576 fbshipit-source-id: fe011d0ff16b0beaa278944312a62760e51b945c (cherry picked from commit 84f51d1)
Cherry picking #6030The cherry pick PR is at #6161 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
dbort
added a commit
that referenced
this pull request
Oct 11, 2024
Summary: Pull Request resolved: #6030 Migrate all runtime headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64078576 fbshipit-source-id: fe011d0ff16b0beaa278944312a62760e51b945c (cherry picked from commit 84f51d1)
dbort
added a commit
that referenced
this pull request
Oct 11, 2024
s/exec_aten::/executorch::aten::/ for runtime/**/*.h (#6030) Summary: Pull Request resolved: #6030 Migrate all runtime headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later. Reviewed By: lucylq Differential Revision: D64078576 fbshipit-source-id: fe011d0ff16b0beaa278944312a62760e51b945c (cherry picked from commit 84f51d1) Co-authored-by: Dave Bort <dbort@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Migrate all runtime headers to use the new aten namespace, so that they act as good examples for users. The .cpp code can migrate later.
Differential Revision: D64078576