Move mediatek.passes to mediatek._passes #5922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5922
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d248d71 with merge base a6b213b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63926846 |
tarun292
added a commit
that referenced
this pull request
Oct 7, 2024
Summary: Changing mediatek.passes to mediatek._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5922 Differential Revision: D63926846
tarun292
force-pushed
the
export-D63926846
branch
from
145768e
to
f3322ee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63926846 |
|
@neuropilot-captain can you take a look at this? |
helunwencser
approved these changes
Oct 7, 2024
tarun292
added a commit
that referenced
this pull request
Oct 7, 2024
Summary: Changing mediatek.passes to mediatek._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5922 Reviewed By: helunwencser Differential Revision: D63926846
tarun292
force-pushed
the
export-D63926846
branch
from
f3322ee
to
9fc0132
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63926846 |
tarun292
added a commit
that referenced
this pull request
Oct 8, 2024
Summary: Changing mediatek.passes to mediatek._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5922 Reviewed By: helunwencser Differential Revision: D63926846
tarun292
force-pushed
the
export-D63926846
branch
from
9fc0132
to
43e01d7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63926846 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D63926846 |
tarun292
added a commit
that referenced
this pull request
Oct 8, 2024
Summary: Changing mediatek.passes to mediatek._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5922 Reviewed By: helunwencser Differential Revision: D63926846
tarun292
force-pushed
the
export-D63926846
branch
from
43e01d7
to
37954d2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63926846 |
tarun292
added a commit
that referenced
this pull request
Oct 8, 2024
Summary: Changing mediatek.passes to mediatek._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5922 Reviewed By: helunwencser Differential Revision: D63926846
tarun292
force-pushed
the
export-D63926846
branch
from
37954d2
to
2a00a51
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63926846 |
tarun292
added a commit
that referenced
this pull request
Oct 8, 2024
Summary: Changing mediatek.passes to mediatek._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5922 Reviewed By: helunwencser Differential Revision: D63926846
tarun292
force-pushed
the
export-D63926846
branch
from
2a00a51
to
9b684f8
Compare
tarun292
added a commit
that referenced
this pull request
Oct 8, 2024
Summary: Changing mediatek.passes to mediatek._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5922 Reviewed By: helunwencser Differential Revision: D63926846
|
This pull request was exported from Phabricator. Differential Revision: D63926846 |
tarun292
force-pushed
the
export-D63926846
branch
from
9b684f8
to
413fdbd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63926846 |
tarun292
added a commit
that referenced
this pull request
Oct 8, 2024
Summary: Changing mediatek.passes to mediatek._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5922 Reviewed By: helunwencser Differential Revision: D63926846
tarun292
force-pushed
the
export-D63926846
branch
from
413fdbd
to
0d8f377
Compare
Differential Revision: D63926849
Differential Revision: D63926845
Differential Revision: D63926847
|
This pull request was exported from Phabricator. Differential Revision: D63926846 |
tarun292
added a commit
that referenced
this pull request
Oct 8, 2024
Summary: Changing mediatek.passes to mediatek._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5922 Reviewed By: helunwencser Differential Revision: D63926846
tarun292
force-pushed
the
export-D63926846
branch
from
0d8f377
to
c754771
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63926846 |
tarun292
force-pushed
the
export-D63926846
branch
from
c754771
to
44577eb
Compare
tarun292
added a commit
that referenced
this pull request
Oct 8, 2024
Summary: Changing mediatek.passes to mediatek._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5922 Reviewed By: helunwencser Differential Revision: D63926846
|
Should update the import statement in It currently use |
Summary: Changing mediatek.passes to mediatek._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5922 Reviewed By: helunwencser Differential Revision: D63926846
|
This pull request was exported from Phabricator. Differential Revision: D63926846 |
tarun292
force-pushed
the
export-D63926846
branch
from
44577eb
to
d248d71
Compare
|
This pull request has been merged in e540bcb. |
|
@pytorchbot cherry-pick --onto release/0.4 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 10, 2024
Summary: Changing mediatek.passes to mediatek._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5922 Reviewed By: helunwencser Differential Revision: D63926846 fbshipit-source-id: fcea1a560892200f9ca0e110104908de0be25867 (cherry picked from commit e540bcb)
Cherry picking #5922The cherry pick PR is at #6089 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
dbort
pushed a commit
that referenced
this pull request
Oct 11, 2024
Move mediatek.passes to mediatek._passes (#5922) Summary: Changing mediatek.passes to mediatek._passes to indicate that these passes are not covered under the API stability guarantee. Pull Request resolved: #5922 Reviewed By: helunwencser Differential Revision: D63926846 fbshipit-source-id: fcea1a560892200f9ca0e110104908de0be25867 (cherry picked from commit e540bcb) Co-authored-by: Tarun Karuturi <tkaruturi@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D63926846