[ET-VK][BE][ez] vTensor cleanup 7/N - Blanket replacement of packed_dim_whcn_idx with packed_dim
#5484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dim_whcn_idx` with `packed_dim` ## Context `packed_dim_whcn_idx` is a bit too verbose. Replace it with `packed_dim` for brevity. Differential Revision: [D63032323](https://our.internmc.facebook.com/intern/diff/D63032323/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5484
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 20f68b5 with merge base 8ef6c79 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63032323 |
SS-JIA
added a commit
that referenced
this pull request
Sep 19, 2024
…dim_whcn_idx` with `packed_dim` ## Context `packed_dim_whcn_idx` is a bit too verbose. Replace it with `packed_dim` for brevity. Differential Revision: [D63032323](https://our.internmc.facebook.com/intern/diff/D63032323/) ghstack-source-id: 243540489 Pull Request resolved: #5484
jorgep31415
approved these changes
Sep 19, 2024
…of `packed_dim_whcn_idx` with `packed_dim`" ## Context `packed_dim_whcn_idx` is a bit too verbose. Replace it with `packed_dim` for brevity. Differential Revision: [D63032323](https://our.internmc.facebook.com/intern/diff/D63032323/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Sep 19, 2024
…dim_whcn_idx` with `packed_dim` Pull Request resolved: #5484 ## Context `packed_dim_whcn_idx` is a bit too verbose. Replace it with `packed_dim` for brevity. Differential Revision: [D63032323](https://our.internmc.facebook.com/intern/diff/D63032323/) ghstack-source-id: 243563524
|
This pull request was exported from Phabricator. Differential Revision: D63032323 |
|
This pull request has been merged in 90d5191. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
packed_dim_whcn_idxwithpacked_dim#5484gpu_memory_layoutas a source of truth, usepacked_dim_whcn_idxdirectly #5479Context
packed_dim_whcn_idxis a bit too verbose. Replace it withpacked_dimfor brevity.Differential Revision: D63032323