New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move type arg to the end to match Aten constructors. #5379

Closed

shoumikhin wants to merge 1 commit into pytorch:main from shoumikhin:export-D62701089

Contributor

shoumikhin commented Sep 15, 2024

Summary: .

Differential Revision: D62701089

pytorch-bot bot commented Sep 15, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5379

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 932964e with merge base 0a501eb ():

NEW FAILURE - The following job has failed:

Build documentation / build (buck2) / Build doc (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Sep 15, 2024

This pull request was exported from Phabricator. Differential Revision: D62701089

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Sep 15, 2024

This pull request was exported from Phabricator. Differential Revision: D62701089

shoumikhin force-pushed the export-D62701089 branch from d549ffd to 104dd0d Compare

September 15, 2024 05:34

Contributor

facebook-github-bot commented Sep 15, 2024

This pull request was exported from Phabricator. Differential Revision: D62701089

shoumikhin force-pushed the export-D62701089 branch from 104dd0d to f36ea11 Compare

September 15, 2024 18:17

Contributor

facebook-github-bot commented Sep 15, 2024

This pull request was exported from Phabricator. Differential Revision: D62701089

shoumikhin force-pushed the export-D62701089 branch from f36ea11 to 98f91ac Compare

September 15, 2024 18:22

kirklandsign approved these changes

View reviewed changes

Contributor

facebook-github-bot commented Sep 16, 2024

This pull request was exported from Phabricator. Differential Revision: D62701089

shoumikhin force-pushed the export-D62701089 branch from 98f91ac to 8aa372a Compare

September 16, 2024 05:14

Contributor

facebook-github-bot commented Sep 16, 2024

This pull request was exported from Phabricator. Differential Revision: D62701089

shoumikhin force-pushed the export-D62701089 branch from 8aa372a to ba18669 Compare

September 16, 2024 05:18

Contributor

facebook-github-bot commented Sep 16, 2024

This pull request was exported from Phabricator. Differential Revision: D62701089

shoumikhin force-pushed the export-D62701089 branch from ba18669 to 66cc734 Compare

September 16, 2024 15:18

Contributor

facebook-github-bot commented Sep 16, 2024

This pull request was exported from Phabricator. Differential Revision: D62701089

shoumikhin force-pushed the export-D62701089 branch from 66cc734 to 9383d30 Compare

September 16, 2024 15:25

Contributor

facebook-github-bot commented Sep 16, 2024

This pull request was exported from Phabricator. Differential Revision: D62701089

shoumikhin force-pushed the export-D62701089 branch from 9383d30 to 08c4a9f Compare

September 16, 2024 17:40


          Move type arg to the end to match Aten constructors. (#5379)

932964e

Summary:
Pull Request resolved: #5379

.

Reviewed By: kirklandsign

Differential Revision: D62701089

Contributor

facebook-github-bot commented Sep 16, 2024

This pull request was exported from Phabricator. Differential Revision: D62701089

shoumikhin force-pushed the export-D62701089 branch from 08c4a9f to 932964e Compare

September 16, 2024 17:45

facebook-github-bot closed this in

c252553

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Sep 16, 2024

This pull request has been merged in c252553.

Contributor Author

shoumikhin commented Sep 16, 2024

@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request


          Move type arg to the end to match Aten constructors. (#5379)

e8c906e

Summary:
Pull Request resolved: #5379

.

Reviewed By: kirklandsign

Differential Revision: D62701089

fbshipit-source-id: 3f05961a43db9e6e372ee039c2d832227951fbf6
(cherry picked from commit c252553)

Collaborator

pytorchbot commented Sep 16, 2024

Cherry picking #5379

The cherry pick PR is at #5391 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

[v0.4.0] Release Tracker #5366 (comment)

Details for Dev Infra team

Raised by workflow job

pytorchbot mentioned this pull request

[v0.4.0] Release Tracker #5366

Open

dvorjackz pushed a commit that referenced this pull request


          Move type arg to the end to match Aten constructors. (#5391)

b5f7b85

Move type arg to the end to match Aten constructors. (#5379)

Summary:
Pull Request resolved: #5379

.

Reviewed By: kirklandsign

Differential Revision: D62701089

fbshipit-source-id: 3f05961a43db9e6e372ee039c2d832227951fbf6
(cherry picked from commit c252553)

Co-authored-by: Anthony Shoumikhin <shoumikhin@meta.com>
Co-authored-by: Anthony Shoumikhin <anthony@shoumikh.in>

lucylq pushed a commit that referenced this pull request


          Move type arg to the end to match Aten constructors. (#5379)

145a3cd

Summary:
Pull Request resolved: #5379

.

Reviewed By: kirklandsign

Differential Revision: D62701089

fbshipit-source-id: 3f05961a43db9e6e372ee039c2d832227951fbf6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged