Ensure 0-index in constant buffer is carried through #5145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Corner case: - no constants - some non-constants Then, the placeholder 0 value inside constant_buffer is not carried over to constant segment. This diff ensures the placeholder 0 value for non-constants is always carried over. Instead of checking len(constant_buffer_data), we check len(constant_buffer_offsets). The placeholder has no data, but it will create an offset entry in `SubsegmentOffsets`. Reviewed By: dbort Differential Revision: D62209852
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5145
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1c7a733 with merge base a25db2f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62209852 |
dbort
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Corner case:
Then, the placeholder 0 value inside constant_buffer is not carried over to constant segment.
This diff ensures the placeholder 0 value for non-constants is always carried over. Instead of checking len(constant_buffer_data), we check len(constant_buffer_offsets). The placeholder has no data, but it will create an offset entry in
SubsegmentOffsets.Reviewed By: dbort
Differential Revision: D62209852