Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Add install_requirements.bat for windows build #4862

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

python3kgae
Copy link
Contributor

Add install_requirements.bat on windows like install_requirements.sh.
Also force use ClangCL on windows in install_requirements.py.

For #4661

Add install_requirements.bat on windows like install_requirements.sh.
Also force use ClangCL on windows in install_requirements.py.

For pytorch#4661
Copy link

pytorch-bot bot commented Aug 23, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4862

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 03bea53 with merge base 11e8ed3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 23, 2024
@digantdesai digantdesai requested a review from dbort August 23, 2024 15:31
@digantdesai digantdesai added module: build Related to buck2 and cmake build triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Aug 23, 2024
Copy link
Contributor

@dbort dbort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for splitting this off. I'll merge it after the jobs run.

@dbort dbort merged commit ee6e4e9 into pytorch:main Aug 23, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build Related to buck2 and cmake build triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants