[Build] Support windows in resolve_buck.py #4856
Open
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4856
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
python3kgae
commented
Aug 23, 2024
| print(f"Downloading buck2 from {buck2_archive_url}...", file=sys.stderr) | ||
| urllib.request.urlretrieve(buck2_archive_url, archive_file.name) | ||
| archive_file, _ = urllib.request.urlretrieve(buck2_archive_url) |
There was a problem hiding this comment.
This change is based on posit-dev/py-shiny#287
It works around PermissionError on Windows.
This happens because urlretrieve is trying to open an already-open temporary file by name, which isn't permitted on Windows. It's basically the same as
from tempfile import NamedTemporaryFile
with NamedTemporaryFile() as tmp:
open(tmp.name, "wb")
digantdesai
added
module: build
|
Gentle ping. |
|
Don't have access to add more reviewer myself :( |
Add Windows support to BUCK_PLATFORM_MAP. Also use urllib.request.urlretrieve directly to work around PermissionError on Windows. For pytorch#4661
python3kgae
force-pushed
the
win_bld_buck2
branch
from
948a153
to
07f5c52
Compare
|
Rebased and gentle ping again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Windows support to BUCK_PLATFORM_MAP.
Also use urllib.request.urlretrieve directly to work around PermissionError on Windows.
For #4661