[llava][11/N] Migrate sampler to extension/llm #4460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Move sampler code to extension/llm so that it can be reused by llava runner. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4460
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7b2ba62 with merge base 1e14333 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
larryliu0820
added a commit
that referenced
this pull request
Jul 30, 2024
Summary: Move sampler code to extension/llm so that it can be reused by llava runner. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 25afaa8b3d6141991b9f1f4618ecaf3c7041dcc2 Pull Request resolved: #4460
facebook-github-bot
added
the
CLA Signed
helunwencser
approved these changes
Jul 30, 2024
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 1ec3444. |
dltn
added a commit
to dltn/executorch
that referenced
this pull request
Aug 22, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
Differential Revision: D61693469 Pull Request resolved: #4853
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: Move sampler code to extension/llm so that it can be reused by
llava runner.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D60458803