Move calculations away from GPU in Bandwidth profilers #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4445
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8ea94bb with merge base a743a3b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60396870 |
|
This pull request was exported from Phabricator. Differential Revision: D60396870 |
Esteb37
pushed a commit
to Esteb37/executorch
that referenced
this pull request
Jul 29, 2024
Summary: Pull Request resolved: pytorch#4445 This is simply to have a more accurate result when doing bandwidth profiling by removing calculations that can be done outside the shader, leaving only the read operations behind. Reviewed By: copyrightly Differential Revision: D60396870
Esteb37
force-pushed
the
export-D60396870
branch
from
121a93d
to
7fcd2e1
Compare
copyrightly
approved these changes
Jul 29, 2024
|
This pull request was exported from Phabricator. Differential Revision: D60396870 |
Esteb37
pushed a commit
to Esteb37/executorch
that referenced
this pull request
Jul 30, 2024
Summary: Pull Request resolved: pytorch#4445 This is simply to have a more accurate result when doing bandwidth profiling by removing calculations that can be done outside the shader, leaving only the read operations behind. Reviewed By: copyrightly Differential Revision: D60396870
Esteb37
force-pushed
the
export-D60396870
branch
from
7fcd2e1
to
32d4856
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60396870 |
Esteb37
pushed a commit
to Esteb37/executorch
that referenced
this pull request
Jul 30, 2024
Summary: Pull Request resolved: pytorch#4445 This is simply to have a more accurate result when doing bandwidth profiling by removing calculations that can be done outside the shader, leaving only the read operations behind. Reviewed By: copyrightly Differential Revision: D60396870
Esteb37
force-pushed
the
export-D60396870
branch
from
32d4856
to
911c684
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60396870 |
Esteb37
force-pushed
the
export-D60396870
branch
from
911c684
to
45a453c
Compare
Esteb37
pushed a commit
to Esteb37/executorch
that referenced
this pull request
Aug 1, 2024
Summary: Pull Request resolved: pytorch#4445 This is simply to have a more accurate result when doing bandwidth profiling by removing calculations that can be done outside the shader, leaving only the read operations behind. Reviewed By: copyrightly Differential Revision: D60396870
Summary: Pull Request resolved: pytorch#4445 This is simply to have a more accurate result when doing bandwidth profiling by removing calculations that can be done outside the shader, leaving only the read operations behind. Reviewed By: copyrightly Differential Revision: D60396870
|
This pull request was exported from Phabricator. Differential Revision: D60396870 |
Esteb37
force-pushed
the
export-D60396870
branch
from
45a453c
to
8ea94bb
Compare
|
This pull request has been merged in ad371a4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is simply to have a more accurate result when doing bandwidth profiling by removing calculations that can be done outside the shader, leaving only the read operations behind.
Reviewed By: copyrightly
Differential Revision: D60396870