remove target_sdk_version attributes #4394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4394
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled JobAs of commit eb7a12f with merge base 6c69ebd ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60174978 |
kirklandsign
approved these changes
Jul 24, 2024
|
This pull request was exported from Phabricator. Differential Revision: D60174978 |
rmaz
added a commit
to rmaz/executorch
that referenced
this pull request
Jul 24, 2024
Summary: Pull Request resolved: pytorch#4394 These should be set on top level targets, not libraries. Reviewed By: kirklandsign Differential Revision: D60174978
Summary: Pull Request resolved: pytorch#4394 These should be set on top level targets, not libraries. Reviewed By: kirklandsign Differential Revision: D60174978
|
This pull request was exported from Phabricator. Differential Revision: D60174978 |
|
This pull request has been merged in 5e8cce1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: These should be set on top level targets, not libraries.
Differential Revision: D60174978