Inspector should allow explicit None for delegate_map #4136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4136
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit d9b0090 with merge base c839b9e ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59298227 |
|
This pull request was exported from Phabricator. Differential Revision: D59298227 |
dulinriley
added a commit
to dulinriley/executorch-1
that referenced
this pull request
Jul 2, 2024
Summary: Pull Request resolved: pytorch#4136 The SDK inspector should allow parsing delegates that have a `None` for their delegate_map. This is explicitly None, and not unspecified, which is why the default of an empty dict didn't work. Use `or {}` to instead detect None. Reviewed By: Olivia-liu Differential Revision: D59298227
dulinriley
force-pushed
the
export-D59298227
branch
from
2282441
to
6c5bc83
Compare
Olivia-liu
approved these changes
Jul 2, 2024
|
This pull request was exported from Phabricator. Differential Revision: D59298227 |
dulinriley
added a commit
to dulinriley/executorch-1
that referenced
this pull request
Jul 2, 2024
Summary: Pull Request resolved: pytorch#4136 The SDK inspector should allow parsing delegates that have a `None` for their delegate_map. This is explicitly None, and not unspecified, which is why the default of an empty dict didn't work. Use `or {}` to instead detect None. Reviewed By: Olivia-liu Differential Revision: D59298227
dulinriley
force-pushed
the
export-D59298227
branch
from
6c5bc83
to
5d78a7d
Compare
Summary: Pull Request resolved: pytorch#4136 The SDK inspector should allow parsing delegates that have a `None` for their delegate_map. This is explicitly None, and not unspecified, which is why the default of an empty dict didn't work. Use `or {}` to instead detect None. Reviewed By: Olivia-liu Differential Revision: D59298227
|
This pull request was exported from Phabricator. Differential Revision: D59298227 |
dulinriley
force-pushed
the
export-D59298227
branch
from
5d78a7d
to
d9b0090
Compare
|
This pull request has been merged in 970e278. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The SDK inspector should allow parsing delegates that have a
Nonefor their delegate_map. This is explicitly None, and not unspecified, which
is why the default of an empty dict didn't work.
Use
or {}to instead detect None.Differential Revision: D59298227