Link MPS and CoreML delegate library into portable_lib #4040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4040
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (2 Unrelated Failures)As of commit 822a053 with merge base 970e278 ( UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
added
ciflow/binaries
ciflow/binaries/all
larryliu0820
changed the title
dbort
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Now that these are enabled, please update https://github.com/pytorch/executorch/blob/enable_mps_pip/README-wheel.md to mention CoreML and MPS, on a bullet under the XNNPACK item, like
- [macOS only] The Core ML and MPS backends are also linked into the prebuilt module
Summary: As titled. MPS should be linked into portable_lib on mac. Test Plan: See CI job works? Reviewers: Subscribers: Tasks: Tags:
larryliu0820
force-pushed
the
enable_mps_pip
branch
from
3f0b1d3
to
822a053
Compare
dbort
approved these changes
Jul 3, 2024
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@larryliu0820 merged this pull request in 38d67db. |
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
Jul 5, 2024
Summary: As titled. MPS and CoreML should be linked into portable_lib on mac. Pull Request resolved: pytorch#4040 Test Plan: See CI job works? Reviewed By: dbort Differential Revision: D59351891 Pulled By: larryliu0820 fbshipit-source-id: 2d551b84b1fd09995ef3cbf0594b2e1b46854276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. MPS and CoreML should be linked into portable_lib on mac.
Test Plan: See CI job works?
Reviewers:
Subscribers:
Tasks:
Tags: