Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-ONLY] Set pytorch to 2.4 #3994

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Jun 17, 2024

Set pytorch to 2.4

  • github workflows
  • CI

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 17, 2024
Copy link

pytorch-bot bot commented Jun 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3994

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit d3681bf with merge base 4b6331d (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@lucylq lucylq force-pushed the lfq.release-0.3.0-changes branch 5 times, most recently from 255a3b4 to a18fe5f Compare June 17, 2024 17:03
@kirklandsign
Copy link
Contributor

merge to release/0.3 or main?

@lucylq lucylq changed the base branch from main to release/0.3 June 17, 2024 18:46
@lucylq
Copy link
Contributor Author

lucylq commented Jun 17, 2024

merge to release/0.3 or main?

ahh good catch - updated!

@lucylq lucylq force-pushed the lfq.release-0.3.0-changes branch 2 times, most recently from f6daac5 to 1108ab6 Compare June 17, 2024 22:38
@lucylq lucylq changed the title Release 0.3.0 changes [RELEASE-ONLY] Set pytorch to 2.4 Jun 18, 2024
@mergennachin
Copy link
Contributor

mergennachin commented Jun 18, 2024

  • I added ciflow/trunk tag to run trunk jobs
  • Are you gonna modify install_requirements.sh as well to install latest torch rc candidates? Could be a follow-up PR too.

@lucylq
Copy link
Contributor Author

lucylq commented Jun 18, 2024

  • I added ciflow/trunk tag to run trunk jobs
  • Are you gonna modify install_requirements.sh as well to install latest torch rc candidates? Could be a follow-up PR too.

It looks like 2.4 doesn't have a pip package yet, so may need to wait for that before modifying install_requirements.sh?
https://pypi.org/project/torch/2.4.0/

#3986

@lucylq lucylq force-pushed the lfq.release-0.3.0-changes branch from 1108ab6 to d3681bf Compare June 18, 2024 17:28
@lucylq lucylq merged commit d27c3a4 into release/0.3 Jun 18, 2024
102 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants