Fix dequantize_per_channel for single dimension input tensor #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3867
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 1fa55c4 with merge base 2216cae ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58221156 |
larryliu0820
approved these changes
Jun 6, 2024
tarun292
added a commit
that referenced
this pull request
Jun 6, 2024
Summary: This diff has two fixes: - When the input dimension is 1, we need to handle that separately - Fixing logic in how dim_list is generated Reviewed By: larryliu0820 Differential Revision: D58221156
tarun292
force-pushed
the
export-D58221156
branch
from
359e8eb
to
6f35fea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58221156 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D58221156 |
tarun292
added a commit
that referenced
this pull request
Jun 6, 2024
Summary: Pull Request resolved: #3867 This diff has two fixes: - When the input dimension is 1, we need to handle that separately - Fixing logic in how dim_list is generated Reviewed By: larryliu0820 Differential Revision: D58221156
tarun292
force-pushed
the
export-D58221156
branch
from
6f35fea
to
c11ee1d
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 15, 2024
Summary: This diff has two fixes: - When the input dimension is 1, we need to handle that separately - Fixing logic in how dim_list is generated Reviewed By: larryliu0820 Differential Revision: D58221156
facebook-github-bot
force-pushed
the
export-D58221156
branch
from
c11ee1d
to
6d1966c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58221156 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D58221156 |
tarun292
added a commit
that referenced
this pull request
Jun 15, 2024
Summary: Pull Request resolved: #3867 This diff has two fixes: - When the input dimension is 1, we need to handle that separately - Fixing logic in how dim_list is generated Reviewed By: larryliu0820 Differential Revision: D58221156
tarun292
force-pushed
the
export-D58221156
branch
from
6d1966c
to
923bc70
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
Summary: This diff has two fixes: - When the input dimension is 1, we need to handle that separately - Fixing logic in how dim_list is generated Reviewed By: larryliu0820 Differential Revision: D58221156
facebook-github-bot
force-pushed
the
export-D58221156
branch
from
923bc70
to
139ee94
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58221156 |
Summary: Pull Request resolved: #3867 This diff has two fixes: - When the input dimension is 1, we need to handle that separately - Fixing logic in how dim_list is generated Reviewed By: larryliu0820 Differential Revision: D58221156
tarun292
force-pushed
the
export-D58221156
branch
from
139ee94
to
1fa55c4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58221156 |
|
This pull request has been merged in c6fb9da. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff has two fixes:
Differential Revision: D58221156