Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the exported program after passes #3860

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Jun 5, 2024

Summary: There are some passes running on ExportedProgram, but we didn't verify them immediately and it may cause failure in the later downstream work.

Differential Revision: D58212409

Summary: There are some passes running on ExportedProgram, but we didn't verify them immediately and it may cause failure in the later downstream work.

Differential Revision: D58212409
Copy link

pytorch-bot bot commented Jun 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3860

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4db5853 with merge base 7bb2c58 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D58212409

@chuntl
Copy link
Contributor

chuntl commented Jun 6, 2024

Hi @cccclai ,

We have picked this change to test on our testing pipeline, but we meed some issues like:

  1. torch._export.verifier.SpecViolationError: User output aten_linear_default_24 is not in the correct order or is not found in the exported program's user_output list: ('aten_addmm_default_48',).
  2. torch._export.verifier.SpecViolationError: User output aten_pixel_unshuffle_default is not in the correct order or is not found in the exported program's user_output list: ('aten_view_copy_default_1',).

Will check these kind of issues and bring up another PR later, thank you!

BR,
chuntl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants