Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[For testing/docker build] Update buck to 2024-05-15 #3697

Closed
wants to merge 2 commits into from

Conversation

kirklandsign
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented May 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3697

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 7ea4213 with merge base bc5ba99 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2024
@mergennachin
Copy link
Contributor

I think there are more references to the old buck version (ci configs as well as docs).

https://github.com/search?q=repo%3Apytorch%2Fexecutorch%202024-02-15&type=code

we need to update them all atomically

@kirklandsign
Copy link
Contributor Author

Need to update https://ossci-macos.s3.amazonaws.com/buck2-aarch64-apple-darwin.zst

I asked Huy about this.

Meanwhile, I will wait for this round of CI to give me signals and I will push the commit to fix other references to buck version

@kirklandsign kirklandsign changed the title update buck Update buck to 2024-05-15 May 21, 2024
@kirklandsign
Copy link
Contributor Author

I will use #3698. This PR is just for CI since it's already running

@kirklandsign
Copy link
Contributor Author

Signals are promising so far.

@kirklandsign kirklandsign changed the title Update buck to 2024-05-15 [For testing/docker build] Update buck to 2024-05-15 May 21, 2024
@kirklandsign
Copy link
Contributor Author

Signals are good. Now use #3698

@kirklandsign kirklandsign deleted the upgrade-buck branch September 6, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants