Use quantize_and_export_to_jarvis in more places #3686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: It's been on the to-do list for a while to clean that up. It's only used in `export_program` to properly put the model in eval mode. Now that we only allow `nn.Module`, there are only two cases: `nn.Module`, which will have `eval()`, and `GraphModule`, which can use `torch.ao.quantization.move_exported_model_to_eval`, which we already called before with the `pt2_quant` flag. Now that the flag is not needed, remove it everywhere! We also promote the `quantize_and_export_program` function to `__init__.py` as a compiler API, because it can be quite useful. Differential Revision: D57491621
Summary: As titled. It cleans up a lot of tests, is easier to read and encapsulates things better. Differential Revision: D57554527
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3686
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 579b499 with merge base 91ef7fb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57554527 |
dulinriley
approved these changes
May 20, 2024
| @@ -16,17 +16,17 @@ | |||
|
|
|||
|
|
|||
| def export_program( | |||
| model: Callable, | |||
| model: torch.nn.Module, | |||
There was a problem hiding this comment.
This line seems to be duplicated from #3676, is that a mistake? Are these stacked incorrectly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled. It cleans up a lot of tests, is easier to read and encapsulates things better.
Differential Revision: D57554527