Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sdk_example_runner.sh #3431

Open
wants to merge 1 commit into
base: release/0.2
Choose a base branch
from
+8 −16
Open

Fix sdk_example_runner.sh #3431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions examples/sdk/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ set(_common_include_directories ${EXECUTORCH_ROOT}/..)
# Find prebuilt libraries. executorch package should contain
# portable_ops_lib, etdump, bundled_program.
find_package(executorch CONFIG REQUIRED)
target_link_options_shared_lib(executorch)
target_link_options_shared_lib(portable_ops_lib)

target_include_directories(executorch INTERFACE ${_common_include_directories})

find_package(
Expand All @@ -48,18 +51,6 @@ add_executable(sdk_example_runner
sdk_example_runner/sdk_example_runner.cpp)
target_compile_options(executorch INTERFACE -DET_EVENT_TRACER_ENABLED)

# portable_ops_lib
gen_selected_ops("" "" "ON")
# Expect gen_selected_ops output file to be selected_operators.yaml
generate_bindings_for_kernels(
FUNCTIONS_YAML ${EXECUTORCH_ROOT}/kernels/portable/functions.yaml
)
gen_operators_lib(
"portable_ops_lib"
KERNEL_LIBS portable_kernels
DEPS executorch)

target_compile_options(portable_ops_lib INTERFACE -DET_EVENT_TRACER_ENABLED)
target_include_directories(
etdump
INTERFACE
Expand All @@ -72,6 +63,8 @@ target_link_libraries(
gflags
etdump
extension_data_loader
flatcc
bundled_program
portable_ops_lib)
flatccrt
portable_ops_lib
portable_kernels
)
3 changes: 1 addition & 2 deletions examples/sdk/test_sdk_example_runner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ cmake_install_executorch_sdk_lib() {
echo "Installing libexecutorch.a, libportable_kernels.a, libetdump.a, libbundled_program.a"
rm -rf cmake-out

retry cmake -DBUCK2="$BUCK" \
-DCMAKE_INSTALL_PREFIX=cmake-out \
retry cmake -DCMAKE_INSTALL_PREFIX=cmake-out \
-DCMAKE_BUILD_TYPE=Release \
-DEXECUTORCH_BUILD_SDK=ON \
-DEXECUTORCH_ENABLE_EVENT_TRACER=ON \
Expand Down
Loading