Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama2 readme #3315

Closed
wants to merge 1 commit into from
Closed

llama2 readme #3315

wants to merge 1 commit into from

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Apr 24, 2024

  • add note for embedding quantize, for llama3
  • re-order export args to be the same as llama2, group_size missing --

Copy link

pytorch-bot bot commented Apr 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3315

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9d8eb35 with merge base b560864 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2024
@lucylq lucylq requested a review from iseeyuan April 24, 2024 17:37
@lucylq lucylq marked this pull request as ready for review April 24, 2024 17:38
@facebook-github-bot
Copy link
Contributor

@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @lucylq !

@lucylq
Copy link
Contributor Author

lucylq commented Apr 24, 2024

@pytorchbot cherry-pick --onto release/0.2 -c docs

@facebook-github-bot
Copy link
Contributor

@lucylq merged this pull request in 34f59ed.

pytorchbot pushed a commit that referenced this pull request Apr 24, 2024
Summary:
- add note for embedding quantize, for llama3
- re-order export args to be the same as llama2, group_size missing `--`

Pull Request resolved: #3315

Reviewed By: cccclai

Differential Revision: D56528535

Pulled By: lucylq

fbshipit-source-id: 4453070339ebdb3d782b45f96fe43d28c7006092
(cherry picked from commit 34f59ed)
@pytorchbot
Copy link
Collaborator

Cherry picking #3315

The cherry pick PR is at #3326

Details for Dev Infra team Raised by workflow job

guangy10 pushed a commit that referenced this pull request Apr 24, 2024
Summary:
- add note for embedding quantize, for llama3
- re-order export args to be the same as llama2, group_size missing `--`

Pull Request resolved: #3315

Reviewed By: cccclai

Differential Revision: D56528535

Pulled By: lucylq

fbshipit-source-id: 4453070339ebdb3d782b45f96fe43d28c7006092
(cherry picked from commit 34f59ed)

Co-authored-by: Lucy Qiu <lfq@meta.com>
This was referenced Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants