Remove Inspector API usage from lib.py #327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary: Revert what I did to lib.py in D48456830. Reasoning: 1. We redesigned the Inspector interface in D49099840, so the Inspector won't work with the lib.py on master anymore; 2. We initially wanted to invoke Inspector from lib.py, but then later decided to have the user interact with Inspector directly. Users will be able to enter a CLI debugging flow from the Inspector directly. Once that's implemented and landed, we can then work on removing duplicated CLI features from lib.py. Differential Revision: D49249836 fbshipit-source-id: 7ca099b6dcc0cdf97088d6bbeff4c9362bc13003
|
This pull request was exported from Phabricator. Differential Revision: D49249836 |
Olivia-liu
force-pushed
the
export-D49249836
branch
from
0c4edef
to
1606a7f
Compare
|
This pull request has been merged in 73f699a. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
* refactor quantizer entry point quantize_model to be table driven, and scalable * add tokenizer arg consistently * code beautification * refactor and import ao api wholesale * code beautification * tab->spc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Revert what I did to lib.py in D48456830. Reasoning:
Users will be able to enter a CLI debugging flow from the Inspector directly. Once that's implemented and landed, we can then work on removing duplicated CLI features from lib.py.
Differential Revision: D49249836