Audit and update the pip package metadata #3265
Conversation
Fill out the recommended `project` keys, most of which will affect the web page that PyPI will render for the `executorch` package. See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#about-your-project for the latest guidance. Use https://github.com/pytorch/pytorch/blob/a21327e0b03cc18850a0608be2d9c5bd38fd4646/setup.py#L1394 as a guide for the actual values. Add a README-wheel.md file that will be included in the wheel, and will become the main page contents on PyPI. Test Plan: * Installed the package with `./install_requirements.sh` * Looked at the files under ~/miniconda3/envs/executorch/lib/python3.10/site-packages/executorch-0.2.0a0+1a499e0.dist-info. METADATA and LICENSE both contain the new metadata.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3265
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 2a89416 with merge base d3326a2 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
| Started](https://pytorch.org/executorch/stable/getting-started-setup.html) | ||
| * Set up the ExecuTorch environment and run PyTorch models locally. | ||
| * [Working with | ||
| local LLMs](https://pytorch.org/executorch/stable/llm/getting-started.html) |
There was a problem hiding this comment.
These llm URLs don't work yet, but they will when we go live. I tested by replacing "stable" with "0.2" in each URL -- when we go live, we'll update the "stable" symlink to point to "0.2" in the gh-pages branch.
|
There are bunch of CI failures you will need to look into. Please ensure it's addressed before merging |
|
@guangy10 doh, the I updated this PR to only touch the metadata without adding that dependency line. I'll need to modify the CI scripts to make this work. |
|
I'm not sure why the lint job is failing. Some of the suggestions it's giving look wrong, and I don't see those same suggestions when running locally. I'm re-running the job to see if it was temporary. EDIT: It was because of the new "python >=3.10" requirement. There's a new |
|
Trying to reinstate the |
|
Yeah, this PR doesn't even touch those files. |
Fill out the recommended
projectkeys, most of which will affect the web page that PyPI will render for theexecutorchpackage.See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#about-your-project for the latest guidance.
Use https://github.com/pytorch/pytorch/blob/a21327e0b03cc18850a0608be2d9c5bd38fd4646/setup.py#L1394 as a guide for the actual values.
Add a README-wheel.md file that will be included in the wheel, and will become the main page contents on PyPI.
Test Plan:
./install_requirements.sh