Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing runner in Linux selective build and custom ops jobs #313

Closed
wants to merge 2 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 13, 2023

I mistakenly replace this in #277. The runner is not set here, and causes syntax error, for example https://github.com/pytorch/executorch/actions/runs/6167285165. The workflow still works because the default linux.2xlarge is used (same runner type)

Testing

The annotation error is gone now https://github.com/pytorch/executorch/actions/runs/6175961826

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2023
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@huydhn huydhn marked this pull request as ready for review September 13, 2023 17:07
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@huydhn huydhn changed the title Fix missing runner in Linux selective build job Fix missing runner in Linux selective build and custom ops jobs Sep 13, 2023
@facebook-github-bot
Copy link
Contributor

@huydhn merged this pull request in 1f558c7.

Gasoonjia pushed a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants