Fix build-framework-ios CI job #2996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As titled. `build_apple_frameworks.sh` is copying all the exported headers out and in #2934 `//executorch/schema:program` is being moved to `exported_deps` and causing `build_apple_frameworks.sh` to not found it. This PR fixes it by moving it back to `deps`.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2996
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit becaf4e with merge base e641ffc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mcr229
approved these changes
Apr 11, 2024
kirklandsign
approved these changes
Apr 11, 2024
|
@larryliu0820 merged this pull request in 3b727a7. |
|
@pytorchbot cherry-pick --onto origin/release/0.2 --fixes https://github.com/pytorch/executorch/actions/runs/8765991204/job/24057585488 -c critical |
Cherry picking #2996Fail to submit the cherry pick PR: HTTP Error 422: Unprocessable Entity Details for Dev Infra teamRaised by workflow job |
pytorchbot
pushed a commit
that referenced
this pull request
Apr 20, 2024
Summary: As titled. `build_apple_frameworks.sh` is copying all the exported headers out and in #2934 `//executorch/schema:program` is being moved to `exported_deps` and causing `build_apple_frameworks.sh` to not able to copy generated headers `program_generated.h` and `scalar_type_generated.h`. This PR fixes it by moving it back to `deps`. Pull Request resolved: #2996 Reviewed By: kirklandsign Differential Revision: D56028952 Pulled By: larryliu0820 fbshipit-source-id: 2cd4999154877b0ac7b49cd1f54d518cba34b2f2 (cherry picked from commit 3b727a7)
larryliu0820
added a commit
that referenced
this pull request
Apr 20, 2024
Summary: As titled. `build_apple_frameworks.sh` is copying all the exported headers out and in #2934 `//executorch/schema:program` is being moved to `exported_deps` and causing `build_apple_frameworks.sh` to not able to copy generated headers `program_generated.h` and `scalar_type_generated.h`. This PR fixes it by moving it back to `deps`. Pull Request resolved: #2996 Reviewed By: kirklandsign Differential Revision: D56028952 Pulled By: larryliu0820 fbshipit-source-id: 2cd4999154877b0ac7b49cd1f54d518cba34b2f2 (cherry picked from commit 3b727a7)
This was referenced Apr 20, 2024
huydhn
pushed a commit
that referenced
this pull request
Apr 21, 2024
Summary: As titled. `build_apple_frameworks.sh` is copying all the exported headers out and in #2934 `//executorch/schema:program` is being moved to `exported_deps` and causing `build_apple_frameworks.sh` to not able to copy generated headers `program_generated.h` and `scalar_type_generated.h`. This PR fixes it by moving it back to `deps`. Pull Request resolved: #2996 Reviewed By: kirklandsign Differential Revision: D56028952 Pulled By: larryliu0820 fbshipit-source-id: 2cd4999154877b0ac7b49cd1f54d518cba34b2f2
guangy10
pushed a commit
that referenced
this pull request
Apr 22, 2024
Summary: As titled. `build_apple_frameworks.sh` is copying all the exported headers out and in #2934 `//executorch/schema:program` is being moved to `exported_deps` and causing `build_apple_frameworks.sh` to not able to copy generated headers `program_generated.h` and `scalar_type_generated.h`. This PR fixes it by moving it back to `deps`. Pull Request resolved: #2996 Reviewed By: kirklandsign Differential Revision: D56028952 Pulled By: larryliu0820 fbshipit-source-id: 2cd4999154877b0ac7b49cd1f54d518cba34b2f2 (cherry picked from commit 3b727a7)
Merged
huydhn
added a commit
that referenced
this pull request
Apr 22, 2024
* Fix build-framework-ios CI job (#2996) Summary: As titled. `build_apple_frameworks.sh` is copying all the exported headers out and in #2934 `//executorch/schema:program` is being moved to `exported_deps` and causing `build_apple_frameworks.sh` to not able to copy generated headers `program_generated.h` and `scalar_type_generated.h`. This PR fixes it by moving it back to `deps`. Pull Request resolved: #2996 Reviewed By: kirklandsign Differential Revision: D56028952 Pulled By: larryliu0820 fbshipit-source-id: 2cd4999154877b0ac7b49cd1f54d518cba34b2f2 * Fix 3 CI jobs (#3006) Summary: * Apple / build-frameworks-ios / macos-job We removed libcustom_ops_lib.a in #2916 so need to remove it from `build_apple_frameworks.sh`. * Lint / lintrunner / linux-job Remove extra line in backends/qualcomm/quantizer/utils.py * pull / unittest / macos (buck2) / macos-job Fix it by using `executorch_no_prim_ops` instead of `executorch` in MPS and CoreML. Pull Request resolved: #3006 Reviewed By: lucylq Differential Revision: D56048430 Pulled By: larryliu0820 fbshipit-source-id: 9dcb476eea446ea3aba566d595167c691fb00eec * Revert "Fix build-framework-ios CI job (#2996)" This reverts commit e365c5b. --------- Co-authored-by: Mengwei Liu <larryliu@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.
build_apple_frameworks.shis copying all the exported headers out and in #2934//executorch/schema:programis being moved toexported_depsand causingbuild_apple_frameworks.shto not able to copy generated headersprogram_generated.handscalar_type_generated.h.This PR fixes it by moving it back to
deps.