Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add executorch_no_prim_ops target #2934

Closed
wants to merge 1 commit into from
Closed

Add executorch_no_prim_ops target #2934

wants to merge 1 commit into from

Commits on Apr 9, 2024

  1. Add executorch_no_prim_ops target (#2934) 

    Summary:

Currently `libexecutorch.a` always contain prim ops. This becomes a problem when a binary contains 2 "versions" of `libexecutorch.a`, causing a double registration of the prim ops.

For example, `libA.so` depends on `libexecutorch.a` and a binary `B` depends on both `libA.so` and `libexecutorch.a`. Since both `libexecutorch.a` and `libA.so` contains prim ops, they will be registered twice.

In this PR I created another library `executorch_no_prim_ops` for `libA.so` to depend on.

Differential Revision: D55907752
    @larryliu0820 @facebook-github-bot
    larryliu0820 authored and facebook-github-bot committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    ec33d2d View commit details
    Browse the repository at this point in the history