New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fp32 as default data type because fp16 not fully supported #2597

Closed

mikekgfb wants to merge 1 commit into main from export-D55258223

Contributor

mikekgfb commented Mar 22, 2024

Summary: fp32 as default data type because fp16 not fully supported

Reviewed By: JacobSzwejbka

Differential Revision: D55258223

pytorch-bot bot commented Mar 22, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2597

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 6 Unrelated Failures

As of commit 6d05f5c with merge base a9dc341 ():

NEW FAILURES - The following jobs have failed:

pull / test-llama-runner-linux (fp16, buck2) / linux-job (gh)
RuntimeError: Command docker exec -t 74b8ad49fe2d5623c1766e07f0d0c8cc7362f0e5682d77b50e88565f0fd4b126 /exec failed with exit code 1
pull / test-llama-runner-linux (fp16, cmake) / linux-job (gh)
RuntimeError: Command docker exec -t d4bbe7185504e8fac0e1e8fecf48519b84ca79c12dff2f0cf38d073fc92f6cc6 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, buck2) / linux-job (gh)
RuntimeError: Command docker exec -t 1ff013296c7458612240decda1a9afa444c8f8eb33a2faf6075489d88bfb28c6 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, cmake) / linux-job (gh)
RuntimeError: Command docker exec -t 64baa8403a0fc60e2e448af7c2b83a0d4412969e197d1ab5efc4b3eb95a4cd3d /exec failed with exit code 1
pull / unittest / linux (buck2) / linux-job (gh)
RuntimeError: Command docker exec -t 813c0a4c6f7cb5720a2f8ccc0a8afda693efae94ed0e76e169bd8cf3d79938b0 /exec failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / test-models-linux (cmake, ic3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
Delegation fp32 error
pull / test-models-linux (cmake, mv2, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
Delegation fp32 error
pull / test-models-linux (cmake, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
Delegation fp32 error
pull / test-models-linux (cmake, resnet18, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
Delegation fp32 error
pull / test-models-linux (cmake, vit, xnnpack-delegation, linux.2xlarge, 90) / linux-job (gh)
Delegation fp32 error
pull / unittest / macos (buck2) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Mar 22, 2024

This pull request was exported from Phabricator. Differential Revision: D55258223

facebook-github-bot added the fb-exported label

mikekgfb force-pushed the export-D55258223 branch from 696ae42 to fd3ae66 Compare

March 22, 2024 20:06

mikekgfb added a commit that referenced this pull request


          fp32 as default data type because fp16 not fully supported (#2597)

fd3ae66

Summary:

fp32 as default data type because fp16 not fully supported

Reviewed By: JacobSzwejbka

Differential Revision: D55258223

Contributor

facebook-github-bot commented Mar 22, 2024

This pull request was exported from Phabricator. Differential Revision: D55258223

mikekgfb added a commit that referenced this pull request


          fp32 as default data type because fp16 not fully supported (#2597)

01deaca

Summary:

fp32 as default data type because fp16 not fully supported

Reviewed By: JacobSzwejbka

Differential Revision: D55258223

mikekgfb force-pushed the export-D55258223 branch from fd3ae66 to 01deaca Compare

March 22, 2024 20:07

Contributor

facebook-github-bot commented Mar 22, 2024

This pull request was exported from Phabricator. Differential Revision: D55258223

facebook-github-bot pushed a commit that referenced this pull request


          fp32 as default data type because fp16 not fully supported (#2597)

ee5c672

Summary:

fp32 as default data type because fp16 not fully supported

Reviewed By: JacobSzwejbka

Differential Revision: D55258223

facebook-github-bot force-pushed the export-D55258223 branch from 01deaca to ee5c672 Compare

March 22, 2024 20:13

Contributor

facebook-github-bot commented Mar 22, 2024

This pull request was exported from Phabricator. Differential Revision: D55258223

facebook-github-bot force-pushed the export-D55258223 branch from ee5c672 to d9ab8c2 Compare

March 23, 2024 00:10

facebook-github-bot pushed a commit that referenced this pull request


          fp32 as default data type because fp16 not fully supported (#2597)

d9ab8c2

Summary:

fp32 as default data type because fp16 not fully supported

Reviewed By: JacobSzwejbka

Differential Revision: D55258223

Contributor

facebook-github-bot commented Mar 23, 2024

This pull request was exported from Phabricator. Differential Revision: D55258223

mikekgfb added a commit that referenced this pull request


          fp32 as default data type because fp16 not fully supported (#2597)

c25daee

Summary:

fp32 as default data type because fp16 not fully supported

Reviewed By: JacobSzwejbka

Differential Revision: D55258223

mikekgfb force-pushed the export-D55258223 branch from d9ab8c2 to c25daee Compare

March 23, 2024 00:11

Contributor

facebook-github-bot commented Mar 23, 2024

This pull request was exported from Phabricator. Differential Revision: D55258223

mikekgfb requested review from lucylq, larryliu0820, mergennachin, JacobSzwejbka and kimishpatel

March 23, 2024 00:23

larryliu0820 approved these changes

View reviewed changes

facebook-github-bot pushed a commit that referenced this pull request


          fp32 as default data type because fp16 not fully supported (#2597)

3822ff1

Summary:

fp32 as default data type because fp16 not fully supported

Reviewed By: JacobSzwejbka

Differential Revision: D55258223

facebook-github-bot force-pushed the export-D55258223 branch from c25daee to 3822ff1 Compare

March 23, 2024 00:52

Contributor

facebook-github-bot commented Mar 23, 2024

This pull request was exported from Phabricator. Differential Revision: D55258223


          fp32 as default data type because fp16 not fully supported (#2597)

6d05f5c

Summary:

fp32 as default data type because fp16 not fully supported

Reviewed By: JacobSzwejbka

Differential Revision: D55258223

facebook-github-bot force-pushed the export-D55258223 branch from 3822ff1 to 6d05f5c Compare

March 23, 2024 03:43

Contributor

facebook-github-bot commented Mar 23, 2024

This pull request was exported from Phabricator. Differential Revision: D55258223

facebook-github-bot closed this in

126f918

Contributor

facebook-github-bot commented Mar 23, 2024

This pull request has been merged in 126f918.

facebook-github-bot added the Merged label

mcr229 pushed a commit that referenced this pull request


          fp32 as default data type because fp16 not fully supported (#2597)

Summary:
Pull Request resolved: #2597

fp32 as default data type because fp16 not fully supported

Reviewed By: JacobSzwejbka

Differential Revision: D55258223

fbshipit-source-id: fee91743aa05f1c2e38d451c2bc146b2f7a31ff0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

larryliu0820 larryliu0820 approved these changes

lucylq Awaiting requested review from lucylq

mergennachin Awaiting requested review from mergennachin

JacobSzwejbka Awaiting requested review from JacobSzwejbka

kimishpatel Awaiting requested review from kimishpatel

Labels

CLA Signed fb-exported Merged