Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qualcomm AI Engine Direct - Adapt to new IR capture flow #2431

Closed
wants to merge 5 commits into from
Closed

Qualcomm AI Engine Direct - Adapt to new IR capture flow #2431

wants to merge 5 commits into from

Conversation

chuntl
Copy link
Contributor

@chuntl chuntl commented Mar 14, 2024

Summary:

  • Change existent IR capture flow (exir.capture) to torch.export.export
  • Add custom decomposition table for mitigating maintaining effort
  • Fix breakages encountered and make sure all tests passed as well

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 14, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2431

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit eac96b1 with merge base 4111b3f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @chuntl!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@chuntl chuntl marked this pull request as draft March 21, 2024 01:57
@chuntl chuntl marked this pull request as ready for review March 21, 2024 01:57
@chuntl chuntl force-pushed the test branch 6 times, most recently from bbf5867 to 4d2882b Compare March 22, 2024 01:29
@chuntl
Qualcomm AI Engine Direct - Adapt to new IR capture flow
62f7545 
Summary:
- Change existent IR capture flow (exir.capture) to torch.export.export
- Add custom decomposition table for mitigating maintaining effort
- Fix breakages encountered and make sure all tests passed as well
@chuntl
Resolve the conflict
12a9263
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2024
@chuntl
Copy link
Contributor Author

chuntl commented Mar 26, 2024

Hi @cccclai ,

Thanks for the help to the CLA permission.
The PR is rebased to mainline now, could you please help to merge this PR, thank you!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Contributor

cccclai commented Mar 26, 2024 •
edited
Loading

Thanks! The pr looks great. Our CI is a bit broken at the moment. I'll merge it as soon as it's fixed.

@mergennachin mergennachin self-requested a review March 27, 2024 23:37
@facebook-github-bot
Copy link
Contributor

@cccclai merged this pull request in e7a429a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

@cccclai cccclai cccclai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chuntl @facebook-github-bot @cccclai @mergennachin