Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nightly build workflow #2363

Closed
wants to merge 6 commits into from
Closed

Add nightly build workflow #2363

wants to merge 6 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Mar 12, 2024

Onboard ExecuTorch to Nova wheel build workflow https://github.com/pytorch/test-infra/wiki/Using-Nova-Reusable-Build-Workflows. The wheel is built using python setup.py bdist_wheel. All the pre-build, post-build, and smoke test scripts are placeholders.

Having this will enable the team to easily add more logic into the build scripts later.

Testing

@huydhn huydhn requested a review from guangy10 March 12, 2024 03:19
Copy link

pytorch-bot bot commented Mar 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2363

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c8f49b2 with merge base e5ef31d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2024
Copy link

pytorch-bot bot commented Mar 12, 2024

Warning: Unknown label ciflow/binaries/all.
Currently recognized labels are

  • ciflow/nightly
  • ciflow/trunk

Please add the new label to .github/pytorch-probot.yml

@huydhn huydhn marked this pull request as ready for review March 12, 2024 03:30
@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@guangy10 guangy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow setup looks good to me with the placeholders for scripts building ET artifacts.

@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@huydhn merged this pull request in 7e5a841.

huydhn added a commit to pytorch/test-infra that referenced this pull request Mar 13, 2024
I have the approval from ExecuTorch to onboard to Nova binary build
workflows pytorch/executorch#2363. That covers
wheel first. Once the PR lands, we can add a nightly trigger to start
generating ExecuTorch wheels.

I'm seeing pytorchbot with write access to the repo from `bunnylol oss
pytorch/executorch`, so I think this is the only step needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants