Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused aten_compatible argument #2356

Closed
wants to merge 4 commits into from

Conversation

Gasoonjia
Copy link
Contributor

Summary: aten_compatible argument is no longer used in the op_test function. Remove that for mis-leading.

Differential Revision: D54778606

Copy link

pytorch-bot bot commented Mar 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2356

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit e4e5a14 with merge base 4ef264e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54778606

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Mar 11, 2024
Summary:

aten_compatible argument is no longer used in the op_test function. Remove that for mis-leading.

Differential Revision: D54778606
Summary:

This update makes util function support empty dim order, to make the empty dim order behave the same as empty memory format (preserve_format).
bypass-github-export-checks

Differential Revision: D54236386
Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54285070
Summary:

bypass-github-export-checks

Reviewed By: digantdesai

Differential Revision: D54341919
Summary:
bypass-github-export-checks


aten_compatible argument is no longer used in the op_test function. Remove that for mis-leading.

Differential Revision: D54778606
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54778606

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Mar 12, 2024
Summary:
bypass-github-export-checks


aten_compatible argument is no longer used in the op_test function. Remove that for mis-leading.

Differential Revision: D54778606
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 15790c8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants