Use cords to store constant and delegate segment data #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2281
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 11f0e9e with merge base aed32c4 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54523957 |
Summary: Update `extract_constant_segment` and `extract_delegate_segment` to place constants and delegates into cord data structures. Update `serialize_pte_binary` to compile the cords together. Remove the original extract_constant_segment/extract_delegate_segment logic, remove append_segments. Reviewed By: dbort Differential Revision: D54523957
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Mar 7, 2024
Summary: Update `extract_constant_segment` and `extract_delegate_segment` to place constants and delegates into cord data structures. Update `serialize_pte_binary` to compile the cords together. Remove the original extract_constant_segment/extract_delegate_segment logic, remove append_segments. Reviewed By: dbort Differential Revision: D54523957
|
This pull request was exported from Phabricator. Differential Revision: D54523957 |
|
This pull request was exported from Phabricator. Differential Revision: D54523957 |
|
This pull request has been merged in 47b837b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update
extract_constant_segmentandextract_delegate_segmentto place constants and delegates into cord data structures.Update
serialize_pte_binaryto compile the cords together.Remove the original extract_constant_segment/extract_delegate_segment logic, remove append_segments.
Reviewed By: dbort
Differential Revision: D54523957